[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680008#comment-17680008 ] Ishan Chattopadhyaya commented on SOLR-15616: - I've opened a new issue about

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680002#comment-17680002 ] Noble Paul commented on SOLR-15616: --- {quote} you should have reverted the change immedi

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679930#comment-17679930 ] Ishan Chattopadhyaya commented on SOLR-15616: - Thanks [~dsmiley]! :-) > Allo

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679877#comment-17679877 ] David Smiley commented on SOLR-15616: - Ishan, if "gradlew check" or precommit isn't w

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679862#comment-17679862 ] Ishan Chattopadhyaya commented on SOLR-15616: - !Screenshot from 2023-01-23 2

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679855#comment-17679855 ] Ishan Chattopadhyaya commented on SOLR-15616: - bq. you made not 1 but 2 commi

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679852#comment-17679852 ] Kevin Risden commented on SOLR-15616: - {quote}That is a ridiculous statement right th

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679849#comment-17679849 ] Ishan Chattopadhyaya commented on SOLR-15616: - bq. What is the contents of gr

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679847#comment-17679847 ] Ishan Chattopadhyaya commented on SOLR-15616: - bq. You are explicitly working

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679843#comment-17679843 ] Kevin Risden commented on SOLR-15616: - What is the contents of gradle.properties? >

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679841#comment-17679841 ] Ishan Chattopadhyaya commented on SOLR-15616: - bq. It is fixed. I hope you'r

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679837#comment-17679837 ] Kevin Risden commented on SOLR-15616: - > If a system with 64GB RAM is running into OO

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679835#comment-17679835 ] Ishan Chattopadhyaya commented on SOLR-15616: - If a system with 64GB RAM is r

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679833#comment-17679833 ] Ishan Chattopadhyaya commented on SOLR-15616: - Did the localSettings thing no

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679832#comment-17679832 ] Ishan Chattopadhyaya commented on SOLR-15616: - Running the gradlew check afte

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679831#comment-17679831 ] Kevin Risden commented on SOLR-15616: - Rm only solr/modules/jaegertracer-configurator

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679830#comment-17679830 ] Ishan Chattopadhyaya commented on SOLR-15616: - After localSettings thing, I s

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679827#comment-17679827 ] Kevin Risden commented on SOLR-15616: - {quote}I do `git clean -fdx` every time before

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679828#comment-17679828 ] ASF subversion and git services commented on SOLR-15616: Commit 6

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679829#comment-17679829 ] ASF subversion and git services commented on SOLR-15616: Commit 9

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679825#comment-17679825 ] Ishan Chattopadhyaya commented on SOLR-15616: - I do `git clean -fdx` every ti

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679824#comment-17679824 ] Kevin Risden commented on SOLR-15616: - {code:java} IMPORTANT. This is the first time

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679823#comment-17679823 ] Ishan Chattopadhyaya commented on SOLR-15616: - Still can't run this gradlew c

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679820#comment-17679820 ] ASF subversion and git services commented on SOLR-15616: Commit f

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679819#comment-17679819 ] ASF subversion and git services commented on SOLR-15616: Commit f

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679808#comment-17679808 ] ASF subversion and git services commented on SOLR-15616: Commit b

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679813#comment-17679813 ] Ishan Chattopadhyaya commented on SOLR-15616: - I couldn't verify this commit

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679815#comment-17679815 ] Ishan Chattopadhyaya commented on SOLR-15616: - Oh, okay, thanks Kevin. I'll r

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679812#comment-17679812 ] Kevin Risden commented on SOLR-15616: - This immediately started causing build failure

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679806#comment-17679806 ] ASF subversion and git services commented on SOLR-15616: Commit 3

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677903#comment-17677903 ] Ishan Chattopadhyaya commented on SOLR-15616: - Good idea, I'll add the "Sec"

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677899#comment-17677899 ] Andrzej Bialecki commented on SOLR-15616: - LGTM, thanks for seeing this through,

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410478#comment-17410478 ] Andrzej Bialecki commented on SOLR-15616: - The XML config changes are ok, but the

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409455#comment-17409455 ] Ishan Chattopadhyaya commented on SOLR-15616: - Thanks. Updated the patch as p

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408710#comment-17408710 ] Andrzej Bialecki commented on SOLR-15616: - Maybe something like this? {code}

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408696#comment-17408696 ] Ishan Chattopadhyaya commented on SOLR-15616: - bq. I think I would prefer to

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408686#comment-17408686 ] Andrzej Bialecki commented on SOLR-15616: - This makes sense, and the patch looks

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408674#comment-17408674 ] Ishan Chattopadhyaya commented on SOLR-15616: - Here's a patch for this change