dsmiley merged PR #2869:
URL: https://github.com/apache/solr/pull/2869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on PR #2869:
URL: https://github.com/apache/solr/pull/2869#issuecomment-2564185125
I tweaked the tests based on feedback.
Looking to merge this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dsmiley commented on PR #2869:
URL: https://github.com/apache/solr/pull/2869#issuecomment-2496901453
> isn't that the real value of the Rule API, that's it's easy to wire in and
mix/match?
Rules bring an encapsulation benefit -- I'd say that's the biggest IMO.
Also mix/match, yes.
hossman commented on PR #2869:
URL: https://github.com/apache/solr/pull/2869#issuecomment-2494322602
I don't know about the `shutdown()` changes, but moving this logic into a
`Rule` seems great, and and using that `@Rule` in `SolrTestCase` (instead of
`SolrTestCaseJ4`) seems fine...
dsmiley commented on code in PR #2869:
URL: https://github.com/apache/solr/pull/2869#discussion_r1845676256
##
solr/test-framework/src/java/org/apache/solr/util/LogLevelTestRule.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
dsmiley opened a new pull request, #2869:
URL: https://github.com/apache/solr/pull/2869
Refactored the functionality into a TestRule, and moved from STCJ4 up to
SolrTestCase.
Move reinstatement of the root log level to shutdown()
(part of bigger goal of abandoning SolrTestCaseJ4)
