dsmiley commented on PR #2869: URL: https://github.com/apache/solr/pull/2869#issuecomment-2496901453
> isn't that the real value of the Rule API, that's it's easy to wire in and mix/match? Rules bring an encapsulation benefit -- I'd say that's the biggest IMO. Also mix/match, yes. But I don't see why any test would want to opt-out of this one given how cheap/light-weight it is, with its annotation based activation of the underlying Statement wrapper. I think we want to make it super-easy to debug a test with logs -- just add an annotation. Likewise I'm grateful other rules are defined always like system property clearing; I don't want tests to waste lines of code over basic book-keeping. I'd feel differently about a rule that seems heavy and/or is imposing in some way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
