Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-11-19 Thread via GitHub
malliaridis merged PR #2744: URL: https://github.com/apache/solr/pull/2744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-11-12 Thread via GitHub
malliaridis commented on code in PR #2744: URL: https://github.com/apache/solr/pull/2744#discussion_r1838018198 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-11-12 Thread via GitHub
malliaridis commented on code in PR #2744: URL: https://github.com/apache/solr/pull/2744#discussion_r1838016144 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-11-12 Thread via GitHub
malliaridis commented on code in PR #2744: URL: https://github.com/apache/solr/pull/2744#discussion_r1837998002 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-11-11 Thread via GitHub
epugh commented on code in PR #2744: URL: https://github.com/apache/solr/pull/2744#discussion_r1836934124 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lice

Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-11-11 Thread via GitHub
malliaridis commented on PR #2744: URL: https://github.com/apache/solr/pull/2744#issuecomment-2467885311 When I added the tests I noticed a few cases where we may require to patch things. To be precise: - URI is very lenient and allows many invalid strings without throwing URISyntaxExcep

Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-11-06 Thread via GitHub
malliaridis commented on PR #2744: URL: https://github.com/apache/solr/pull/2744#issuecomment-2460051147 I'll also would wait for https://github.com/apache/solr/pull/2725 to be merged first before completing thins one. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-10-18 Thread via GitHub
malliaridis commented on PR #2744: URL: https://github.com/apache/solr/pull/2744#issuecomment-2422403472 This PR is related and should be blocked by #2778 for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-10-18 Thread via GitHub
malliaridis commented on PR #2744: URL: https://github.com/apache/solr/pull/2744#issuecomment-2422402462 > Is this able to backwards ported to 9x? Seems good stuff! I think I could create a separate PR for backporting if we want these changes in 9x as well. I think a cherry-pick won't do

Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-10-17 Thread via GitHub
epugh commented on PR #2744: URL: https://github.com/apache/solr/pull/2744#issuecomment-2420464388 Is this able to backwards ported to 9x? Seems good stuff! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo