malliaridis commented on PR #2744: URL: https://github.com/apache/solr/pull/2744#issuecomment-2467885311
When I added the tests I noticed a few cases where we may require to patch things. To be precise: - URI is very lenient and allows many invalid strings without throwing URISyntaxException. Using URL in `portFromUrl` (that is used currently only by `StatusTool`) may be a good improvement - `checkCommunicationError` is `false` if a `SolrServerException` is thrown with a different root cause (e.g. NPE). I tried to avoid any changes unrelated to the ticket and we still have many untested methods in this part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
