gerlowskija commented on PR #2758:
URL: https://github.com/apache/solr/pull/2758#issuecomment-2435146190
Woohoo, thanks @epugh !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
epugh merged PR #2758:
URL: https://github.com/apache/solr/pull/2758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #2758:
URL: https://github.com/apache/solr/pull/2758#issuecomment-2422506868
Can I get a LGTM and then I'll add CHANGES.txt and merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
epugh commented on PR #2758:
URL: https://github.com/apache/solr/pull/2758#issuecomment-2413610994
> Deprecate as notice in ref guide. Also we have a separate deprecation
logging mechanism.
Cool.. So I will open a seperate PR that does those two things only in
`branch_9x`.
--
janhoy commented on PR #2758:
URL: https://github.com/apache/solr/pull/2758#issuecomment-2412422930
Deprecate as notice in ref guide. Also we have a separate deprecation
logging mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
epugh commented on PR #2758:
URL: https://github.com/apache/solr/pull/2758#issuecomment-2408820754
Thoughts on how to mark it "deprecated" in 9x? In some places it makes
sense to put out a log message. What would being deprecated mean here? Just
a PR that adds `@deprecated` in the `br
gerlowskija commented on code in PR #2758:
URL: https://github.com/apache/solr/pull/2758#discussion_r1797929696
##
solr/core/src/test/org/apache/solr/response/JSONWriterTest.java:
##
@@ -53,24 +53,17 @@ private void jsonEq(String expected, String received) {
}
@Test
- p
