epugh commented on code in PR #2754:
URL: https://github.com/apache/solr/pull/2754#discussion_r1797715501
##
solr/bin/solr.cmd:
##
@@ -1520,7 +1521,9 @@ for %%a in (%*) do (
) else (
set "option!option!=%%a"
if "!option!" equ "-d" set "SOLR_SERVER_DIR=%%a"
+
epugh commented on code in PR #2754:
URL: https://github.com/apache/solr/pull/2754#discussion_r1797712401
##
solr/bin/solr.cmd:
##
@@ -1520,7 +1521,9 @@ for %%a in (%*) do (
) else (
set "option!option!=%%a"
if "!option!" equ "-d" set "SOLR_SERVER_DIR=%%a"
+
malliaridis commented on code in PR #2754:
URL: https://github.com/apache/solr/pull/2754#discussion_r1797701186
##
solr/bin/solr.cmd:
##
@@ -1520,7 +1521,9 @@ for %%a in (%*) do (
) else (
set "option!option!=%%a"
if "!option!" equ "-d" set "SOLR_SERVER_DIR=%%a
epugh merged PR #2754:
URL: https://github.com/apache/solr/pull/2754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #2754:
URL: https://github.com/apache/solr/pull/2754#issuecomment-2407908067
Thanks for the additional review @malliaridis and I think I've got them
sorted. I love how hte docs look with hte long form of the variables, much
easier to read.
--
This is an automated m
epugh commented on PR #2754:
URL: https://github.com/apache/solr/pull/2754#issuecomment-2406215024
@malliaridis this is ready, I avoided deciding what to do about keep versus
--delete-config since deciding that wasn't requried to resolve -d conflicts.
--
This is an automated message from
