dsmiley commented on code in PR #2714:
URL: https://github.com/apache/solr/pull/2714#discussion_r1779756046
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -533,6 +535,47 @@ public NamedList request(SolrRequest
solrRequest, String collection
gerlowskija commented on code in PR #2714:
URL: https://github.com/apache/solr/pull/2714#discussion_r1779720899
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -533,6 +535,47 @@ public NamedList request(SolrRequest
solrRequest, String collec
dsmiley commented on code in PR #2714:
URL: https://github.com/apache/solr/pull/2714#discussion_r1779367542
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -533,6 +535,47 @@ public NamedList request(SolrRequest
solrRequest, String collection
dsmiley commented on PR #2714:
URL: https://github.com/apache/solr/pull/2714#issuecomment-2380412814
I'm a bit uncomfortable on adding methods to SolrClient that *mostly* throw
UnsupportedOperationException for most implementations.
I added the overloaded method I spoke of in the latest c
iamsanjay commented on PR #2714:
URL: https://github.com/apache/solr/pull/2714#issuecomment-2380392415
IMO, We should stick to keep on using interface reference whereas this
change force to use concrete classes. In #2689, Something similar we faced as
we are still deciding on the type of So
gerlowskija commented on PR #2714:
URL: https://github.com/apache/solr/pull/2714#issuecomment-2380057207
Alright, I've updated the PR to get rid of the thread-local which folks
didn't like.
For now the method is available on Http2SolrClient specifically - I'd love
to see this spread
gerlowskija commented on code in PR #2714:
URL: https://github.com/apache/solr/pull/2714#discussion_r1778725864
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -533,6 +534,25 @@ public NamedList request(SolrRequest
solrRequest, String collec
gerlowskija commented on code in PR #2714:
URL: https://github.com/apache/solr/pull/2714#discussion_r1778714874
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrClient.java:
##
@@ -1194,6 +1194,17 @@ public final NamedList request(final
SolrRequest request)
return r
gerlowskija commented on code in PR #2714:
URL: https://github.com/apache/solr/pull/2714#discussion_r1763347010
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java:
##
@@ -102,6 +111,24 @@ public static String buildRequestUrl(
return basePath + path;
gerlowskija commented on code in PR #2714:
URL: https://github.com/apache/solr/pull/2714#discussion_r1763347010
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java:
##
@@ -102,6 +111,24 @@ public static String buildRequestUrl(
return basePath + path;
dsmiley commented on code in PR #2714:
URL: https://github.com/apache/solr/pull/2714#discussion_r1761986518
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java:
##
@@ -102,6 +111,24 @@ public static String buildRequestUrl(
return basePath + path;
}
gerlowskija opened a new pull request, #2714:
URL: https://github.com/apache/solr/pull/2714
https://issues.apache.org/jira/browse/SOLR-17256
# Description
Mutating SolrRequest objects as setBasePath does is a bad practice, as the
modification isn't documented and many users expect
12 matches
Mail list logo
