iamsanjay commented on PR #2714: URL: https://github.com/apache/solr/pull/2714#issuecomment-2380392415
IMO, We should stick to keep on using interface reference whereas this change force to use concrete classes. In #2689, Something similar we faced as we are still deciding on the type of SolrClient that `CoreContainer#getDefaultHttpClient` should return. Initially I proposed that it should return `SolrClient`, but because `requestAsyn` is not available in SolrClient. Therefore, it was recommended to change the type to Http2SolrClient. In #2724, a new PR which would basically move `requestAsync` to SolrClient and by default throws UnsupportedOpeartionException. Same approach can be used here as well, add `requestBaseUrl` to SolrClient and default implementation should throw UnsupportedOperationException. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
