Re: [PR] SOLR-16995 Add a ReplicaCount to keep track of replicas per type [solr]

dsmiley merged PR #1928: URL: https://github.com/apache/solr/pull/1928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-16995 Add a ReplicaCount to keep track of replicas per type [solr]

dsmiley commented on PR #1928: URL: https://github.com/apache/solr/pull/1928#issuecomment-1760281500 HdfsCloudIncrementalBackupTest has been flapping since 2022-08, and lately steadily increasing. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] SOLR-16995 Add a ReplicaCount to keep track of replicas per type [solr]

pvcnt commented on PR #1928: URL: https://github.com/apache/solr/pull/1928#issuecomment-1748368064 I split the changes related to `leaderEligible` into a separate PR: #1911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] SOLR-16995 Add a ReplicaCount to keep track of replicas per type [solr]

pvcnt commented on code in PR #1928: URL: https://github.com/apache/solr/pull/1928#discussion_r1346955921 ## solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java: ## @@ -325,20 +326,18 @@ public static List getNodesForNewReplicas( ClusterState clusterStat

Re: [PR] SOLR-16995 Add a ReplicaCount to keep track of replicas per type [solr]

pvcnt commented on code in PR #1928: URL: https://github.com/apache/solr/pull/1928#discussion_r1346935984 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

Re: [PR] SOLR-16995 Add a ReplicaCount to keep track of replicas per type [solr]

dsmiley commented on code in PR #1928: URL: https://github.com/apache/solr/pull/1928#discussion_r1346464411 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] SOLR-16995 Add a ReplicaCount to keep track of replicas per type [solr]

dsmiley commented on code in PR #1928: URL: https://github.com/apache/solr/pull/1928#discussion_r1346448800 ## solr/core/src/java/org/apache/solr/cluster/placement/impl/PlacementRequestImpl.java: ## @@ -26,29 +25,23 @@ import org.apache.solr.cluster.Replica; import org.apache.

Re: [PR] SOLR-16995 Add a ReplicaCount to keep track of replicas per type [solr]

dsmiley commented on code in PR #1928: URL: https://github.com/apache/solr/pull/1928#discussion_r1346434338 ## solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java: ## @@ -325,20 +326,18 @@ public static List getNodesForNewReplicas( ClusterState clusterSt