dsmiley commented on code in PR #1928:
URL: https://github.com/apache/solr/pull/1928#discussion_r1346448800
##########
solr/core/src/java/org/apache/solr/cluster/placement/impl/PlacementRequestImpl.java:
##########
@@ -26,29 +25,23 @@
import org.apache.solr.cluster.Replica;
import org.apache.solr.cluster.SolrCollection;
import org.apache.solr.cluster.placement.PlacementRequest;
+import org.apache.solr.common.cloud.ReplicaCount;
public class PlacementRequestImpl implements PlacementRequest {
private final SolrCollection solrCollection;
private final Set<String> shardNames;
private final Set<Node> targetNodes;
- private final EnumMap<Replica.ReplicaType, Integer> countReplicas =
- new EnumMap<>(Replica.ReplicaType.class);
+ private final ReplicaCount numReplicas;
public PlacementRequestImpl(
SolrCollection solrCollection,
Set<String> shardNames,
Set<Node> targetNodes,
- int countNrtReplicas,
- int countTlogReplicas,
- int countPullReplicas) {
+ ReplicaCount numReplicas) {
Review Comment:
Not sure if it's worth adding an overloaded variant for
backwards-compatibility, albeit marked deprecated and a comment to remove in 10?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
