janhoy merged PR #2040:
URL: https://github.com/apache/solr/pull/2040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on PR #2040:
URL: https://github.com/apache/solr/pull/2040#issuecomment-1798119014
@risdenk, @noblepaul Please have another look. Now the logic is
* First look for well-known permission name (as before)
* If **not** a well-known name, and `path` is not specified, fail w
janhoy commented on code in PR #2040:
URL: https://github.com/apache/solr/pull/2040#discussion_r1380254600
##
solr/core/src/java/org/apache/solr/security/Permission.java:
##
@@ -52,18 +53,21 @@ static Permission load(Map m) {
p.role = readValueAsSet(m, "role");
if (Per
uschindler commented on PR #2040:
URL: https://github.com/apache/solr/pull/2040#issuecomment-1789769580
Thanks for the change, looks fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
uschindler commented on code in PR #2040:
URL: https://github.com/apache/solr/pull/2040#discussion_r1379387924
##
solr/core/src/java/org/apache/solr/security/Permission.java:
##
@@ -52,18 +53,21 @@ static Permission load(Map m) {
p.role = readValueAsSet(m, "role");
if
uschindler commented on code in PR #2040:
URL: https://github.com/apache/solr/pull/2040#discussion_r1379387924
##
solr/core/src/java/org/apache/solr/security/Permission.java:
##
@@ -52,18 +53,21 @@ static Permission load(Map m) {
p.role = readValueAsSet(m, "role");
if
uschindler commented on code in PR #2040:
URL: https://github.com/apache/solr/pull/2040#discussion_r1379386158
##
solr/core/src/java/org/apache/solr/security/Permission.java:
##
@@ -52,18 +53,21 @@ static Permission load(Map m) {
p.role = readValueAsSet(m, "role");
if
janhoy commented on code in PR #2040:
URL: https://github.com/apache/solr/pull/2040#discussion_r1379365149
##
solr/core/src/java/org/apache/solr/security/Permission.java:
##
@@ -52,18 +53,21 @@ static Permission load(Map m) {
p.role = readValueAsSet(m, "role");
if (Per
uschindler commented on PR #2040:
URL: https://github.com/apache/solr/pull/2040#issuecomment-1789319269
I font know internals of how the permissions work, so I only checked the
code under the assumption that you know what a correct permission name looks
like. Maybe cross check with @risdenk
uschindler commented on code in PR #2040:
URL: https://github.com/apache/solr/pull/2040#discussion_r1379023438
##
solr/core/src/java/org/apache/solr/security/Permission.java:
##
@@ -160,7 +164,12 @@ public String toString() {
return Utils.toJSONString(originalConfig);
}
janhoy commented on PR #2040:
URL: https://github.com/apache/solr/pull/2040#issuecomment-1789075290
> In the issue you wanted to add a warning of an unknown permission
occurred. Should we add this, too?
Agree. The updated PR now instead of maintaining a list of old "reserved"
permiss
uschindler commented on PR #2040:
URL: https://github.com/apache/solr/pull/2040#issuecomment-1777919120
In the issue you wanted to add a warning of an unknown permission occurred.
Should we add this, too?
--
This is an automated message from the Apache Git Service.
To respond to the messa
12 matches
Mail list logo
