Re: [PR] SOLR-16865 : Solr should warn about low disk space upon startup [solr]

2024-03-25 Thread via GitHub
github-actions[bot] commented on PR #2080: URL: https://github.com/apache/solr/pull/2080#issuecomment-2019129076 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

Re: [PR] SOLR-16865 : Solr should warn about low disk space upon startup [solr]

2024-01-25 Thread via GitHub
gerlowskija commented on PR #2080: URL: https://github.com/apache/solr/pull/2080#issuecomment-1911016614 As a side note, CoreContainer is definitely the correct place to invoke this warning logic, but I wonder whether the bulk of this code couldn't live in a static utility somewhere (looks

Re: [PR] SOLR-16865 : Solr should warn about low disk space upon startup [solr]

2024-01-25 Thread via GitHub
gerlowskija commented on PR #2080: URL: https://github.com/apache/solr/pull/2080#issuecomment-1911009201 I don't have too much context here, but happy to help out. I've updated this PR by pulling in the latest 'main', and it passes `./gradlew check -x test` which is great, but I

Re: [PR] SOLR-16865 : Solr should warn about low disk space upon startup [solr]

2024-01-04 Thread via GitHub
cpoerschke commented on PR #2080: URL: https://github.com/apache/solr/pull/2080#issuecomment-1876908119 Just re-discovered this pull request via the https://issues.apache.org/jira/browse/SOLR-16865 ticket -- based on its history tagging @chatman and @gerlowskija as potential reviewers, than

Re: [PR] SOLR-16865 : Solr should warn about low disk space upon startup [solr]

2023-12-01 Thread via GitHub
culmat commented on PR #2080: URL: https://github.com/apache/solr/pull/2080#issuecomment-1836674636 Thanks for the advice @cpoerschke. I merged main. Hope this time the validation will run through 🤞 Have a nice week end. -- This is an automated message from the Apache Git Service. To

Re: [PR] SOLR-16865 : Solr should warn about low disk space upon startup [solr]

2023-11-24 Thread via GitHub
cpoerschke commented on PR #2080: URL: https://github.com/apache/solr/pull/2080#issuecomment-1825382769 Probably same as https://github.com/apache/solr/pull/2069#issuecomment-1824836537 and merging in latest `origin/main` would fix it. -- This is an automated message from the Apache Git

Re: [PR] SOLR-16865 : Solr should warn about low disk space upon startup [solr]

2023-11-23 Thread via GitHub
culmat commented on PR #2080: URL: https://github.com/apache/solr/pull/2080#issuecomment-1824777605 Hi there, I don't know why this fails with style warnings on test / mock code I have not modified. -- This is an automated message from the Apache Git Service. To respond to the message

[PR] SOLR-16865 : Solr should warn about low disk space upon startup [solr]

2023-11-15 Thread via GitHub
culmat opened a new pull request, #2080: URL: https://github.com/apache/solr/pull/2080 https://issues.apache.org/jira/browse/SOLR-16865 # Description SOLR starts even with data directories on partitions with low disk space, which leads to crashes after the start. # S