gerlowskija commented on PR #2080:
URL: https://github.com/apache/solr/pull/2080#issuecomment-1911009201
I don't have too much context here, but happy to help out. I've updated
this PR by pulling in the latest 'main', and it passes `./gradlew check -x
test` which is great, but....
It looks like tests are failing because of an NPE introduced in this code:
```
2> Caused by: java.lang.NullPointerException
2> at java.base/java.util.Objects.requireNonNull(Objects.java:209)
~[?:?]
2> at
java.base/sun.nio.fs.UnixFileSystem.getPath(UnixFileSystem.java:263) ~[?:?]
2> at java.base/java.nio.file.Path.of(Path.java:147) ~[?:?]
2> at java.base/java.nio.file.Paths.get(Paths.java:69) ~[?:?]
2> at
org.apache.solr.core.CoreContainer.createFromDescriptor(CoreContainer.java:1706)
~[solr-core-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT
4f525ba5c8d2ab42c2e821ecd261acc555729729 [snapshot build, details omitted]]
2> at
org.apache.solr.core.CoreContainer.lambda$loadInternal$12(CoreContainer.java:1056)
~[solr-core-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT
4f525ba5c8d2ab42c2e821ecd261acc555729729 [snapshot build, details omitted]]
2> at
com.codahale.metrics.InstrumentedExecutorService$InstrumentedRunnable.run(InstrumentedExecutorService.java:212)
~[metrics-core-4.2.21.jar:4.2.21]
2> at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
~[?:?]
2> at
java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
2> at
org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:294)
~[solr-solrj-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT
4f525ba5c8d2ab42c2e821ecd261acc555729729 [snapshot build, details omitted]]
2> at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
~[?:?]
2> at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
~[?:?]
2> ... 1 more
```
The problem appears to be that some configurations don't define a data dir,
and so the `Paths.get` call
[here](https://github.com/apache/solr/pull/2080/files#diff-b55d06ed2f9b3b541be083c5bb4fc09ddf0017f55938c9091bc558ed2e48cc02R1706)
receives 'null'.
Should be pretty straightforward to bracket this check based on whether or
not we actually have a non-null dataDir, I'd guess? You want to take a crack
at it @culmat ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
