Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-12-05 Thread via GitHub
dsmiley commented on PR #2875: URL: https://github.com/apache/solr/pull/2875#issuecomment-2519697587 > My vote would be to tear it out. +1 I'm glad to hear you suggest this. I thought I might have been alone in this thinking. I don't think we should "support" this idea; it's too

Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-12-04 Thread via GitHub
gerlowskija commented on PR #2875: URL: https://github.com/apache/solr/pull/2875#issuecomment-2517757987 Alright - merged! Thanks all for the reviews! We'll still need to decide whether to remove the last remnants of the "trusted" configset code, which this PR mostly leaves in tact si

Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-12-04 Thread via GitHub
gerlowskija merged PR #2875: URL: https://github.com/apache/solr/pull/2875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-12-03 Thread via GitHub
HoustonPutman commented on PR #2875: URL: https://github.com/apache/solr/pull/2875#issuecomment-2515161658 > One thing we'll probably want/need to come up with a better story around is model-serving. > > Several places in our docs described using `` as a way not of loading new JARs,

Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-12-03 Thread via GitHub
gerlowskija commented on PR #2875: URL: https://github.com/apache/solr/pull/2875#issuecomment-2514995493 One thing we'll probably want/need to come up with a better story around is model-serving. Several places in our docs described using `` as a way not of loading new JARs, but of a

Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-12-03 Thread via GitHub
gerlowskija commented on code in PR #2875: URL: https://github.com/apache/solr/pull/2875#discussion_r1868009405 ## solr/core/src/test-files/solr/configsets/upload/with-lib-directive/solrconfig.xml: ## @@ -37,8 +37,6 @@ ${tests.luceneMatchVersion:LATEST} - Review Commen

Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-12-02 Thread via GitHub
gerlowskija commented on PR #2875: URL: https://github.com/apache/solr/pull/2875#issuecomment-2512047561 Alright - I've fixed merge conflicts, and tested out the examples, so this should be good to merge shortly. Thanks for the reviews all! I've created a corresponding change for bra

Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-12-02 Thread via GitHub
HoustonPutman commented on code in PR #2875: URL: https://github.com/apache/solr/pull/2875#discussion_r1866702118 ## solr/core/src/test-files/solr/configsets/upload/with-lib-directive/solrconfig.xml: ## @@ -37,8 +37,6 @@ ${tests.luceneMatchVersion:LATEST} - Review Comm

Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-11-22 Thread via GitHub
gerlowskija commented on PR #2875: URL: https://github.com/apache/solr/pull/2875#issuecomment-2494094532 > how do you want to handle https://github.com/apache/solr/pull/2861? Should it go in first, or after? Sorry - missed this comment the other day. I'm glad I didn't prevent you fr

Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-11-22 Thread via GitHub
epugh commented on PR #2875: URL: https://github.com/apache/solr/pull/2875#issuecomment-2493636331 @gerlowskija FYI I merged and backported https://issues.apache.org/jira/browse/SOLR-17556 to clear the decks, but which may impact this a bit. I think you plan for beefing up bin/solr start -

[PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-11-20 Thread via GitHub
gerlowskija opened a new pull request, #2875: URL: https://github.com/apache/solr/pull/2875 https://issues.apache.org/jira/browse/SOLR-16781 # Description Solr offers a number of ways for users to add JARs and resources to their classpath, including: * solr.xml entries

Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-11-20 Thread via GitHub
epugh commented on PR #2875: URL: https://github.com/apache/solr/pull/2875#issuecomment-2488606888 @gerlowskija how do you want to handle https://github.com/apache/solr/pull/2861? Should it go in first, or after? -- This is an automated message from the Apache Git Service. To respond