Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-31 Thread via GitHub
iamsanjay commented on PR #2144: URL: https://github.com/apache/solr/pull/2144#issuecomment-1919083424 > @iamsanjay - I would love to see this make it into 9.5, so I took the liberty of making a few of the changes that were outstanding from above. Namely: Thank you so much! Moving on

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-25 Thread via GitHub
gerlowskija merged PR #2144: URL: https://github.com/apache/solr/pull/2144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-24 Thread via GitHub
gerlowskija commented on PR #2144: URL: https://github.com/apache/solr/pull/2144#issuecomment-1909003780 @iamsanjay - I would love to see this make it into 9.5, so I took the liberty of making a few of the changes that were outstanding from above. Namely: - Changing the API to be `/

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-16 Thread via GitHub
gerlowskija commented on code in PR #2144: URL: https://github.com/apache/solr/pull/2144#discussion_r1453484032 ## solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-16 Thread via GitHub
gerlowskija commented on code in PR #2144: URL: https://github.com/apache/solr/pull/2144#discussion_r1453453346 ## solr/core/src/test/org/apache/solr/handler/admin/api/RequestCoreCommandStatusTest.java: ## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-14 Thread via GitHub
iamsanjay commented on code in PR #2144: URL: https://github.com/apache/solr/pull/2144#discussion_r1451726808 ## solr/core/src/test/org/apache/solr/handler/admin/api/RequestCoreCommandStatusTest.java: ## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-14 Thread via GitHub
iamsanjay commented on code in PR #2144: URL: https://github.com/apache/solr/pull/2144#discussion_r1451726292 ## solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-12 Thread via GitHub
gerlowskija commented on code in PR #2144: URL: https://github.com/apache/solr/pull/2144#discussion_r1450959834 ## solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-12 Thread via GitHub
gerlowskija commented on code in PR #2144: URL: https://github.com/apache/solr/pull/2144#discussion_r1450959834 ## solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-12 Thread via GitHub
gerlowskija commented on code in PR #2144: URL: https://github.com/apache/solr/pull/2144#discussion_r1450960030 ## solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-06 Thread via GitHub
iamsanjay commented on code in PR #2144: URL: https://github.com/apache/solr/pull/2144#discussion_r1443784158 ## solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-05 Thread via GitHub
gerlowskija commented on code in PR #2144: URL: https://github.com/apache/solr/pull/2144#discussion_r1442929054 ## solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-04 Thread via GitHub
iamsanjay commented on code in PR #2144: URL: https://github.com/apache/solr/pull/2144#discussion_r1442540458 ## solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-02 Thread via GitHub
gerlowskija commented on code in PR #2144: URL: https://github.com/apache/solr/pull/2144#discussion_r1439737702 ## solr/CHANGES.txt: ## @@ -124,6 +124,9 @@ Improvements * SOLR-17063: Do not retain log param references in LogWatcher (Michael Gibney) +* SOLR-16397: The comman

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-02 Thread via GitHub
gerlowskija commented on PR #2144: URL: https://github.com/apache/solr/pull/2144#issuecomment-1874248462 Hey - sorry for the delay in reviewing this over the holidays. Taking a look now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2023-12-11 Thread via GitHub
iamsanjay opened a new pull request, #2144: URL: https://github.com/apache/solr/pull/2144 https://issues.apache.org/jira/browse/SOLR-16397 # Description V2(JAX-RS) Endpoints for core admin op "command-status". # Solution This commit changes the v2 "comm