Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

janhoy merged PR #2175: URL: https://github.com/apache/solr/pull/2175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

janhoy commented on PR #2175: URL: https://github.com/apache/solr/pull/2175#issuecomment-1878786136 Thanks for nice proposals @uschindler , the method is now private and code cleaner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

janhoy commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442961491 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields) throw new SolrException(E

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

uschindler commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442595590 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -652,6 +657,7 @@ protected void readSchema(ConfigSetService.ConfigResource is) { loadCopyFi

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

uschindler commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442593581 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields) throw new SolrExcepti

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

uschindler commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442590015 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields) throw new SolrExcepti

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

janhoy commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442291279 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields) throw new SolrException(E

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

janhoy commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442292722 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields) throw new SolrException(E

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

janhoy commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442291279 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields) throw new SolrException(E

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

uschindler commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442080975 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields) throw new SolrExcepti

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

uschindler commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442078351 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields) throw new SolrExcepti

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

uschindler commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442076218 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields) throw new SolrExcepti

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

uschindler commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442076218 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields) throw new SolrExcepti

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

uschindler commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442023598 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields) throw new SolrExcepti

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

janhoy commented on PR #2175: URL: https://github.com/apache/solr/pull/2175#issuecomment-1875084210 Second attempt: The first attempt did not work for packages, since `FieldTypePluginLoader#init` was too early in the cycle to initialize analyzers from packages. Managed schema

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

janhoy commented on PR #2175: URL: https://github.com/apache/solr/pull/2175#issuecomment-1875068088 First attempt in efadf94dc6ac87027ef708c71c58d3848e7a9a0d: Naïve solution, explicitly calling `inform()` in `FieldTypePluginLoader`. The two tests from JIRA are added to this PR to demo

[PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

janhoy opened a new pull request, #2175: URL: https://github.com/apache/solr/pull/2175 https://issues.apache.org/jira/browse/SOLR-16203 Naïve solution, explicitly calling `inform()` in `FieldTypePluginLoader`. The two tests from JIRA are added to this PR to demonstrate. There