uschindler commented on code in PR #2175:
URL: https://github.com/apache/solr/pull/2175#discussion_r1442593581
##########
solr/core/src/java/org/apache/solr/schema/IndexSchema.java:
##########
@@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map<String,
Collection<String>> copyFields)
throw new SolrException(ErrorCode.SERVER_ERROR, msg);
}
+ /** Informs analyzers used by a fieldType. */
+ protected void informResourceLoaderAwareObjectsForFieldType(FieldType
fieldType) {
Review Comment:
This is not ideal. If you move the call to this private method into
`postReadInfom()` of *this* class (`IndexSchema`), then the subclass would also
call it and it could be private.
Here it is called in readSchema *after* `postReadInform()`. If it is moved
there both implementations automatically use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
