mkhludnev merged PR #2025:
URL: https://github.com/apache/solr/pull/2025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
mkhludnev commented on PR #2025:
URL: https://github.com/apache/solr/pull/2025#issuecomment-1845865301
@AndreyBozhko wdyt abt my changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
mkhludnev commented on PR #2025:
URL: https://github.com/apache/solr/pull/2025#issuecomment-1842173386
Thanks @AndreyBozhko I'll check it next week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
AndreyBozhko commented on PR #2025:
URL: https://github.com/apache/solr/pull/2025#issuecomment-1841596601
Hi @HoustonPutman @mkhludnev - anything else to address for this PR? If not,
then it should be good to merge, but I don't have access to do so myself.
--
This is an automated message
mkhludnev commented on code in PR #2025:
URL: https://github.com/apache/solr/pull/2025#discussion_r1385654200
##
solr/core/src/java/org/apache/solr/search/join/FiltersQParser.java:
##
@@ -61,6 +61,9 @@ protected BooleanQuery parseImpl() throws SyntaxError {
for (Map.Entry c
AndreyBozhko commented on code in PR #2025:
URL: https://github.com/apache/solr/pull/2025#discussion_r1385621132
##
solr/core/src/java/org/apache/solr/search/join/FiltersQParser.java:
##
@@ -61,6 +61,9 @@ protected BooleanQuery parseImpl() throws SyntaxError {
for (Map.Entr
AndreyBozhko commented on code in PR #2025:
URL: https://github.com/apache/solr/pull/2025#discussion_r1385606641
##
solr/solr-ref-guide/modules/query-guide/pages/other-parsers.adoc:
##
@@ -75,6 +75,16 @@ However, unlike `must`, the score of filter queries is
ignored.
Also, the
mkhludnev commented on code in PR #2025:
URL: https://github.com/apache/solr/pull/2025#discussion_r1384447321
##
solr/solr-ref-guide/modules/query-guide/pages/other-parsers.adoc:
##
@@ -75,6 +75,16 @@ However, unlike `must`, the score of filter queries is
ignored.
Also, these
AndreyBozhko commented on PR #2025:
URL: https://github.com/apache/solr/pull/2025#issuecomment-1783071590
Thanks for the review @HoustonPutman, feel free to merge this whenever you
have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
AndreyBozhko commented on PR #2025:
URL: https://github.com/apache/solr/pull/2025#issuecomment-1771097514
Since the similar parameter for DisMax/eDisMax query parsers is also named
`mm`, perhaps it makes sense to keep the naming consistent?
--
This is an automated message from the Apache
HoustonPutman commented on PR #2025:
URL: https://github.com/apache/solr/pull/2025#issuecomment-1769084229
I do like `minShouldMatch` a lot more than `mm`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
AndreyBozhko opened a new pull request, #2025:
URL: https://github.com/apache/solr/pull/2025
https://issues.apache.org/jira/browse/SOLR-13748
# Description
Added support for `mm` parameter to {!bool} query parser
# Tests
Added test suite for BoolQParser
12 matches
Mail list logo
