mkhludnev commented on code in PR #2025:
URL: https://github.com/apache/solr/pull/2025#discussion_r1384447321
##########
solr/solr-ref-guide/modules/query-guide/pages/other-parsers.adoc:
##########
@@ -75,6 +75,16 @@ However, unlike `must`, the score of filter queries is
ignored.
Also, these queries are cached in filter cache.
To avoid caching add either `cache=false` as local parameter, or
`"cache":"false"` property to underneath Query DLS Object.
+`mm`::
++
+[%autowidth,frame=none]
+|===
+|Optional |Default: `0`
+|===
++
+The number of optional clauses that must match. By default, no optional
clauses are necessary for a match
+(unless there are no required clauses). If this parameter is set, then the
specified number of `should` clauses is required.
Review Comment:
It's probably worth to clarify that when there are no required clauses it
works like mm=1.
##########
solr/core/src/java/org/apache/solr/search/join/FiltersQParser.java:
##########
@@ -61,6 +61,9 @@ protected BooleanQuery parseImpl() throws SyntaxError {
for (Map.Entry<QParser, Occur> clause : clauses.entrySet()) {
builder.add(unwrapQuery(clause.getKey().getQuery(), clause.getValue()),
clause.getValue());
}
+
+ builder.setMinimumNumberShouldMatch(minShouldMatch());
Review Comment:
Not sure why. MinShouldMatch matters only for SHOULD clauses, but never for
FILTER ever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
