sigram merged PR #81:
URL: https://github.com/apache/solr-sandbox/pull/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
markrmiller commented on PR #81:
URL: https://github.com/apache/solr-sandbox/pull/81#issuecomment-1790415703
Been a little while since I've looked at that code, but ...
Yes, the Kafka client is not thread safe. The design is a single thread
polls the queue and hands off records to an
sigram commented on PR #81:
URL: https://github.com/apache/solr-sandbox/pull/81#issuecomment-1790406978
@markrmiller I'm not sure I understand everything of what's going on in
`sendBatch` with workUnit. However, using executor here seems wrong because
Kafka client is NOT thread-safe. If I'm
sigram opened a new pull request, #81:
URL: https://github.com/apache/solr-sandbox/pull/81
When the support for other request types (ADMIN, CONFIGSET) was added part
of the original patch hasn't been applied, namely the changes to
`KafkaCrossDcConsumer.pollAndProcessRequests()` that allowed
