mlbiscoc commented on PR #3142:
URL: https://github.com/apache/solr/pull/3142#issuecomment-2623119702
> @mlbiscoc I should have reminded/and or run the nightly tests when I was
reviewing the path stuff.. Let's remember to do that as we continue!
Got it. Thanks @HoustonPutman for fixin
HoustonPutman merged PR #3142:
URL: https://github.com/apache/solr/pull/3142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
HoustonPutman commented on PR #3142:
URL: https://github.com/apache/solr/pull/3142#issuecomment-2622059853
@dsmiley do you have any opinion on adding the snapshot directories to the
filter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dsmiley commented on PR #3142:
URL: https://github.com/apache/solr/pull/3142#issuecomment-2620779247
I raised the topic on the dev list but FYI I'm our resident Crave expert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
HoustonPutman commented on PR #3142:
URL: https://github.com/apache/solr/pull/3142#issuecomment-2620119361
> Thanks @HoustonPutman for looking at these, and sorry I didn't catch them,
as I think I reviewed both of those PR's. Is there some more unit testing that
we need that would have prev
HoustonPutman commented on code in PR #3142:
URL: https://github.com/apache/solr/pull/3142#discussion_r1932899214
##
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##
@@ -1037,8 +1036,7 @@ private int indexDirCount(String ddir) {
@Over
epugh commented on PR #3142:
URL: https://github.com/apache/solr/pull/3142#issuecomment-2620051699
Thanks @HoustonPutman for looking at these, and sorry I didn't catch them,
as I think I reviewed both of those PR's. Is there some more unit testing
that we need that would have prevented th
epugh commented on code in PR #3142:
URL: https://github.com/apache/solr/pull/3142#discussion_r1932855830
##
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##
@@ -1037,8 +1036,7 @@ private int indexDirCount(String ddir) {
@Override
epugh commented on PR #3142:
URL: https://github.com/apache/solr/pull/3142#issuecomment-2620046961
@mlbiscoc I should have reminded/and or run the nightly tests when I was
reviewing the path stuff.. Let's remember to do that as we continue!
--
This is an automated message from the Apache
HoustonPutman opened a new pull request, #3142:
URL: https://github.com/apache/solr/pull/3142
This actually stems from two commits on the same day, kind of eerie.
### [SOLR-17306](https://issues.apache.org/jira/browse/SOLR-17306)
This uncommented out:
```java
System.setPropert
10 matches
Mail list logo
