mkhludnev commented on PR #2672:
URL: https://github.com/apache/solr/pull/2672#issuecomment-2561400684
Doesn't it make sense to add a test confirming this functionality?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
patsonluk commented on PR #2672:
URL: https://github.com/apache/solr/pull/2672#issuecomment-2561326911
Sorry about the delay! I was on vacation and somehow I missed this thread!
To be honest I'm not totally sure why it returns null for non-select paths:
```
if (!path.endsWith
dsmiley commented on PR #2672:
URL: https://github.com/apache/solr/pull/2672#issuecomment-2551551068
I'm looking at #2527 and #2672 (this one) which seem the same at a glance;
why do we have two PRs?
It's really sad this didn't get merged before 9.8. Contributors sometime
really nee
github-actions[bot] commented on PR #2672:
URL: https://github.com/apache/solr/pull/2672#issuecomment-2481686802
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
mkhludnev commented on PR #2672:
URL: https://github.com/apache/solr/pull/2672#issuecomment-2357617808
I think it's fine to add CHANGES row and push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cpoerschke commented on PR #2672:
URL: https://github.com/apache/solr/pull/2672#issuecomment-2355677750
Thanks @ellaeln for iterating on this PR, the CI is now green, yay!
w.r.t. the remainder of the review(s) here -- unfortunately I'm not familiar
enough with the area of the code to
ellaeln commented on PR #2672:
URL: https://github.com/apache/solr/pull/2672#issuecomment-2353975200
> Hello. Next steps here could be to:
>
> 1. review and address the 'gradle precommit' failure above
> 2. review the suggestions (and apply them if they are agreeable)
I inves
cpoerschke commented on PR #2672:
URL: https://github.com/apache/solr/pull/2672#issuecomment-2337975951
Hello. Next steps here could be to:
1. review and address the 'gradle precommit' failure above
2. review the suggestions (and apply them if they are agreeable)
--
This is an au
cpoerschke commented on code in PR #2672:
URL: https://github.com/apache/solr/pull/2672#discussion_r1746719633
##
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java:
##
@@ -67,12 +73,33 @@ public CoordinatorHttpSolrCall(
this.factory = factory;
}
+
ellaeln commented on PR #2672:
URL: https://github.com/apache/solr/pull/2672#issuecomment-2312359080
opened a new MR for solr/17334 to expedite merging these changes @cpoerschke
please let me know if there's anything a can do to assist moving forward
--
This is an automated message fro
ellaeln opened a new pull request, #2672:
URL: https://github.com/apache/solr/pull/2672
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Pl
11 matches
Mail list logo
