cpoerschke commented on code in PR #2672:
URL: https://github.com/apache/solr/pull/2672#discussion_r1746719633
##########
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java:
##########
@@ -67,12 +73,33 @@ public CoordinatorHttpSolrCall(
this.factory = factory;
}
+ @SuppressWarnings("unchecked")
+ @Override
+ protected void writeResponse(
+ SolrQueryResponse solrRsp, QueryResponseWriter responseWriter, Method
reqMethod)
+ throws IOException {
+
+ // make coordinator mode explicit
+ if (solrRsp.getValues().get(CommonParams.DEBUG) != null) {
+ final NamedList<Object> debug =
+ (NamedList<Object>) solrRsp.getValues().get(CommonParams.DEBUG);
Review Comment:
Maybe have local variable to avoid double `get` calls e.g.
```suggestion
final Object debugObj = solrRsp.getValues().get(CommonParams.DEBUG);
if (debugObj != null) {
final NamedList<Object> debug =
(NamedList<Object>) debugObj;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
