Re: [PR] DefaultPackageRepository: simplify HTTP & JSON [solr]

2025-03-14 Thread via GitHub
dsmiley merged PR #3253: URL: https://github.com/apache/solr/pull/3253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] DefaultPackageRepository: simplify HTTP & JSON [solr]

2025-03-11 Thread via GitHub
epugh commented on PR #3253: URL: https://github.com/apache/solr/pull/3253#issuecomment-2713409914 There is a commented out .bats test in `test_packages.bats` that you could run. It requires a live internet connection which is why we don't run it in CI that tests out github.. > This t

Re: [PR] DefaultPackageRepository: simplify HTTP & JSON [solr]

2025-03-11 Thread via GitHub
dsmiley commented on PR #3253: URL: https://github.com/apache/solr/pull/3253#issuecomment-2714548138 Thanks for pointing out the commented out test. It passes now, after I updated it (the URL didn't seem to work exactly as it was). As you can hopefully agree/observe here, Jackson is

Re: [PR] DefaultPackageRepository: simplify HTTP & JSON [solr]

2025-03-11 Thread via GitHub
epugh commented on code in PR #3253: URL: https://github.com/apache/solr/pull/3253#discussion_r1989361358 ## solr/packaging/test/test_packages.bats: ## @@ -58,22 +58,24 @@ teardown() { } # This test is useful if you are debugging/working with packages. -# We have commented i

[PR] DefaultPackageRepository: simplify HTTP & JSON [solr]

2025-03-10 Thread via GitHub
dsmiley opened a new pull request, #3253: URL: https://github.com/apache/solr/pull/3253 The use of a SolrClient didn't seem to make sense if the web server isn't (necessarily) Solr. Seemed to be getting more in the way. There was some double or even triple(?) JSON back & forth parsing / s