dsmiley commented on PR #3253: URL: https://github.com/apache/solr/pull/3253#issuecomment-2714548138
Thanks for pointing out the commented out test. It passes now, after I updated it (the URL didn't seem to work exactly as it was). As you can hopefully agree/observe here, Jackson is enough to fetch parse Json from a URL; Solr doesn't need its own utility. The code that I encountered (replaced) created a new Http2SolrClient, and thus had no security/credential configuration. To use Solr's configured auth, it'd have to get the underlying HttpClient from elsewhere in Solr's infrastructure. But it wasn't and I'd rather just keep the simple thing of my PR until some day (if ever) someone wants to add auth. Again; I didn't take away auth here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
