HoustonPutman merged PR #2384:
URL: https://github.com/apache/solr/pull/2384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
HoustonPutman commented on code in PR #2384:
URL: https://github.com/apache/solr/pull/2384#discussion_r1546952877
##
solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java:
##
@@ -314,15 +314,19 @@ public void execute(final Runnable command) {
if (t ins
madrob commented on code in PR #2384:
URL: https://github.com/apache/solr/pull/2384#discussion_r1546934660
##
solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java:
##
@@ -314,15 +314,19 @@ public void execute(final Runnable command) {
if (t instanceof
madrob commented on PR #2384:
URL: https://github.com/apache/solr/pull/2384#issuecomment-2030706703
This took me a bit of experimenting with locally, but I understand what's
going on now and agree that the new ordering is correct. Thanks for cleaning
this up @HoustonPutman!
--
This is an
HoustonPutman commented on PR #2384:
URL: https://github.com/apache/solr/pull/2384#issuecomment-2030560252
An example of how this would fix exception logging:
Existing implementation:
```
2024-04-01 21:01:38.810 ERROR
(coreZkRegister-1-thread-1-processing-172.17.0.2:8983_sol
HoustonPutman opened a new pull request, #2384:
URL: https://github.com/apache/solr/pull/2384
This actually logs the correct stack trace for an exception caught in the
ExecutorUtil.
It also provides the correct ordering of "causes" unlike the way it was
previously implemented, where
