risdenk merged PR #1301:
URL: https://github.com/apache/solr/pull/1301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
janhoy commented on PR #1295:
URL: https://github.com/apache/solr/pull/1295#issuecomment-1398076527
Would be great to get a quick review by @thelabdude on the security panel
related changes.
@epugh Should we now use `var` and `const` everywhere instead of `let`?
--
This is an autom
janhoy merged PR #1294:
URL: https://github.com/apache/solr/pull/1294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
dsmiley commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1082129194
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -48,6 +50,7 @@
import org.xml.sax.InputSource;
/** Factory for ManagedIndexSchema */
stillalex commented on PR #1283:
URL: https://github.com/apache/solr/pull/1283#issuecomment-1397747458
@epugh could we merge this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
stillalex commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1397746600
@epugh please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
stillalex opened a new pull request, #1304:
URL: https://github.com/apache/solr/pull/1304
https://issues.apache.org/jira/browse/SOLR-16618
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
sonatype-lift[bot] commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081919641
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -48,6 +50,7 @@
import org.xml.sax.InputSource;
/** Factory for ManagedInd
magibney commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081919580
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -48,6 +50,7 @@
import org.xml.sax.InputSource;
/** Factory for ManagedIndexSchema *
magibney commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081919327
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -48,6 +50,7 @@
import org.xml.sax.InputSource;
/** Factory for ManagedIndexSchema *
magibney commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081903901
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -48,6 +50,7 @@
import org.xml.sax.InputSource;
/** Factory for ManagedIndexSchema *
janhoy merged PR #1296:
URL: https://github.com/apache/solr/pull/1296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy merged PR #1297:
URL: https://github.com/apache/solr/pull/1297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
sonatype-lift[bot] commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081887649
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -48,6 +50,7 @@
import org.xml.sax.InputSource;
/** Factory for ManagedInd
janhoy merged PR #1275:
URL: https://github.com/apache/solr/pull/1275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
dsmiley commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081712491
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -197,89 +196,99 @@ public ManagedIndexSchema create(
this.config = config;
thi
dsmiley commented on code in PR #1297:
URL: https://github.com/apache/solr/pull/1297#discussion_r1081711396
##
solr/webapp/web/js/angular/controllers/index.js:
##
@@ -20,6 +20,8 @@ solrAdminApp.controller('IndexController', function($scope,
System, Cores, Const
$scope.reload
magibney commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081700035
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -197,89 +196,99 @@ public ManagedIndexSchema create(
this.config = config;
th
dsmiley commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081694315
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -197,89 +196,99 @@ public ManagedIndexSchema create(
this.config = config;
thi
dsmiley commented on PR #1302:
URL: https://github.com/apache/solr/pull/1302#issuecomment-1397459619
CHANGES.txt -- I recommend adding an entry. It is a bug, albeit minor.
I recommend waiting until after 9.1.1 vote passes before merging or adding
CHANGES.txt. There is a chance we'll pul
sonatype-lift[bot] commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081669832
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -197,89 +196,99 @@ public ManagedIndexSchema create(
this.config = confi
magibney commented on PR #1302:
URL: https://github.com/apache/solr/pull/1302#issuecomment-1397430768
Ok, so targeting 9.2 release. Does this warrant a CHANGES.txt entry? I'm
thinking "no" ... nobody has actually reported this being a problem in the
wild, afaik?
--
This is an automated m
magibney commented on PR #1302:
URL: https://github.com/apache/solr/pull/1302#issuecomment-1397424590
> RE 9.1.1 eh... I wouldn't bother, personally. Let's see if a more serious
concern is brought up.
This makes sense to me. I suspect this has been a (mostly) latent issue for
a while
dsmiley commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081655354
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -198,88 +198,94 @@ public ManagedIndexSchema create(
this.loader = config.getResour
dsmiley commented on PR #1302:
URL: https://github.com/apache/solr/pull/1302#issuecomment-1397415044
RE 9.1.1 eh... I wouldn't bother, personally. Let's see if a more serious
concern is brought up.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
magibney commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081648457
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -198,88 +198,94 @@ public ManagedIndexSchema create(
this.loader = config.getResou
dsmiley commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081644200
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -198,88 +198,94 @@ public ManagedIndexSchema create(
this.loader = config.getResour
dsmiley commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081643380
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -198,88 +198,94 @@ public ManagedIndexSchema create(
this.loader = config.getResour
magibney commented on PR #1302:
URL: https://github.com/apache/solr/pull/1302#issuecomment-1397379968
I tried reproducing this by stressing my system, but haven't been able to,
FYI.
Separately, is the value/risk ratio of this change enough to warrant
inclusion in an RC3 for 9.1.1?
magibney commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081618038
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -198,88 +198,94 @@ public ManagedIndexSchema create(
this.loader = config.getResou
dsmiley commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081572121
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -198,88 +198,94 @@ public ManagedIndexSchema create(
this.loader = config.getResour
sonatype-lift[bot] commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081568912
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -393,14 +393,22 @@ private SolrConfig(
}
private IndexSchemaFactory.VersionedConfig re
magibney commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081568819
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -393,14 +393,22 @@ private SolrConfig(
}
private IndexSchemaFactory.VersionedConfig readXml(Solr
dsmiley commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081543949
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -393,14 +393,22 @@ private SolrConfig(
}
private IndexSchemaFactory.VersionedConfig readXml(SolrR
magibney commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081515055
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -198,88 +198,94 @@ public ManagedIndexSchema create(
this.loader = config.getResou
sonatype-lift[bot] commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081460073
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -198,88 +198,94 @@ public ManagedIndexSchema create(
this.loader = confi
magibney commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081414524
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -393,14 +393,22 @@ private SolrConfig(
}
private IndexSchemaFactory.VersionedConfig readXml(Solr
magibney commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081395936
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -393,14 +393,22 @@ private SolrConfig(
}
private IndexSchemaFactory.VersionedConfig readXml(Solr
magibney commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081362734
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -393,14 +393,22 @@ private SolrConfig(
}
private IndexSchemaFactory.VersionedConfig readXml(Solr
risdenk commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1081328045
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -393,14 +393,22 @@ private SolrConfig(
}
private IndexSchemaFactory.VersionedConfig readXml(SolrR
risdenk merged PR #1292:
URL: https://github.com/apache/solr/pull/1292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk merged PR #1299:
URL: https://github.com/apache/solr/pull/1299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
a-nych commented on PR #516:
URL: https://github.com/apache/solr-operator/pull/516#issuecomment-1396981936
@HoustonPutman Thanks for the feedback! I've added the changelog.
Do we want to wait for #507 before merging this?
--
This is an automated message from the Apache Git Service.
dsmiley commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1080763089
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -393,14 +393,22 @@ private SolrConfig(
}
private IndexSchemaFactory.VersionedConfig readXml(SolrR
dsmiley commented on PR #1302:
URL: https://github.com/apache/solr/pull/1302#issuecomment-1396382429
I found a reproducible line on branch_9_1 using JDK 11 on my aging laptop.
> gradlew -p solr/core test -Ptests.iters=10 --tests TestCoreContainer
Applying the changes here made this
magibney commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1080690072
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -393,14 +393,22 @@ private SolrConfig(
}
private IndexSchemaFactory.VersionedConfig readXml(Solr
uvatbc opened a new pull request, #1303:
URL: https://github.com/apache/solr/pull/1303
https://issues.apache.org/jira/browse/SOLR-X
# Description
The Solr project needs machines that are much more powerful (eg. 100+ cores)
to run all the tests.
Crave.io
sonatype-lift[bot] commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1080647796
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -393,14 +393,22 @@ private SolrConfig(
}
private IndexSchemaFactory.VersionedConfig re
dsmiley commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1080640747
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -393,14 +393,22 @@ private SolrConfig(
}
private IndexSchemaFactory.VersionedConfig readXml(SolrR
dsmiley commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1080639405
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -393,14 +393,22 @@ private SolrConfig(
}
private IndexSchemaFactory.VersionedConfig readXml(SolrR
magibney opened a new pull request, #1302:
URL: https://github.com/apache/solr/pull/1302
See: SOLR-16628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
risdenk merged PR #1300:
URL: https://github.com/apache/solr/pull/1300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk commented on code in PR #1301:
URL: https://github.com/apache/solr/pull/1301#discussion_r1073986526
##
solr/modules/gcs-repository/src/test/org/apache/solr/gcs/ConcurrentDelegatingStorage.java:
##
@@ -56,6 +56,7 @@
* synchronization across all instance methods. This al
risdenk merged PR #1298:
URL: https://github.com/apache/solr/pull/1298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on PR #1300:
URL: https://github.com/apache/solr/pull/1300#issuecomment-1387606108
+1 (assume tests pass)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
risdenk merged PR #1265:
URL: https://github.com/apache/solr/pull/1265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1387471564
@tboeghk @DennisBerger1984 @mpetris what is the status here? Did you end up
finding the Query impl that is changing hashcode/equals? Is this PR necessary
still?
--
This is an automated me
stillalex commented on PR #1243:
URL: https://github.com/apache/solr/pull/1243#issuecomment-1387386288
for what it's worth, I spent some time reviewing the latest version of the
patch and it looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the m
risdenk opened a new pull request, #1301:
URL: https://github.com/apache/solr/pull/1301
https://issues.apache.org/jira/browse/SOLR-16627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
risdenk opened a new pull request, #1300:
URL: https://github.com/apache/solr/pull/1300
https://issues.apache.org/jira/browse/SOLR-16626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
risdenk commented on code in PR #1299:
URL: https://github.com/apache/solr/pull/1299#discussion_r1073604042
##
gradle/validation/owasp-dependency-check.gradle:
##
@@ -26,9 +26,12 @@ configure(rootProject) {
dependencyCheck {
failBuildOnCVSS = propertyOrDefault("validatio
risdenk opened a new pull request, #1299:
URL: https://github.com/apache/solr/pull/1299
https://issues.apache.org/jira/browse/SOLR-16625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
risdenk opened a new pull request, #1298:
URL: https://github.com/apache/solr/pull/1298
https://issues.apache.org/jira/browse/SOLR-16624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
noblepaul merged PR #1293:
URL: https://github.com/apache/solr/pull/1293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1073134160
##
solr/test-framework/src/java/org/apache/solr/util/EmbeddedSolrServerTestRule.java:
##
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
dsmiley commented on PR #1243:
URL: https://github.com/apache/solr/pull/1243#issuecomment-1386457707
I plan to commit in a couple days if I don't hear to the contrary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
dsmiley commented on PR #1243:
URL: https://github.com/apache/solr/pull/1243#issuecomment-1386457113
I marked the pertinent classes deprecated, added a note about this in the
upgrade notes, and added this CHANGES.txt entry:
> SOLR-16591: The "Transient Cores" feature is now deprecated. I
gerlowskija commented on PR #1286:
URL: https://github.com/apache/solr/pull/1286#issuecomment-1386285201
Hey @risdenk : I was hoping to gear up to merge, but see you still
technically have an outstanding "change requested" on this PR. 99% sure this
was the 'Suggested Change' to fix precomm
noblepaul commented on PR #1210:
URL: https://github.com/apache/solr/pull/1210#issuecomment-1385915397
@gerlowskija
we should keep this `disabled` by default so that performance testing is not
blocked
--
This is an automated message from the Apache Git Service.
To respond to the
magibney merged PR #1291:
URL: https://github.com/apache/solr/pull/1291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o
magibney merged PR #1290:
URL: https://github.com/apache/solr/pull/1290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o
magibney commented on PR #1291:
URL: https://github.com/apache/solr/pull/1291#issuecomment-1385592060
Thanks, Kevin and Jan! I did a dry-run of this (and also #1290), and both
worked as intended. I'll merge and incorporate testing this out "in real life"
while building 9.1.1 RC2.
(It
janhoy opened a new pull request, #1297:
URL: https://github.com/apache/solr/pull/1297
https://issues.apache.org/jira/browse/SOLR-14336
This impl will simply parse release date from solr-impl string, count number
of days old, and warn in Admin UI dashboard if older than a year. No war
janhoy opened a new pull request, #1296:
URL: https://github.com/apache/solr/pull/1296
https://issues.apache.org/jira/browse/SOLR-15772
I know I should have chosen some other class to get `text-align: left` and
not put the style on the div tag, but I was too lazy to investigate what c
janhoy commented on PR #1295:
URL: https://github.com/apache/solr/pull/1295#issuecomment-1385290310
I also found that `security.js` redefined the global `$scope.permissions`
also defined in `app.js` which holds a static map of all permission names. I
renamed the variable to `$scope.permissi
janhoy opened a new pull request, #1295:
URL: https://github.com/apache/solr/pull/1295
Re-using this global function, we can simplify the js code of the dashboard.
Note that the backend `/admin/info/system` already returns an array of user's
permissions, not roles.
During testing I f
janhoy commented on PR #1294:
URL: https://github.com/apache/solr/pull/1294#issuecomment-1385173003
@thelabdude I see some duplicate logic in the permission check for Security
Dash. I believe you could have used the function `isPermitted()` already
defined in `app.js`, see
https://github.c
janhoy opened a new pull request, #1294:
URL: https://github.com/apache/solr/pull/1294
https://issues.apache.org/jira/browse/SOLR-16621
Always grant access to a permission that has has the wildcard `"*"` role, no
matter what roles user has.
Note, this is not the same as not requiri
noblepaul merged PR #89:
URL: https://github.com/apache/solr-site/pull/89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1071731157
##
solr/core/src/test/org/apache/solr/update/RootFieldTest.java:
##
@@ -46,7 +49,15 @@ public static void beforeTest() throws Exception {
useRootSchema = random().nex
noblepaul commented on PR #1210:
URL: https://github.com/apache/solr/pull/1210#issuecomment-1384816806
>most of the reasons a user might've wanted this back then are still valid
today:
@gerlowskija
Well, this was added not because V2 itself was not finished. I was worried
that V2
justinrsweeney commented on PR #89:
URL: https://github.com/apache/solr-site/pull/89#issuecomment-1384670714
@janhoy Tagging you here for the applicable changes to solr-site once the
changes for documentation on how to contribute have been merged in the Solr
repo.
--
This is an automated
janhoy merged PR #1177:
URL: https://github.com/apache/solr/pull/1177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
justinrsweeney commented on PR #1177:
URL: https://github.com/apache/solr/pull/1177#issuecomment-1384415908
Done, thanks for the review and feedback 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
radu-gheorghe opened a new pull request, #1292:
URL: https://github.com/apache/solr/pull/1292
Minor change: according to the code (and I remember testing it, too), the
default is 20GB, not 10:
https://github.com/apache/solr/blob/c99af207c761ec34812ef1cc3054eb2804b7448b/solr/core/src/java/or
magibney opened a new pull request, #1291:
URL: https://github.com/apache/solr/pull/1291
apache/solr#1125 works around gpg pinentry via a `setup_gpg` step that
caches the user pin in `gpg-agent`.
For configurations that require explicit user PIN entry via non-tty-based
pinentry progr
magibney closed pull request #1289: releaseWizard: allow explicitly setting
MANIFEST.MF userid (e.g., to apache id)
URL: https://github.com/apache/solr/pull/1289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
magibney commented on PR #1289:
URL: https://github.com/apache/solr/pull/1289#issuecomment-1382964228
Closing as superseded by #1290 -- sorry for the spam
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
magibney opened a new pull request, #1290:
URL: https://github.com/apache/solr/pull/1290
Analogous to: #1289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
magibney opened a new pull request, #1289:
URL: https://github.com/apache/solr/pull/1289
I'm opening this PR against `branch_9_1` just to have it live somewhere
while resolving conflicts in forward-porting to `branch_9x` and `main`, which
look very different because #1125 appears to have be
HoustonPutman commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1070031379
##
solr/core/src/test/org/apache/solr/jersey/JerseyApplicationSharingTest.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
gerlowskija commented on PR #1286:
URL: https://github.com/apache/solr/pull/1286#issuecomment-1382353479
Alright, added the test you asked for @HoustonPutman and merged your
precommit fix @risdenk . Thanks for the review everyone!
I'm going to post some perf data and instructions for
magibney merged PR #1288:
URL: https://github.com/apache/solr/pull/1288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o
epugh merged PR #499:
URL: https://github.com/apache/solr/pull/499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
F
epugh commented on PR #499:
URL: https://github.com/apache/solr/pull/499#issuecomment-1382112785
This is a nice edit, the JIRA was closed a while ago, then @mkhludnev added
this on top of it. I went ahead and merged it!
--
This is an automated message from the Apache Git Service.
To resp
gerlowskija commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1069611652
##
solr/core/src/java/org/apache/solr/jersey/RequestMetricHandling.java:
##
@@ -40,9 +39,18 @@
/**
* A request and response filter used to initialize and report per
magibney opened a new pull request, #1288:
URL: https://github.com/apache/solr/pull/1288
The release wizard detection of gpg keys fails in the event that the main
key is offline (which causes the script output for `gpg --list-secret-keys` to
display slightly differently). This PR introduces
gerlowskija merged PR #1210:
URL: https://github.com/apache/solr/pull/1210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
janhoy commented on PR #1275:
URL: https://github.com/apache/solr/pull/1275#issuecomment-1381934345
Anything more we should fix in this same PR? I kind of gave up on slimming
down the jars for now, but feel free to give it a shot if you like.
--
This is an automated message from the Apach
janhoy commented on code in PR #1287:
URL: https://github.com/apache/solr/pull/1287#discussion_r1069521742
##
solr/bin/solr:
##
@@ -716,7 +716,11 @@ function solr_pid_by_port() {
# extract the value of the -Djetty.port parameter from a running Solr process
function jetty_port(
1 - 100 of 5228 matches
Mail list logo
