Re: [PR] Documentation error [solr]

2025-06-20 Thread via GitHub
sayandigital closed pull request #3401: Documentation error URL: https://github.com/apache/solr/pull/3401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[jira] [Commented] (SOLR-17619) Generate CHANGELOG.md (formerly CHANGES.txt) via logchange

2025-06-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985055#comment-17985055 ] David Smiley commented on SOLR-17619: - bq. Or we could start encouraging committers t

Re: [PR] SOLR-17619 add logchange plugin [solr]

2025-06-20 Thread via GitHub
dsmiley commented on code in PR #3044: URL: https://github.com/apache/solr/pull/3044#discussion_r2159807412 ## dev-docs/changelog.adoc: ## @@ -0,0 +1,116 @@ += Adding a Changelog Entry to Apache Solr +:toc: +:toclevels: 2 +:icons: font + +Since Solr 10.0 we no longer edit the mo

Re: [PR] SOLR-17619 add logchange plugin [solr]

2025-06-20 Thread via GitHub
janhoy commented on code in PR #3044: URL: https://github.com/apache/solr/pull/3044#discussion_r2159794228 ## gradle/changelog.gradle: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTI

Re: [PR] SOLR-17619 add logchange plugin [solr]

2025-06-20 Thread via GitHub
janhoy commented on code in PR #3044: URL: https://github.com/apache/solr/pull/3044#discussion_r2159793415 ## gradle/changelog.gradle: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTI

Re: [PR] SOLR-17619 add logchange plugin [solr]

2025-06-20 Thread via GitHub
janhoy commented on code in PR #3044: URL: https://github.com/apache/solr/pull/3044#discussion_r2159793242 ## gradle/changelog.gradle: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTI

[jira] [Commented] (SOLR-17158) Terminate distributed processing quickly when query limit is reached

2025-06-20 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985044#comment-17985044 ] Houston Putman commented on SOLR-17158: --- Also, as [~dsmiley] mentioned, there is si

Re: [PR] SOLR-17776: Fix overchecking of http1 flag in Http2SolrClient [solr]

2025-06-20 Thread via GitHub
dsmiley commented on code in PR #3400: URL: https://github.com/apache/solr/pull/3400#discussion_r2159697182 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -132,8 +132,9 @@ protected Http2SolrClient(String serverBaseUrl, Builder builder) {

Re: [PR] SOLR-17776: Fix overchecking of http1 flag in Http2SolrClient [solr]

2025-06-20 Thread via GitHub
dsmiley commented on code in PR #3400: URL: https://github.com/apache/solr/pull/3400#discussion_r2159689428 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java: ## @@ -38,7 +38,8 @@ public abstract class HttpSolrClientBuilderBase< protected

[PR] SOLR-17776: Fix overchecking of http1 flag in Http2SolrClient [solr]

2025-06-20 Thread via GitHub
HoustonPutman opened a new pull request, #3400: URL: https://github.com/apache/solr/pull/3400 https://issues.apache.org/jira/browse/SOLR-17776 The http1 check should work like the rest of the custom option checks, and only fail if the user has explicitly set it to something (other tha

Re: [PR] SOLR-17776: Harmonize SolrJ timeouts [solr]

2025-06-20 Thread via GitHub
dsmiley commented on code in PR #3357: URL: https://github.com/apache/solr/pull/3357#discussion_r2159651401 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -129,6 +128,20 @@ protected Http2SolrClient(String serverBaseUrl, Builder builder) {

Re: [PR] SOLR-17789: Fix Internode Authorization not working for external roles [solr]

2025-06-20 Thread via GitHub
dsmiley commented on code in PR #3397: URL: https://github.com/apache/solr/pull/3397#discussion_r2159645849 ## solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java: ## @@ -290,6 +291,53 @@ public void testMetrics() throws Exception {

[PR] SOLR-16391: Fix CoresAPI integration in V2HttpCall [solr]

2025-06-20 Thread via GitHub
HoustonPutman opened a new pull request, #3399: URL: https://github.com/apache/solr/pull/3399 https://issues.apache.org/jira/browse/SOLR-16391 We might be able to move this else if statement entirely, if all cores APIs are handled by JaxRS, but I may be wrong about that. It's just a g

[PR] SOLR-17792: Fix deadlocks in ParallelHttpShardHandler [solr]

2025-06-20 Thread via GitHub
HoustonPutman opened a new pull request, #3398: URL: https://github.com/apache/solr/pull/3398 https://issues.apache.org/jira/browse/SOLR-17792 This is a WIP but we really should be able to get rid of the synchronization and make this logic so much simpler. Here I'm making `resp

[jira] [Updated] (SOLR-17792) ParallelHttpShardHandler has massive performance issues.

2025-06-20 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-17792: -- Summary: ParallelHttpShardHandler has massive performance issues. (was: ParallelShardHandler h

Re: [PR] SOLR-17776: Harmonize SolrJ timeouts [solr]

2025-06-20 Thread via GitHub
HoustonPutman commented on code in PR #3357: URL: https://github.com/apache/solr/pull/3357#discussion_r2159603675 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -129,6 +128,20 @@ protected Http2SolrClient(String serverBaseUrl, Builder build

[PR] Add abillity to set enableServiceLinks on PodSpec [solr-operator]

2025-06-20 Thread via GitHub
jd252387 opened a new pull request, #790: URL: https://github.com/apache/solr-operator/pull/790 Set to true as default, per the PodSpec. Added to tests, changelog and README. See the first note under https://kubernetes.io/docs/tutorials/services/connect-applications-service/#a

[PR] Jira/solr 17789 [solr]

2025-06-20 Thread via GitHub
bct-timo-crabbe opened a new pull request, #3397: URL: https://github.com/apache/solr/pull/3397 https://issues.apache.org/jira/browse/SOLR-17789 # Description Solr nodes do not pass full authorization details to other nodes. Steps to reproduce: 1. Deploy cluster with m

[jira] [Commented] (SOLR-17158) Terminate distributed processing quickly when query limit is reached

2025-06-20 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985000#comment-17985000 ] Houston Putman commented on SOLR-17158: --- Hey all, I think we need to rethink the sy

[jira] [Created] (SOLR-17793) Create dedicated SdkMeterProviders for Solr core metrics

2025-06-20 Thread Matthew Biscocho (Jira)
Matthew Biscocho created SOLR-17793: --- Summary: Create dedicated SdkMeterProviders for Solr core metrics Key: SOLR-17793 URL: https://issues.apache.org/jira/browse/SOLR-17793 Project: Solr I

[jira] [Updated] (SOLR-17791) Features always end up in default-store(_DEFAULT_)

2025-06-20 Thread Renato Haeberli (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Renato Haeberli updated SOLR-17791: --- Summary: Features always end up in default-store(_DEFAULT_) (was: Features always end up in

Re: [PR] SOLR-17785: Integrate foundational OTEL meter instruments [solr]

2025-06-20 Thread via GitHub
mlbiscoc commented on PR #3384: URL: https://github.com/apache/solr/pull/3384#issuecomment-2992448965 So I didn't move attributes into SolrMetricsContext. Ended up being a bigger refactor because currently keeping Dropwizard in parallel temporarily to incrementally migrate. Maybe will do i

[jira] [Comment Edited] (SOLR-17158) Terminate distributed processing quickly when query limit is reached

2025-06-20 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985000#comment-17985000 ] Houston Putman edited comment on SOLR-17158 at 6/20/25 5:35 PM: ---

[jira] [Updated] (SOLR-17792) ParallelShardHandler has massive performance issues.

2025-06-20 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-17792: -- Fix Version/s: 9.9 > ParallelShardHandler has massive performance issues. > ---

[jira] [Created] (SOLR-17792) ParallelShardHandler has massive performance issues.

2025-06-20 Thread Houston Putman (Jira)
Houston Putman created SOLR-17792: - Summary: ParallelShardHandler has massive performance issues. Key: SOLR-17792 URL: https://issues.apache.org/jira/browse/SOLR-17792 Project: Solr Issue Typ

Re: [PR] SOLR-17711 index fetcher doesn't need request timeout [solr]

2025-06-20 Thread via GitHub
dsmiley commented on code in PR #3356: URL: https://github.com/apache/solr/pull/3356#discussion_r2158991725 ## solr/CHANGES.txt: ## @@ -49,6 +49,8 @@ Improvements * SOLR-17739: Uploading a config sets with forbidden file types will produces a Exception. Previously it was jus

[jira] [Created] (SOLR-17791) Features always end up in default-store(_DEFAULT)

2025-06-20 Thread Renato Haeberli (Jira)
Renato Haeberli created SOLR-17791: -- Summary: Features always end up in default-store(_DEFAULT) Key: SOLR-17791 URL: https://issues.apache.org/jira/browse/SOLR-17791 Project: Solr Issue Type