mlbiscoc commented on PR #3384: URL: https://github.com/apache/solr/pull/3384#issuecomment-2992448965
So I didn't move attributes into SolrMetricsContext. Ended up being a bigger refactor because currently keeping Dropwizard in parallel temporarily to incrementally migrate. Maybe will do it closer to the end of this migration depending what happens to SolrMetricsContext. I have another PR pretty close to ready and would like to put that up for review. It adds in dynamic solr core creation and deletion with dedicated SdkMeterProvider as well as adds a bunch of tests around these foundational components. There are some larger changes in-order to make this work that you'd be probably be interested in. I also have a WIP for some basic filtering but there are some "gotchas" that we need to discuss but will put it aside for a separate discussion. If you have nothing else here, I'd like to merge this and put up the new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
