Re: [PR] SOLR-17635: unmarshalling Map to SimpleOrderedMap if key i of type St… [solr]

2025-02-07 Thread via GitHub
dsmiley commented on code in PR #3163: URL: https://github.com/apache/solr/pull/3163#discussion_r1947486318 ## solr/solrj/src/test/org/apache/solr/common/util/TestJavaBinCodec.java: ## @@ -293,7 +306,7 @@ public void testForwardCompat() throws IOException { for (int i =

Re: [PR] SolrTestCaseJ4: don't reset HttpClient SSL stuff [solr]

2025-02-07 Thread via GitHub
dsmiley merged PR #3037: URL: https://github.com/apache/solr/pull/3037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17648) multiThreaded: Remove obsolete RejectedExecutionException avoidance

2025-02-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925155#comment-17925155 ] ASF subversion and git services commented on SOLR-17648: Commit 8

Re: [PR] SOLR-17648: multiThreaded=true: changed queue implementation [solr]

2025-02-07 Thread via GitHub
dsmiley merged PR #3155: URL: https://github.com/apache/solr/pull/3155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-15611: Fix ignored phrase slop after nested query parsing [solr]

2025-02-07 Thread via GitHub
github-actions[bot] commented on PR #280: URL: https://github.com/apache/solr/pull/280#issuecomment-2644347982 This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. -- This i

Re: [PR] SOLR-15611: Fix ignored phrase slop after nested query parsing [solr]

2025-02-07 Thread via GitHub
github-actions[bot] closed pull request #280: SOLR-15611: Fix ignored phrase slop after nested query parsing URL: https://github.com/apache/solr/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Refactor UpdateLog.LogPtr to a record [solr]

2025-02-07 Thread via GitHub
dsmiley commented on PR #3166: URL: https://github.com/apache/solr/pull/3166#issuecomment-2644209292 Ugh; ECJ doesn't know about Java records. Probably need to update that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Refactor UpdateLog.LogPtr to a record [solr]

2025-02-07 Thread via GitHub
dsmiley commented on code in PR #3166: URL: https://github.com/apache/solr/pull/3166#discussion_r1947245716 ## solr/core/src/java/org/apache/solr/update/UpdateLog.java: ## @@ -268,40 +268,13 @@ public String toString() { protected Meter copyOverOldUpdatesMeter; protected S

[PR] Refactor UpdateLog.LogPtr to a record [solr]

2025-02-07 Thread via GitHub
dsmiley opened a new pull request, #3166: URL: https://github.com/apache/solr/pull/3166 And remove previousPointer (unused) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] SOLR-17635: unmarshalling Map to SimpleOrderedMap if key i of type St… [solr]

2025-02-07 Thread via GitHub
renatoh commented on code in PR #3163: URL: https://github.com/apache/solr/pull/3163#discussion_r1947220379 ## solr/solrj/src/test/org/apache/solr/common/util/TestJavaBinCodec.java: ## @@ -293,7 +306,7 @@ public void testForwardCompat() throws IOException { for (int i =

Re: [PR] SOLR-17635: unmarshalling Map to SimpleOrderedMap if key i of type St… [solr]

2025-02-07 Thread via GitHub
renatoh commented on code in PR #3163: URL: https://github.com/apache/solr/pull/3163#discussion_r1947220379 ## solr/solrj/src/test/org/apache/solr/common/util/TestJavaBinCodec.java: ## @@ -293,7 +306,7 @@ public void testForwardCompat() throws IOException { for (int i =

[PR] chore(deps): update opentelemetry to v1.47.0 [solr]

2025-02-07 Thread via GitHub
solrbot opened a new pull request, #3165: URL: https://github.com/apache/solr/pull/3165 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.opentelemetry:opentelemetry-sdk-trace](https://redirect.github.com/open-telemetry/opentele

Re: [PR] EncryptionRequestHandler supports encryption requests distribution. [solr-sandbox]

2025-02-07 Thread via GitHub
dsmiley commented on code in PR #115: URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1946869972 ## encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java: ## @@ -527,31 +512,33 @@ private void commitEncryptionStart(String keyId,

Re: [PR] SOLR-17628: Add query quantiles metrics to prometheus endpoint [solr]

2025-02-07 Thread via GitHub
mlbiscoc commented on code in PR #3164: URL: https://github.com/apache/solr/pull/3164#discussion_r1946662321 ## solr/core/src/java/org/apache/solr/metrics/prometheus/core/SolrCoreHandlerMetric.java: ## @@ -28,7 +28,7 @@ public class SolrCoreHandlerMetric extends SolrCoreMetric {

Re: [PR] EncryptionRequestHandler supports encryption requests distribution. [solr-sandbox]

2025-02-07 Thread via GitHub
bruno-roustant commented on PR #115: URL: https://github.com/apache/solr-sandbox/pull/115#issuecomment-2643063189 Thank you for your thorough review David. I have updated to integrate your remarks. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] SOLR-17635: unmarshalling Map to SimpleOrderedMap if key i of type St… [solr]

2025-02-07 Thread via GitHub
dsmiley commented on code in PR #3163: URL: https://github.com/apache/solr/pull/3163#discussion_r1946576896 ## solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java: ## @@ -863,6 +868,26 @@ protected Map readMap(DataInputInputStream dis, int sz) throws I return