renatoh commented on code in PR #3163:
URL: https://github.com/apache/solr/pull/3163#discussion_r1947220379
##########
solr/solrj/src/test/org/apache/solr/common/util/TestJavaBinCodec.java:
##########
@@ -293,7 +306,7 @@ public void testForwardCompat() throws IOException {
for (int i = 1;
i < currentFormatBytes.length;
i++) { // ignore the first byte. It is version information
- assertEquals(newFormatBytes[i], currentFormatBytes[i]);
+ assertEquals("for i:" + i, newFormatBytes[i], currentFormatBytes[i]);
Review Comment:
After rewriting the .bin file with the changed output from
org.apache.solr.common.util.TestJavaBinCodec#generateAllDataTypes tests like
org.apache.solr.common.util.TestJavaBinCodec#testBackCompat are passing now.
But this one testForwardCompat which compares all the bytes fails since the
bytes are not the same anymore.
Is it possible I did something wrong when recreated the bin-file?
Is just took the output from generateAllDataTypes(), called
javabin.marshall(matchObj, output) with it and wrote the result via a
FileOutputStream to a file.
So the object in the unmarshalle version are the same, but the bytes are not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
