[jira] [Commented] (SOLR-17635) javabin should deserialize maps as SimpleOrderedMap

2025-02-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923909#comment-17923909 ] David Smiley commented on SOLR-17635: - Yes Renato. The change should ultimately be v

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-02-04 Thread via GitHub
dsmiley commented on code in PR #3151: URL: https://github.com/apache/solr/pull/3151#discussion_r1942178207 ## solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessorFactory.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache

[jira] [Commented] (SOLR-17582) CLUSTERSTATUS API could stream the response to save memory

2025-02-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923898#comment-17923898 ] ASF subversion and git services commented on SOLR-17582: Commit d

Re: [PR] SOLR-17582: Stream CLUSTERSTATUS API for SolrJ version >= 9.9 [solr]

2025-02-04 Thread via GitHub
dsmiley merged PR #3156: URL: https://github.com/apache/solr/pull/3156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17582) CLUSTERSTATUS API could stream the response to save memory

2025-02-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923893#comment-17923893 ] ASF subversion and git services commented on SOLR-17582: Commit 5

Re: [I] Problems with istio and prometheus [solr-operator]

2025-02-04 Thread via GitHub
sukolenvo commented on issue #427: URL: https://github.com/apache/solr-operator/issues/427#issuecomment-2635513779 BTW here is zookeeper operator headless service: all ports are prefixed with `tcp-` - one more option to consider ```yaml ports: - name: tcp-client p

Re: [PR] SOLR-17582: Stream CLUSTERSTATUS API for SolrJ version >= 9.9 [solr]

2025-02-04 Thread via GitHub
dsmiley commented on code in PR #3156: URL: https://github.com/apache/solr/pull/3156#discussion_r1941999333 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/ClusterStateProviderTest.java: ## Review Comment: They have value; they should stay. If we finally get the

[jira] [Created] (SOLR-17653) New DockerSolrServerTestRule that uses TestContainers/Docker

2025-02-04 Thread David Smiley (Jira)
David Smiley created SOLR-17653: --- Summary: New DockerSolrServerTestRule that uses TestContainers/Docker Key: SOLR-17653 URL: https://issues.apache.org/jira/browse/SOLR-17653 Project: Solr Issu

[jira] [Resolved] (SOLR-14903) SolrCloud tests should use the jetty.xml that we ship with

2025-02-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14903. - Resolution: Not A Problem I'm closing this because we already have such real jetty.xml testing vi

[jira] [Commented] (SOLR-17635) javabin should deserialize maps as SimpleOrderedMap

2025-02-04 Thread Renato Haeberli (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923837#comment-17923837 ] Renato Haeberli commented on SOLR-17635: [~dsmiley] Here you are referring to the

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-02-04 Thread via GitHub
dsmiley commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2635055839 "caller" by the first definition you listed -- basically the client of Solr. I'll say "client". Not sure if we have disagreement or not. -- This is an automated message from the Ap

[jira] [Updated] (SOLR-17652) PULL replicas can be stuck permemantly in DOWN state if leader election takes too long

2025-02-04 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-17652: -- Attachment: SOLR-17652.patch Status: Open (was: Open) Every now and then over

[jira] [Commented] (SOLR-17652) PULL replicas can be stuck permemantly in DOWN state if leader election takes too long

2025-02-04 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923822#comment-17923822 ] Chris M. Hostetter commented on SOLR-17652: --- FYI, here's a way to demonstrate t

Re: [PR] SOLR-17351: Decompose filestore "get file" API [solr]

2025-02-04 Thread via GitHub
gerlowskija commented on code in PR #3047: URL: https://github.com/apache/solr/pull/3047#discussion_r1941803992 ## solr/core/src/java/org/apache/solr/filestore/NodeFileStore.java: ## @@ -76,135 +66,54 @@ public SolrJerseyResponse getFile(String path, Boolean sync, String getFro

[jira] [Created] (SOLR-17651) Obfuscate System.exit(), remove direct usage

2025-02-04 Thread Houston Putman (Jira)
Houston Putman created SOLR-17651: - Summary: Obfuscate System.exit(), remove direct usage Key: SOLR-17651 URL: https://issues.apache.org/jira/browse/SOLR-17651 Project: Solr Issue Type: Impro

[jira] [Updated] (SOLR-17651) Obfuscate System.exit(), remove direct usage

2025-02-04 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-17651: -- Status: Patch Available (was: Open) > Obfuscate System.exit(), remove direct usage > -

[jira] [Updated] (SOLR-17651) Obfuscate System.exit(), remove direct usage

2025-02-04 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-17651: -- Status: Open (was: Patch Available) > Obfuscate System.exit(), remove direct usage > -

[jira] [Commented] (SOLR-17379) ParsingFieldUpdateProcessorsTest failures using CLDR locale provider

2025-02-04 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923813#comment-17923813 ] Houston Putman commented on SOLR-17379: --- We have System.exit() used in Solr, mainly

Re: [PR] SOLR-17379: Fix date parsing in Java 23, remove Lucene TestSecurityManager [solr]

2025-02-04 Thread via GitHub
HoustonPutman merged PR #3154: URL: https://github.com/apache/solr/pull/3154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[jira] [Commented] (SOLR-17379) ParsingFieldUpdateProcessorsTest failures using CLDR locale provider

2025-02-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923812#comment-17923812 ] ASF subversion and git services commented on SOLR-17379: Commit b

Re: [PR] SOLR-17379: Fix date parsing in Java 23, remove Lucene TestSecurityManager [solr]

2025-02-04 Thread via GitHub
HoustonPutman commented on PR #3154: URL: https://github.com/apache/solr/pull/3154#issuecomment-2634894329 > LGTM. Bit confused why BasicAuthIntegrationTest ever passed, but I'm sure you fix did it! It worked because it just logged an error, it didn't fail the test. Pretty weird, but

Re: [PR] SOLR-17379: Fix date parsing in Java 23, remove Lucene TestSecurityManager [solr]

2025-02-04 Thread via GitHub
HoustonPutman commented on code in PR #3154: URL: https://github.com/apache/solr/pull/3154#discussion_r1941784747 ## solr/core/src/test/org/apache/solr/security/BasicAuthIntegrationTest.java: ## @@ -295,12 +295,12 @@ public void testBasicAuth() throws Exception { verifySe

Re: [PR] SOLR-17631: Upgrade main to Lucene 10.x [solr]

2025-02-04 Thread via GitHub
cpoerschke commented on code in PR #3053: URL: https://github.com/apache/solr/pull/3053#discussion_r1941767347 ## solr/core/src/java/org/apache/solr/search/Grouping.java: ## @@ -603,7 +566,7 @@ protected Integer getNumberOfGroups() { protected void populateScoresIfNecessary

Re: [PR] SOLR-17649: Fix Json faceting on multivalue number types [solr]

2025-02-04 Thread via GitHub
thomaswoeckinger commented on PR #3158: URL: https://github.com/apache/solr/pull/3158#issuecomment-2634739177 @risdenk as your are one of the last commiters in this area, you may have a look at this PR -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (SOLR-17649) Multivalue facets on enum field type returns empty result when using JsonFacet

2025-02-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923794#comment-17923794 ] Thomas Wöckinger commented on SOLR-17649: - [~krisden] as you are one of the last

[jira] [Updated] (SOLR-17649) Multivalue facets on enum field type returns empty result when using JsonFacet

2025-02-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17649: -- Labels: pull-request-available (was: ) > Multivalue facets on enum field type returns empty re

[PR] SOLR-17649: Fix Json faceting on multivalue number types [solr]

2025-02-04 Thread via GitHub
thomaswoeckinger opened a new pull request, #3158: URL: https://github.com/apache/solr/pull/3158 https://issues.apache.org/jira/browse/SOLR-17649 # Description FacetFieldProcessorByArrayDV can not handle fields with DocValues of type DocValuesType.SORTED_NUMERIC. If such a t

Re: [PR] SOLR-17582: Stream CLUSTERSTATUS API for SolrJ version >= 9.9 [solr]

2025-02-04 Thread via GitHub
mlbiscoc commented on code in PR #3156: URL: https://github.com/apache/solr/pull/3156#discussion_r1941385619 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/ClusterStateProviderTest.java: ## Review Comment: Understood. Would you prefer I just remove these backwards

Re: [I] Problems with istio and prometheus [solr-operator]

2025-02-04 Thread via GitHub
sukolenvo commented on issue #427: URL: https://github.com/apache/solr-operator/issues/427#issuecomment-2634253185 Can this issue be reopened please? appProtocol is not set in the latest operator: https://github.com/apache/solr-operator/blob/e1e4c2b3866581601b8e765139901447cb06cfa2/controll

Re: [PR] SOLR-15767: Prometheus alert rules for monitoring SolrCloud clusters on Kubernetes [solr]

2025-02-04 Thread via GitHub
janhoy commented on PR #395: URL: https://github.com/apache/solr/pull/395#issuecomment-2634109711 @thelabdude Picking up this again. First question: Would this rule set find a better home in solr-operator git repo? It could be part of helm template for rules to install as default, and

[jira] [Updated] (SOLR-15767) Include a core set of Prometheus alert rules for monitoring SolrCloud on K8s

2025-02-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-15767: -- Labels: pull-request-available (was: ) > Include a core set of Prometheus alert rules for moni

Re: [PR] SOLR-15767: Prometheus alert rules for monitoring SolrCloud clusters on Kubernetes [solr]

2025-02-04 Thread via GitHub
solrbot commented on PR #395: URL: https://github.com/apache/solr/pull/395#issuecomment-2634107231 @thelabdude Picking up this again. First question: Would this rule set find a better home in solr-operator git repo? It could be part of helm template for rules to install as default, an