Re: [PR] SOLR-17531: Use new unified GC options [solr]

risdenk commented on PR #2815: URL: https://github.com/apache/solr/pull/2815#issuecomment-2508795505 > > I think I prefer the GC being explicit instead of relying on whatever JDK value is the default. The logging cleanup configs look good, but I would keep the G1GC configs. > > I was

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

risdenk commented on code in PR #2835: URL: https://github.com/apache/solr/pull/2835#discussion_r1864048897 ## solr/modules/hdfs/src/java/org/apache/solr/hdfs/HdfsDirectoryFactory.java: ## @@ -16,8 +16,6 @@ */ package org.apache.solr.hdfs; -import static org.apache.hadoop.

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

risdenk commented on code in PR #2835: URL: https://github.com/apache/solr/pull/2835#discussion_r1864048605 ## solr/modules/hdfs/src/java/org/apache/solr/hdfs/HdfsDirectoryFactory.java: ## Review Comment: the modules/hdfs should not be touched. that is totally separate.

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2508216592 Sure, I thought that it was handy to have the vectorisation models as a managed resource, that can be added/deleted/viewed on the fly via REST. Also thought managed resources w

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

dsmiley commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863822274 ## solr/solr-ref-guide/modules/query-guide/pages/text-to-vector.adoc: ## @@ -258,7 +259,7 @@ http://localhost:8983/solr/techproducts/schema/embedding-model-store

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

dsmiley commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2508199409 > I agree that it takes an extra step to sopurce control this as you'll need to source control it and then push it to the model store (like it happens with Learning To Rank). I'm not sure

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2508186617 > Is there a **non**-web-API way to configure a model? If not, why not? The vast majority of Solr's configuration is in solrconfig.xml, schema.xml, and some related config files

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863801155 ## solr/modules/llm/src/java/org/apache/solr/llm/store/EmbeddingModelStore.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863793135 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863792771 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863791209 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863789709 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863788045 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863787141 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863786904 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863786126 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863748366 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863747015 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863746485 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863744174 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863742119 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863742396 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863741350 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,269 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863738586 ## solr/modules/llm/src/test-files/solr/collection1/conf/schema.xml: ## @@ -0,0 +1,52 @@ + + + + + + Review Comment: Done! -- This is an automated mess

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863737227 ## solr/modules/llm/src/test/org/apache/solr/llm/TestLlmBase.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863723471 ## solr/modules/llm/src/java/org/apache/solr/llm/store/EmbeddingModelStore.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] SOLR-17568: SolrCloud shouldn't proxy/route a core specific request [solr]

dsmiley commented on code in PR #2885: URL: https://github.com/apache/solr/pull/2885#discussion_r1863549763 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -1145,40 +1123,32 @@ protected String getRemoteCoreUrl(String collectionName, String origCorename)

Re: [PR] [WIP] Jetty12 + EE8 [solr]

iamsanjay commented on PR #2876: URL: https://github.com/apache/solr/pull/2876#issuecomment-2507843531 Next, there is one issue with the `InstrumentedHandler` which is used to track metrics for JettyHandlers. However, with the upgrade that class is not valid anymore. Though dropwizard/metri

Re: [PR] [WIP] Jetty12 + EE8 [solr]

iamsanjay commented on PR #2876: URL: https://github.com/apache/solr/pull/2876#issuecomment-2507837337 Recent commit fix the test cases related to V2 api. For now, it's just a workaround and I'll discuss with Jason to come up with a better solution. Earlier we were setting all the headers n

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863506879 ## solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (AS

[jira] [Assigned] (SOLR-17579) Remove unused methods in IndexFetcher and ReplicationHandler

[ https://issues.apache.org/jira/browse/SOLR-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-17579: Assignee: Eric Pugh > Remove unused methods in IndexFetcher and ReplicationHandler > -

[jira] [Updated] (SOLR-17579) Remove unused methods in IndexFetcher and ReplicationHandler

[ https://issues.apache.org/jira/browse/SOLR-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-17579: - Attachment: f7418bcb82a9668128c7bf72c1e25bbe31026fd9.patch > Remove unused methods in IndexFetcher and Re

Re: [PR] SOLR-17576: Remove deprecated master/slave support in ReplicationHandler [solr]

epugh commented on PR #2887: URL: https://github.com/apache/solr/pull/2887#issuecomment-2507711528 I've removed the extra refactorings and created a new issue https://issues.apache.org/jira/browse/SOLR-17579 to track that (and remind me!) -- This is an automated message from the Apache Gi

[jira] [Created] (SOLR-17579) Remove unused methods in IndexFetcher and ReplicationHandler

Eric Pugh created SOLR-17579: Summary: Remove unused methods in IndexFetcher and ReplicationHandler Key: SOLR-17579 URL: https://issues.apache.org/jira/browse/SOLR-17579 Project: Solr Issue Type

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863439805 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## Review Comment: embedding text is a 'synonym' of enrich text with vector(s). I

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863372272 ## solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1863364769 ## solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (AS

[PR] Create 2024-11-26-apache-solr-filter-queries-integer-or-string-fields… [solr-site]

alessandrobenedetti opened a new pull request, #134: URL: https://github.com/apache/solr-site/pull/134 ….md (#133) added a blog post about Apache solr filter queries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Create 2024-11-26-apache-solr-filter-queries-integer-or-string-fields… [solr-site]

alessandrobenedetti merged PR #134: URL: https://github.com/apache/solr-site/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] Create 2024-11-26-apache-solr-filter-queries-integer-or-string-fields.md [solr-site]

alessandrobenedetti merged PR #133: URL: https://github.com/apache/solr-site/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...