Re: [PR] SOLR-14680: Remove SimpleMap (affects NamedList) [solr]

2024-11-21 Thread via GitHub
dsmiley commented on PR #2856: URL: https://github.com/apache/solr/pull/2856#issuecomment-2492835758 I plan to merge this next week with the following CHANGES.txt under 9.8 CHANGES.txt, 9.8: ``` OTHER * SOLR-14680: NamedList, deprecating methods: forEachEntry, forEachKey, abortab

[jira] [Resolved] (SOLR-17478) ZkTestServer bugs can cause 30sec test pauses

2024-11-21 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter resolved SOLR-17478. --- Fix Version/s: main (10.0) 9.8 Assignee: Chris M. Hostette

Re: [PR] SOLR-17567: Improve Stream CLI implementation [solr]

2024-11-21 Thread via GitHub
epugh merged PR #2872: URL: https://github.com/apache/solr/pull/2872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17567) Improve Stream CLI implementation

2024-11-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900218#comment-17900218 ] ASF subversion and git services commented on SOLR-17567: Commit 6

Re: [PR] SOLR-17567: Improve Stream CLI implementation [solr]

2024-11-21 Thread via GitHub
epugh commented on PR #2872: URL: https://github.com/apache/solr/pull/2872#issuecomment-2492664639 Since this is a straight up follow on from the introduction of the StreamTool in `main` I am not adding CHANGES.txt entry. -- This is an automated message from the Apache Git Service. To res

Re: [PR] SOLR-16903: Update CLI tools to use java.nio.file.Path instead of java.io.File [solr]

2024-11-21 Thread via GitHub
epugh commented on code in PR #2883: URL: https://github.com/apache/solr/pull/2883#discussion_r1853138339 ## solr/core/src/test/org/apache/solr/cli/PostToolTest.java: ## @@ -281,15 +281,15 @@ public void testAppendUrlPath() { @Test public void testGuessType() { File f

[jira] [Commented] (SOLR-17478) ZkTestServer bugs can cause 30sec test pauses

2024-11-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900215#comment-17900215 ] ASF subversion and git services commented on SOLR-17478: Commit 5

[jira] [Commented] (SOLR-17478) ZkTestServer bugs can cause 30sec test pauses

2024-11-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900204#comment-17900204 ] ASF subversion and git services commented on SOLR-17478: Commit a

Re: [PR] Avoid NPE if snapshotMgr failed during init [solr]

2024-11-21 Thread via GitHub
dsmiley commented on PR #2879: URL: https://github.com/apache/solr/pull/2879#issuecomment-2492460643 I pushed to 9x too: https://github.com/apache/solr/commit/119b98623cc47953111a64d9034af59726c9b9b8 Thanks. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-11-21 Thread via GitHub
dsmiley commented on PR #2452: URL: https://github.com/apache/solr/pull/2452#issuecomment-2492473805 Something like this would be great to discuss at a Solr meetup/conf/whatever. Feel free to take half of a community meetup to show & tell when you're ready. -- This is an automated messa

[jira] [Updated] (SOLR-16903) Use Path instead of File in Java Code

2024-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-16903: -- Labels: newdev pull-request-available (was: newdev) > Use Path instead of File in Java Code >

[PR] SOLR-16903: Update CLI tools to use java.nio.file.Path instead of java.io.File [solr]

2024-11-21 Thread via GitHub
AndreyBozhko opened a new pull request, #2883: URL: https://github.com/apache/solr/pull/2883 https://issues.apache.org/jira/browse/SOLR-16903 # Description I would like to work on SOLR-16903 - this PR only addresses part of it. Here, I'm migrating the CLI tools from using

Re: [PR] Avoid NPE if snapshotMgr failed during init [solr]

2024-11-21 Thread via GitHub
dsmiley merged PR #2879: URL: https://github.com/apache/solr/pull/2879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17570) cursorMark should assume minExactCount=0

2024-11-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900193#comment-17900193 ] David Smiley commented on SOLR-17570: - RE minExactCount==0: I looked through Solr &

[jira] [Commented] (SOLR-17571) Introduce dependabot

2024-11-21 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900191#comment-17900191 ] Christos Malliaridis commented on SOLR-17571: - You are correct, dependabot as

Re: [PR] SOLR-16390: v2 Cluster Property APIs. [solr]

2024-11-21 Thread via GitHub
cugarte commented on PR #2788: URL: https://github.com/apache/solr/pull/2788#issuecomment-2492375601 Thanks, Jason! And apologies for the broken tests that you had to fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (SOLR-16390) Cosmetic improvements and migration to JAX-RS (v2 cluster and clusterprop APIs)

2024-11-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900186#comment-17900186 ] ASF subversion and git services commented on SOLR-16390: Commit e

[jira] [Commented] (SOLR-16390) Cosmetic improvements and migration to JAX-RS (v2 cluster and clusterprop APIs)

2024-11-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900183#comment-17900183 ] ASF subversion and git services commented on SOLR-16390: Commit a

Re: [PR] SOLR-16390: v2 Cluster Property APIs. [solr]

2024-11-21 Thread via GitHub
gerlowskija merged PR #2788: URL: https://github.com/apache/solr/pull/2788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-16390: v2 Cluster Property APIs. [solr]

2024-11-21 Thread via GitHub
gerlowskija commented on PR #2788: URL: https://github.com/apache/solr/pull/2788#issuecomment-2492188125 Alright, gearing up to merge this now. I've added a CHANGES.txt entry for this - ended up being pretty chunky since this PR both makes a few existing APIs easier to grok, as well as add

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2024-11-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900158#comment-17900158 ] ASF subversion and git services commented on SOLR-16825: Commit 6

[jira] [Commented] (SOLR-17571) Introduce dependabot

2024-11-21 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900171#comment-17900171 ] Christos Malliaridis commented on SOLR-17571: - According to an observation, t

[jira] [Commented] (SOLR-17570) cursorMark should assume minExactCount=0

2024-11-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900169#comment-17900169 ] David Smiley commented on SOLR-17570: - Thanks for your input. Unfortunately I think

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-21 Thread via GitHub
dsmiley commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2492129281 To answer some of these questions, it's helpful to do git-blame (I use my IDE actually) sometimes with history for the selected code to find the people/issues and then follow up with anyone.

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-21 Thread via GitHub
dsmiley commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2492127222 I'm not surprised there's a blast radius that exceeds the module itself. For everything outside the module, we'll need to review/edit with some care and it'll be on a case-by-case basis.

[jira] [Commented] (SOLR-6934) bin/solr -e cloud has poor failure behavior when solr has (certain types of) startup errors

2024-11-21 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900161#comment-17900161 ] Chris M. Hostetter commented on SOLR-6934: -- I think given the existence of {{./bi

[jira] [Resolved] (SOLR-16825) Generate Java bindings from OpenAPI spec

2024-11-21 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-16825. Fix Version/s: 9.8 Assignee: Jason Gerlowski Resolution: Fixed Alright, I b

[jira] [Commented] (SOLR-6948) "bin/solr -e cloud" shouldn't bother to ask about collection options if it already exists

2024-11-21 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900157#comment-17900157 ] Chris M. Hostetter commented on SOLR-6948: -- I think it would make a nice little i

[jira] [Updated] (SOLR-6948) "bin/solr -e cloud" shouldn't bother to ask about collection options if it already exists

2024-11-21 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-6948: - Labels: newdev (was: ) > "bin/solr -e cloud" shouldn't bother to ask about collection opt

[jira] [Commented] (SOLR-17570) cursorMark should assume minExactCount=0

2024-11-21 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900156#comment-17900156 ] Chris M. Hostetter commented on SOLR-17570: --- {quote}Someone using cursorMark (

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2024-11-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900154#comment-17900154 ] ASF subversion and git services commented on SOLR-16825: Commit 1

Re: [PR] SOLR-16825: Migrate v2 API definitions to 'api' module, pt 9 [solr]

2024-11-21 Thread via GitHub
gerlowskija merged PR #2870: URL: https://github.com/apache/solr/pull/2870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [I] Pods begin to restart as soon auth is enabled [solr-operator]

2024-11-21 Thread via GitHub
VishwajeetPandeyy commented on issue #730: URL: https://github.com/apache/solr-operator/issues/730#issuecomment-2491754141 ` bin/solr zk ls /configs` ``` my_new_configset _default ``` Custom configset is present but still not able to use it to create collection `

Re: [I] Pods begin to restart as soon auth is enabled [solr-operator]

2024-11-21 Thread via GitHub
VishwajeetPandeyy commented on issue #730: URL: https://github.com/apache/solr-operator/issues/730#issuecomment-2491359439 I enabled basic auth using : ``` solrOptions: security: authenticationType: Basic ``` After this , I bootstrapped the solr-operator again

[PR] SOLR-17406: Update labeler.yml to correctly set dependency label [solr]

2024-11-21 Thread via GitHub
malliaridis opened a new pull request, #2882: URL: https://github.com/apache/solr/pull/2882 https://issues.apache.org/jira/browse/SOLR-17406 # Description With the updates from https://github.com/apache/solr/pull/2706 the GitHub action does not take the new `gradle/libs.version

Re: [PR] SOLR-17571: Introduce dependabot [solr]

2024-11-21 Thread via GitHub
janhoy commented on PR #2880: URL: https://github.com/apache/solr/pull/2880#issuecomment-2491150874 > no PR limit creates over 70 PRs If possible, I'd rate-limit this on the first few days so we have a chance to fine-tune the bot. -- This is an automated message from the Apache Git

Re: [PR] SOLR-17571: Introduce dependabot [solr]

2024-11-21 Thread via GitHub
janhoy commented on PR #2880: URL: https://github.com/apache/solr/pull/2880#issuecomment-2491149013 > Are there any specific needs for how to treat security updates (dependencies with vulnerabilities)? We have not distinguished these before, and such CVEs are already public anyway. C

Re: [I] Pods begin to restart as soon auth is enabled [solr-operator]

2024-11-21 Thread via GitHub
janhoy commented on issue #730: URL: https://github.com/apache/solr-operator/issues/730#issuecomment-2491069291 You should provision auth using the operator's configuration, not manually. The operator needs to know the basic auth password so it can execute the startup- and liveness-probes.

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-11-21 Thread via GitHub
epugh commented on PR #2873: URL: https://github.com/apache/solr/pull/2873#issuecomment-2490590424 Closing in favour of the main branch. Will dig into probably early next week unless someone beats me too it! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-11-21 Thread via GitHub
epugh closed pull request #2873: SOLR-17306: fix replication problem on follower restart URL: https://github.com/apache/solr/pull/2873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]

2024-11-21 Thread via GitHub
timatbw commented on PR #2742: URL: https://github.com/apache/solr/pull/2742#issuecomment-2490462421 > does it mean `FacetParser` change is not necessary? The PR now only changes that class to make it public but that was probably only needed in the original changes around registering

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-21 Thread via GitHub
epugh commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2490439421 I ran `find . -not -path '*/\.*' -type f -exec grep -l -i "kerberos" {} +` and wow... There are a LOT more files... I think what I am hearing is that just removing the module and the l

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-21 Thread via GitHub
epugh commented on code in PR #2835: URL: https://github.com/apache/solr/pull/2835#discussion_r1851620976 ## solr/modules/hadoop-auth/src/java/org/apache/solr/security/hadoop/KerberosPlugin.java: ## Review Comment: I started thinking that there were TWO things... Kerberos

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-21 Thread via GitHub
dsmiley commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2490177006 Hadoop Auth and Kerberos aren't the same. [Kerberos](https://en.wikipedia.org/wiki/Kerberos_(protocol)) is an authentication protocol, [Hadoop-Auth](https://hadoop.apache.org/docs/current/

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-21 Thread via GitHub
alessandrobenedetti commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2490332795 Thanks @malliaridis , your help has been gold. Tests are green again and the deps are in line with the new expectations! I'll wait until next Thursday (After Search Solutions L