epugh commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2490439421
I ran `find . -not -path '*/\.*' -type f -exec grep -l -i "kerberos" {} +` and wow... There are a LOT more files... I think what I am hearing is that just removing the module and the light changes to the webapp isn't enough. There are a whole bunch of OTHER places that rely in one way or another on `hadoop-auth`? I had some thoughts of moving it to the sandbox, but if it's this ingrained in various locations in Solr, then that really doesn't make sense. Does this align with other folks expectations that removing Hadoop Auth would touch all these files? ``` ./solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java ./solr/core/src/java/org/apache/solr/core/CoreContainer.java ./solr/core/src/java/org/apache/solr/security/AuthorizationContext.java ./solr/core/src/java/org/apache/solr/cli/AuthTool.java ./solr/core/src/java/org/apache/solr/request/json/RequestUtil.java ./solr/bin/solr ./solr/bin/solr.cmd ./solr/bin/solr.in.sh ./solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrClientTest.java ./solr/solrj/src/java/org/apache/solr/client/solrj/impl/Krb5HttpClientBuilder.java ./solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java ./solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-8.adoc ./solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc ./solr/solr-ref-guide/modules/deployment-guide/pages/authentication-and-authorization-plugins.adoc ./solr/solr-ref-guide/modules/deployment-guide/pages/zookeeper-access-control.adoc ./solr/solr-ref-guide/modules/deployment-guide/pages/solr-on-hdfs.adoc ./solr/solr-ref-guide/modules/deployment-guide/pages/solr-control-script-reference.adoc ./solr/solr-ref-guide/modules/deployment-guide/pages/rule-based-authorization-plugin.adoc ./solr/solr-ref-guide/modules/getting-started/pages/solr-admin-ui.adoc ./solr/webapp/web/js/angular/controllers/index.js ./solr/server/etc/security.policy ./solr/CHANGES.txt ./solr/modules/hdfs/src/java/org/apache/solr/hdfs/HdfsDirectoryFactory.java ./gradle/documentation/render-javadoc/java11/package-list ./gradle/testing/randomization/policies/solr-tests.policy ./dev-tools/scripts/refguide/new-guide.txt ./dev-tools/scripts/refguide/old-guide.txt ./dev-tools/scripts/refguide/htaccess.txt ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org