Re: [PR] Feature/solr-17334 Minor bugs in Solr dedicated coordinator mode [solr]

2024-11-17 Thread via GitHub
github-actions[bot] commented on PR #2672: URL: https://github.com/apache/solr/pull/2672#issuecomment-2481686802 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be fam

Re: [PR] SolrTestCase now supports @LogLevel [solr]

2024-11-17 Thread via GitHub
dsmiley commented on code in PR #2869: URL: https://github.com/apache/solr/pull/2869#discussion_r1845676256 ## solr/test-framework/src/java/org/apache/solr/util/LogLevelTestRule.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[PR] SolrTestCase now supports @LogLevel [solr]

2024-11-17 Thread via GitHub
dsmiley opened a new pull request, #2869: URL: https://github.com/apache/solr/pull/2869 Refactored the functionality into a TestRule, and moved from STCJ4 up to SolrTestCase. Move reinstatement of the root log level to shutdown() (part of bigger goal of abandoning SolrTestCaseJ4)

Re: [PR] SOLR-14680: Remove SimpleMap (affects NamedList) [solr]

2024-11-17 Thread via GitHub
dsmiley commented on code in PR #2856: URL: https://github.com/apache/solr/pull/2856#discussion_r1845543227 ## solr/core/src/java/org/apache/solr/cli/CreateTool.java: ## @@ -167,10 +166,9 @@ protected void createCore(CommandLine cli, SolrClient solrClient) throws Excepti

Re: [PR] SOLR-14680: Remove SimpleMap (affects NamedList) [solr]

2024-11-17 Thread via GitHub
epugh commented on code in PR #2856: URL: https://github.com/apache/solr/pull/2856#discussion_r1845545807 ## solr/core/src/java/org/apache/solr/cli/CreateTool.java: ## @@ -167,10 +166,9 @@ protected void createCore(CommandLine cli, SolrClient solrClient) throws Excepti S

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-11-17 Thread via GitHub
epugh commented on PR #2605: URL: https://github.com/apache/solr/pull/2605#issuecomment-2481371284 I think having a single link from the top of the old admin to the new ui is fine. I am hoping that as part of the new UI, you don't feel constrained to copy the old Admin UI. It's okay to re

Re: [PR] SOLR-14680: Remove SimpleMap (affects NamedList) [solr]

2024-11-17 Thread via GitHub
epugh commented on code in PR #2856: URL: https://github.com/apache/solr/pull/2856#discussion_r1845469076 ## solr/core/src/java/org/apache/solr/cli/CreateTool.java: ## @@ -167,10 +166,9 @@ protected void createCore(CommandLine cli, SolrClient solrClient) throws Excepti S

Re: [PR] SOLR-14680: Remove SimpleMap (affects NamedList) [solr]

2024-11-17 Thread via GitHub
epugh commented on code in PR #2856: URL: https://github.com/apache/solr/pull/2856#discussion_r1845468260 ## solr/core/src/java/org/apache/solr/cli/CreateTool.java: ## @@ -167,10 +166,9 @@ protected void createCore(CommandLine cli, SolrClient solrClient) throws Excepti S

Re: [PR] SOLR-17432: Allow OTel Java Agent [solr]

2024-11-17 Thread via GitHub
github-actions[bot] commented on PR #2687: URL: https://github.com/apache/solr/pull/2687#issuecomment-2480856141 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be fam