epugh commented on code in PR #2856:
URL: https://github.com/apache/solr/pull/2856#discussion_r1845469076
##########
solr/core/src/java/org/apache/solr/cli/CreateTool.java:
##########
@@ -167,10 +166,9 @@ protected void createCore(CommandLine cli, SolrClient
solrClient) throws Excepti
String coreRootDirectory; // usually same as solr home, but not always
- Map<String, Object> systemInfo =
- solrClient
- .request(new GenericSolrRequest(SolrRequest.METHOD.GET,
CommonParams.SYSTEM_INFO_PATH))
- .asMap();
Review Comment:
I also wish we just had a cleaner data structure for these GSR that return
JSON. I love that in our tests we have `assertJQ` and `JQ` methods that lets
us grab some json. In a perfect world, this call would have returned a JSON
datastructure, and I would use a Json query line to pluck out the `core_root`.
This would be more compelling if we had a much more nested Map data structure
to go through!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
