[jira] [Commented] (SOLR-12723) Reduce object creation in HashBasedRouter

2024-11-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897805#comment-17897805 ] David Smiley commented on SOLR-12723: - Exposing a plain array out of DocCollection is

Re: [PR] SOLR-14680: Remove SimpleMap (affects NamedList) [solr]

2024-11-12 Thread via GitHub
noblepaul commented on code in PR #2856: URL: https://github.com/apache/solr/pull/2856#discussion_r183934 ## solr/core/src/java/org/apache/solr/util/DataConfigNode.java: ## @@ -54,31 +53,17 @@ public DataConfigNode(ConfigNode root) { e.setValue(List.copyOf(e.getValu

Re: [PR] SOLR-14680: Remove SimpleMap (affects NamedList) [solr]

2024-11-12 Thread via GitHub
noblepaul commented on code in PR #2856: URL: https://github.com/apache/solr/pull/2856#discussion_r1839345415 ## solr/core/src/java/org/apache/solr/util/DataConfigNode.java: ## @@ -54,31 +53,17 @@ public DataConfigNode(ConfigNode root) { e.setValue(List.copyOf(e.getValu

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-12 Thread via GitHub
dsmiley commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2472188518 Thanks for your patience Alessandro and willingness to consider alternatives! Originally when I heard "model", I thought of some potentially large thing (the FileStore is good for large thi

[jira] [Commented] (SOLR-17557) PeerSync should only be called when the ZkShardTerm is not the highest

2024-11-12 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897749#comment-17897749 ] Mark Robert Miller commented on SOLR-17557: --- There is always a most up to date

[jira] [Updated] (SOLR-17556) Examples should run with the standard & recommended Solr process

2024-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17556: -- Labels: pull-request-available (was: ) > Examples should run with the standard & recommended S

[jira] [Commented] (SOLR-17557) PeerSync should only be called when the ZkShardTerm is not the highest

2024-11-12 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897716#comment-17897716 ] Houston Putman commented on SOLR-17557: --- The problem is if there is no up-to-date r

[jira] [Commented] (SOLR-17557) PeerSync should only be called when the ZkShardTerm is not the highest

2024-11-12 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897713#comment-17897713 ] Mark Robert Miller commented on SOLR-17557: --- That’s a safe, straightforward opt

[jira] [Comment Edited] (SOLR-17557) PeerSync should only be called when the ZkShardTerm is not the highest

2024-11-12 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897713#comment-17897713 ] Mark Robert Miller edited comment on SOLR-17557 at 11/12/24 7:37 PM: --

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-11-12 Thread via GitHub
cpoerschke commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1838610348 ## solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java: ## @@ -115,6 +116,12 @@ public void process(ResponseBuilder rb) throws IOException {

[jira] [Reopened] (SOLR-17381) Make CLUSTERSTATUS request configurable

2024-11-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reopened SOLR-17381: - Reopening for bug fix -- PR [2853|https://github.com/apache/solr/pull/2853] > Make CLUSTERSTATUS req

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2024-11-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897692#comment-17897692 ] ASF subversion and git services commented on SOLR-16825: Commit e

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-11-12 Thread via GitHub
cpoerschke commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1838594950 ## solr/modules/monitor/src/java/org/apache/solr/monitor/search/ReverseSearchComponent.java: ## @@ -0,0 +1,207 @@ +/* + * + * * Licensed to the Apache Software Foundat

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2024-11-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897697#comment-17897697 ] ASF subversion and git services commented on SOLR-16825: Commit 9

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-11-12 Thread via GitHub
cpoerschke commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1838584908 ## solr/modules/monitor/src/java/org/apache/solr/monitor/MonitorConstants.java: ## @@ -0,0 +1,27 @@ +/* + * + * * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] SOLR-16825: Migrate v2 API definitions to 'api' module, pt 8 [solr]

2024-11-12 Thread via GitHub
gerlowskija merged PR #2833: URL: https://github.com/apache/solr/pull/2833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-12 Thread via GitHub
alessandrobenedetti commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2471257341 I've done another round of thinking, polishing and experimenting, my comments follow on the various open topics: ### Tests I spent a good 2-3 hours trying to refactor the te

[jira] [Created] (SOLR-17557) PeerSync should only be called when the ZkShardTerm is not the highest

2024-11-12 Thread Houston Putman (Jira)
Houston Putman created SOLR-17557: - Summary: PeerSync should only be called when the ZkShardTerm is not the highest Key: SOLR-17557 URL: https://issues.apache.org/jira/browse/SOLR-17557 Project: Solr

Re: [PR] SOLR-17256: Nuke SolrRequest set/getBasePath in 10 [solr]

2024-11-12 Thread via GitHub
gerlowskija merged PR #2852: URL: https://github.com/apache/solr/pull/2852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Resolved] (SOLR-17256) Remove SolrRequest.getBasePath setBasePath

2024-11-12 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-17256. Fix Version/s: main (10.0) 9.7 Resolution: Fixed Closing this out

[jira] [Commented] (SOLR-17256) Remove SolrRequest.getBasePath setBasePath

2024-11-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897676#comment-17897676 ] ASF subversion and git services commented on SOLR-17256: Commit 1

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-11-12 Thread via GitHub
risdenk commented on code in PR #2706: URL: https://github.com/apache/solr/pull/2706#discussion_r1838502296 ## solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java: ## @@ -92,8 +92,7 @@ public void init(final NamedList args) { Stri

[jira] [Assigned] (SOLR-17556) Examples should run with the standard & recommended Solr process

2024-11-12 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-17556: Assignee: Eric Pugh > Examples should run with the standard & recommended Solr process > -

Re: [PR] SOLR-17256: Nuke SolrRequest set/getBasePath in 10 [solr]

2024-11-12 Thread via GitHub
gerlowskija commented on code in PR #2852: URL: https://github.com/apache/solr/pull/2852#discussion_r1838490244 ## solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java: ## @@ -66,32 +64,23 @@ public static Collection toContentStreams( * Create the full URL

Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]

2024-11-12 Thread via GitHub
timatbw commented on PR #2742: URL: https://github.com/apache/solr/pull/2742#issuecomment-2471097616 Yes that sounds good, as I feel we might be trying to expand the scope of this change too much for 1 PR. I agree, making the public modifiers change is needed, then we can document how to do

[jira] [Created] (SOLR-17556) Examples should run with the standard & recommended Solr process

2024-11-12 Thread Houston Putman (Jira)
Houston Putman created SOLR-17556: - Summary: Examples should run with the standard & recommended Solr process Key: SOLR-17556 URL: https://issues.apache.org/jira/browse/SOLR-17556 Project: Solr

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-12 Thread via GitHub
alessandrobenedetti commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2470976565 Thanks @cpoerschke for the feedback, all merged. Just done the rename, but had to use snake case "text_embedder" as looking around for query parsers, was not able to find c

[PR] chore(deps): update io.netty:* to v4.1.115.final [solr]

2024-11-12 Thread via GitHub
solrbot opened a new pull request, #2860: URL: https://github.com/apache/solr/pull/2860 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.netty:netty-transport-native-unix-common](https://netty.io/) ([source](https://redirect.gi

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-11-12 Thread via GitHub
malliaridis commented on code in PR #2706: URL: https://github.com/apache/solr/pull/2706#discussion_r1838332962 ## solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java: ## @@ -92,8 +92,7 @@ public void init(final NamedList args) {

[jira] [Commented] (SOLR-17344) Randomize short/long opts usage in Java-based CLI tests

2024-11-12 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897499#comment-17897499 ] Christos Malliaridis commented on SOLR-17344: - I could not say that commons-c

[jira] [Comment Edited] (SOLR-17344) Randomize short/long opts usage in Java-based CLI tests

2024-11-12 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897499#comment-17897499 ] Christos Malliaridis edited comment on SOLR-17344 at 11/12/24 1:07 PM:

Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-11-12 Thread via GitHub
malliaridis commented on code in PR #2744: URL: https://github.com/apache/solr/pull/2744#discussion_r1838018198 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-11-12 Thread via GitHub
malliaridis commented on code in PR #2744: URL: https://github.com/apache/solr/pull/2744#discussion_r1838016144 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-11-12 Thread via GitHub
malliaridis commented on code in PR #2744: URL: https://github.com/apache/solr/pull/2744#discussion_r1837998002 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[jira] [Created] (SOLR-17553) Embed tool --help output into RefGuide

2024-11-12 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-17553: Summary: Embed tool --help output into RefGuide Key: SOLR-17553 URL: https://issues.apache.org/jira/browse/SOLR-17553 Project: Solr Issue Type: Sub-task Co

[jira] [Assigned] (SOLR-17553) Embed tool --help output into RefGuide

2024-11-12 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-17553: Assignee: Eric Pugh > Embed tool --help output into RefGuide > ---

Re: [PR] SOLR-17490: Check for existence of perl executable and skip if it doesnt exist [solr]

2024-11-12 Thread via GitHub
epugh commented on PR #2753: URL: https://github.com/apache/solr/pull/2753#issuecomment-2470257742 @patrbraun would you mind taking another stab with the latest change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] SOLR-17490: Check for existence of perl executable and skip if it doesnt exist [solr]

2024-11-12 Thread via GitHub
epugh commented on code in PR #2753: URL: https://github.com/apache/solr/pull/2753#discussion_r1837923367 ## gradle/documentation/changes-to-html.gradle: ## @@ -76,8 +76,16 @@ class ChangesToHtmlTask extends DefaultTask { def toHtml(File versionsFile) { def output = ne