[jira] [Commented] (SOLR-17453) Replace CloudUtil.waitForState and some TimeOut with ZkStateReader.waitForState

2024-11-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896178#comment-17896178 ] ASF subversion and git services commented on SOLR-17453: Commit b

Re: [PR] SOLR-17453: Leverage waitForState() instead of busy waiting [solr]

2024-11-06 Thread via GitHub
dsmiley merged PR #2737: URL: https://github.com/apache/solr/pull/2737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17537: Manage ZK Compression through Curator [solr]

2024-11-06 Thread via GitHub
dsmiley commented on PR #2849: URL: https://github.com/apache/solr/pull/2849#issuecomment-2461467862 Could we call compress() universally and then our compressor chooses to only compress based on our criteria (state.json)? Just an idea off the top of my head; I don't know where compress()

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2024-11-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896163#comment-17896163 ] David Smiley commented on SOLR-14680: - I read the above discussion. I sympathize with

[jira] [Commented] (SOLR-4587) Implement Saved Searches a la ElasticSearch Percolator

2024-11-06 Thread Luke Kot-Zaniewski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896132#comment-17896132 ] Luke Kot-Zaniewski commented on SOLR-4587: -- Hello [~janhoy]! I am indeed still ar

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-11-06 Thread via GitHub
kotman12 commented on PR #2382: URL: https://github.com/apache/solr/pull/2382#issuecomment-2461095739 > I'm really excited about this PR because that looks like a great feature to use. Are there any updates on this? Hey @zzBrunoBrito , thanks for the comment! We are currently testing

Re: [PR] Nest the script-update-processor page UNDER the update-request-processors page [solr]

2024-11-06 Thread via GitHub
github-actions[bot] commented on PR #2696: URL: https://github.com/apache/solr/pull/2696#issuecomment-2461038201 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be fam

[jira] (SOLR-2522) add syntax for selecting the min or max of a multivalued field in value source functions

2024-11-06 Thread Chris Emerson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-2522 ] Chris Emerson deleted comment on SOLR-2522: - was (Author: chrisemerson): This would be incredibly helpful! Voting up. As a side note, I actually tried for a while to do this as it wasn't clear

Re: [PR] Update dependency com.github.spotbugs:spotbugs-annotations to v4.8.6 [solr]

2024-11-06 Thread via GitHub
malliaridis merged PR #2129: URL: https://github.com/apache/solr/pull/2129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-17483: Backport cleanup zk-related logic in bin/solr.cmd [solr]

2024-11-06 Thread via GitHub
malliaridis commented on PR #2823: URL: https://github.com/apache/solr/pull/2823#issuecomment-2460986025 Since there are bugfixes included as well, I think we are good to go. There is no ETA for the Windows testing, so it should not be a blocker. -- This is an automated message from the A

[jira] [Created] (SOLR-17548) Switch all public Java APIs from File to Path

2024-11-06 Thread David Smiley (Jira)
David Smiley created SOLR-17548: --- Summary: Switch all public Java APIs from File to Path Key: SOLR-17548 URL: https://issues.apache.org/jira/browse/SOLR-17548 Project: Solr Issue Type: Task

[jira] [Updated] (SOLR-8282) Move Java APIs to NIO2 (Path), and ban use of java.io.File

2024-11-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-8282: --- Summary: Move Java APIs to NIO2 (Path), and ban use of java.io.File (was: Move Solr internal APIs to

[jira] [Updated] (SOLR-17548) Switch all public Java APIs from File to Path

2024-11-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17548: Fix Version/s: main (10.0) Labels: newdev (was: ) > Switch all public Java APIs from Fi

[jira] [Resolved] (SOLR-17544) Prevent conflicting connection options(-s and -z) from being used

2024-11-06 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17544. -- Fix Version/s: main (10.0) Assignee: Eric Pugh Resolution: Fixed Only targeting 10. >

[jira] [Resolved] (SOLR-17404) Tweak Tool.java to support the sub command use case

2024-11-06 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17404. -- Resolution: Duplicate Decide this is really a duplicate of SOLR-17401 and we don't need this ticket. >

[jira] [Resolved] (SOLR-17409) Use getOptionWithDeprecatedAndDefault in all places in CLI.

2024-11-06 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17409. -- Assignee: Eric Pugh Resolution: Fixed This is done enough.  We use it heavily in branch_9x, and d

[jira] [Updated] (SOLR-16999) AssertTool has lots of static methods

2024-11-06 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16999: - Labels: newdev (was: ) > AssertTool has lots of static methods > - >

[jira] [Commented] (SOLR-17544) Prevent conflicting connection options(-s and -z) from being used

2024-11-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896085#comment-17896085 ] ASF subversion and git services commented on SOLR-17544: Commit 0

Re: [PR] SOLR-17544: Prevent conflicting connection flags from being used via OptionGroup [solr]

2024-11-06 Thread via GitHub
epugh merged PR #2725: URL: https://github.com/apache/solr/pull/2725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-06 Thread via GitHub
alessandrobenedetti commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2460580259 I was able to find: org.apache.solr.filestore.ClusterFileStore -> implements ClusterFileStoreApis org.apache.solr.filestore.NodeFileStore -> implements NodeFileStoreApis

[jira] [Updated] (SOLR-17546) Update .htaccess for Ref Guide for removed pages

2024-11-06 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-17546: - Labels: blocker (was: ) > Update .htaccess for Ref Guide for removed pages > ---

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-06 Thread via GitHub
alessandrobenedetti commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2460404481 I'm taking a look at the file-store from a code perspective and it's harder than expected, I'll keep digging but @dsmiley do you have any code references or tests that show the

Re: [PR] SOLR-17535 ClusterState.collectionStream() in lieu of getCollectionStates() [solr]

2024-11-06 Thread via GitHub
dsmiley commented on PR #2834: URL: https://github.com/apache/solr/pull/2834#issuecomment-2460401449 Assuming tests pass, I'm hoping to merge tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-06 Thread via GitHub
alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1831456122 ## solr/modules/llm/src/test/org/apache/solr/llm/TestLlmBase.java: ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-06 Thread via GitHub
alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1831454038 ## solr/modules/llm/src/test/org/apache/solr/llm/TestLlmBase.java: ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-06 Thread via GitHub
alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1831449564 ## solr/modules/llm/src/test/org/apache/solr/llm/TestLlmBase.java: ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-06 Thread via GitHub
epugh commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2459640150 I have added https://issues.apache.org/jira/browse/SOLR-17546 to track the blocker task, I don't know if I did the "label" right, there were a lot to choose from! -- This is an automated

[PR] Update creation of URL to avoid deprecation message [solr]

2024-11-06 Thread via GitHub
epugh opened a new pull request, #2851: URL: https://github.com/apache/solr/pull/2851 Not user facing. No changes, no JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (SOLR-17525) Text to Vector Query Parser

2024-11-06 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896035#comment-17896035 ] Alessandro Benedetti commented on SOLR-17525: - Thanks guys for your input! [~

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-06 Thread via GitHub
epugh commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2460302583 When you look at the model store, it would be great to hear where it comes up short and we could look at improving it. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] SOLR-17483: Backport cleanup zk-related logic in bin/solr.cmd [solr]

2024-11-06 Thread via GitHub
epugh commented on PR #2823: URL: https://github.com/apache/solr/pull/2823#issuecomment-2459436370 I know we want to add windwos testing, but I wouldn't let that hold this up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Update dependency com.lmax:disruptor to v4 [solr]

2024-11-06 Thread via GitHub
malliaridis commented on PR #1990: URL: https://github.com/apache/solr/pull/1990#issuecomment-2460299770 lmax.disruptor is used for asynchronous logging (performance) and is required by log4j. Support for lmax.disruptor v4 is introduced in logj4 2.23.0, and therefore this PR depends on http

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-06 Thread via GitHub
alessandrobenedetti commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2459496597 Thanks all for the feedback, in order: 1) @epugh I am finalising the review of your comments, I'll add considerations/resolve them one by one 2) @cpoerschke thanks for the c

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-06 Thread via GitHub
alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1830836122 ## solr/modules/llm/src/test/org/apache/solr/llm/TestLlmBase.java: ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-06 Thread via GitHub
janhoy commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2459554765 > @janhoy I tried running that script, but couldn't quite grok it. COuld you give an example of what that scripts should be? And let's add an example to the readme or the to script itself!

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-06 Thread via GitHub
alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1830840186 ## solr/modules/llm/src/test/org/apache/solr/llm/store/rest/TestModelManager.java: ## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[jira] [Updated] (SOLR-17547) Collect ZK Metrics via Curator

2024-11-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17547: -- Labels: pull-request-available (was: ) > Collect ZK Metrics via Curator >

[PR] SOLR-17547: Collect ZK Metrics via Curator [solr]

2024-11-06 Thread via GitHub
HoustonPutman opened a new pull request, #2850: URL: https://github.com/apache/solr/pull/2850 https://issues.apache.org/jira/browse/SOLR-17547 So there are two ways we can do this. `AdvancedTracerDriver` and `CuratorListener`. The `CuratorListener` gives us much better information on

[jira] [Updated] (SOLR-17537) Let Curator handle state compression in ZooKeeper

2024-11-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17537: -- Labels: pull-request-available (was: ) > Let Curator handle state compression in ZooKeeper > -

[PR] SOLR-17537: Manage ZK Compression through Curator [solr]

2024-11-06 Thread via GitHub
HoustonPutman opened a new pull request, #2849: URL: https://github.com/apache/solr/pull/2849 https://issues.apache.org/jira/browse/SOLR-17537 Unfortunately, Curator currently requires that users explicitly use (`.compress()`) in order to enable compression for a zNode. We need to add

[jira] [Created] (SOLR-17547) Collect ZK Metrics via Curator

2024-11-06 Thread Houston Putman (Jira)
Houston Putman created SOLR-17547: - Summary: Collect ZK Metrics via Curator Key: SOLR-17547 URL: https://issues.apache.org/jira/browse/SOLR-17547 Project: Solr Issue Type: Sub-task Secu

Re: [PR] Update dependency com.adobe.testing:s3mock-junit4 to v3 [solr]

2024-11-06 Thread via GitHub
malliaridis commented on PR #1821: URL: https://github.com/apache/solr/pull/1821#issuecomment-2460164924 The module uses `org.springframework.boot:spring-boot-starter-jetty:3.2.5`, which transitively depends on Jetty 12. Therefore, related to https://github.com/apache/solr/pull/2782. --

Re: [PR] Update dependency com.adobe.testing:s3mock-junit4 to v3 [solr]

2024-11-06 Thread via GitHub
malliaridis commented on PR #1821: URL: https://github.com/apache/solr/pull/1821#issuecomment-2460139587 The major version 3.X from `s3mock-junit4` has JDK 17 as minimum requirement and should therefore not be backported to `branch_9x`. -- This is an automated message from the Apache Git

Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-11-06 Thread via GitHub
malliaridis commented on PR #2744: URL: https://github.com/apache/solr/pull/2744#issuecomment-2460051147 I'll also would wait for https://github.com/apache/solr/pull/2725 to be merged first before completing thins one. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] SOLR-17544: Prevent conflicting connection flags from being used via OptionGroup [solr]

2024-11-06 Thread via GitHub
epugh commented on code in PR #2725: URL: https://github.com/apache/solr/pull/2725#discussion_r1831238462 ## solr/CHANGES.txt: ## @@ -26,6 +26,8 @@ Improvements * SOLR-16116: Apache Curator is now used to manage all Solr Zookeeper interactions. This should provide more stabili

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-06 Thread via GitHub
epugh commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2460047387 Got a little too frisky, broke something in the `hdfs` module: ``` 2> 4749 ERROR (SUITE-HdfsCollectionsApiTest-seed#[54C70D1C3623A1D7]-worker) [n: c: s: r: x: t:] o.a.h.h.s.n.FSNamesy

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-06 Thread via GitHub
alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1830842476 ## solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc: ## @@ -0,0 +1,280 @@ += Embedding Text +// Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-17544: Prevent conflicting connection flags from being used via OptionGroup [solr]

2024-11-06 Thread via GitHub
malliaridis commented on code in PR #2725: URL: https://github.com/apache/solr/pull/2725#discussion_r1831113411 ## solr/CHANGES.txt: ## @@ -26,6 +26,8 @@ Improvements * SOLR-16116: Apache Curator is now used to manage all Solr Zookeeper interactions. This should provide more s

[jira] [Updated] (SOLR-17546) Update .htaccess for Ref Guide for removed pages

2024-11-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-17546: --- Priority: Blocker (was: Major) > Update .htaccess for Ref Guide for removed pages >

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-06 Thread via GitHub
janhoy commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2459891566 I added Priority=Blocker and FixVersion=10.0 to the JIRA to make it a valid 10.0 blocker. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (SOLR-17546) Update .htaccess for Ref Guide for removed pages

2024-11-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-17546: --- Fix Version/s: main (10.0) > Update .htaccess for Ref Guide for removed pages > -

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-06 Thread via GitHub
alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1830814871 ## solr/modules/llm/src/test/org/apache/solr/llm/TestLlmBase.java: ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-06 Thread via GitHub
alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1830837809 ## solr/modules/llm/src/test/org/apache/solr/llm/TestLlmBase.java: ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-06 Thread via GitHub
epugh commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2459526827 @janhoy I tried running that script, but couldn't quite grok it. COuld you give an example of what that scripts should be? And let's add an example to the readme or the to script itself!

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-11-06 Thread via GitHub
alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1830836383 ## solr/modules/llm/src/test/org/apache/solr/llm/TestLlmBase.java: ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-06 Thread via GitHub
epugh commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2459645491 Okay, I think I'm looking for an LGTM...I've also emailed the dev list with the PR.. No one has said "don't remove it" Is that enought to click merge when I get an LGTM? -- This

[jira] [Created] (SOLR-17546) Update .htaccess for Ref Guide for removed pages

2024-11-06 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-17546: Summary: Update .htaccess for Ref Guide for removed pages Key: SOLR-17546 URL: https://issues.apache.org/jira/browse/SOLR-17546 Project: Solr Issue Type: Task