alessandrobenedetti commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2459496597

   Thanks all for the feedback, in order:
   1) @epugh I am finalising the review of your comments, I'll add 
considerations/resolve them one by one
   2) @cpoerschke thanks for the commit suggestions, I merged all of them, 
tests are green
   3) @dsmiley no problem David! The problem when you are not a team working 
full time on a project is that sometimes I end up with some limited time 
allocated to contributing and I can't wait async.  I'll take a look today to 
the model store you propose and let you know my feedback here, super happy to 
switch to it and avoid duplication if it's fit for purpose!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to