Re: [PR] WIP: Benchmark Jetty 12 & 11 [solr]

2024-10-21 Thread via GitHub
iamsanjay commented on PR #2782: URL: https://github.com/apache/solr/pull/2782#issuecomment-2428312414 Almost worked on Jetty 12! Though few test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] WIP: Benchmark Jetty 11 [solr]

2024-10-21 Thread via GitHub
iamsanjay commented on PR #2782: URL: https://github.com/apache/solr/pull/2782#issuecomment-2428309505 ## Jetty 12 ``` Benchmark (nodeCount) (numReplicas) (numShards) (preGenerate) (useSmallDocs) Mode Cnt Score Error Units CloudIndexing.indexDoc

[jira] [Commented] (SOLR-17510) CBOR, SolrJ compatible

2024-10-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891718#comment-17891718 ] David Smiley commented on SOLR-17510: - I noticed that the CborLoader used Solr side t

[jira] [Commented] (SOLR-16812) Support CBOR format for update/query

2024-10-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891711#comment-17891711 ] David Smiley commented on SOLR-16812: - Let's take this line of discussion to SOLR-175

Re: [PR] Adding Powershell snippets to Five Minutes Tutorial [solr]

2024-10-21 Thread via GitHub
github-actions[bot] commented on PR #2482: URL: https://github.com/apache/solr/pull/2482#issuecomment-2427947900 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be fam

[jira] [Updated] (SOLR-17417) Authentication bypass possible using a fake :/admin/info/key URL Path ending

2024-10-21 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-17417: -- Security: (was: Private (Security Issue)) > Authentication bypass possible using a fake :/a

[jira] [Updated] (SOLR-17418) ConfigSets created during a backup Restore command are trusted implicitly

2024-10-21 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-17418: -- Security: (was: Private (Security Issue)) > ConfigSets created during a backup Restore comm

Re: [PR] Resolve CLI tool issues for hostContext "/" [solr]

2024-10-21 Thread via GitHub
epugh commented on PR #2787: URL: https://github.com/apache/solr/pull/2787#issuecomment-2427694306 Should this PR be marked "Ready for Review" versus Draft? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (SOLR-17505) Revamp "Launch Solr in SolrCloud Mode" in tutorial 0 to remove -c

2024-10-21 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17505. -- Fix Version/s: main (10.0) Resolution: Fixed > Revamp "Launch Solr in SolrCloud Mode" in tutoria

[jira] [Commented] (SOLR-17505) Revamp "Launch Solr in SolrCloud Mode" in tutorial 0 to remove -c

2024-10-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891662#comment-17891662 ] ASF subversion and git services commented on SOLR-17505: Commit 1

Re: [PR] SOLR-17505: Revamp tutorials in Ref Guide to deemphasize SolrCloud since it's just default mode. [solr]

2024-10-21 Thread via GitHub
epugh merged PR #2779: URL: https://github.com/apache/solr/pull/2779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17505) Revamp "Launch Solr in SolrCloud Mode" in tutorial 0 to remove -c

2024-10-21 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891660#comment-17891660 ] Eric Pugh commented on SOLR-17505: -- I think these have been sorted! > Revamp "Launch So

Re: [PR] SOLR-17494: Remove language specific writer types [solr]

2024-10-21 Thread via GitHub
epugh merged PR #2758: URL: https://github.com/apache/solr/pull/2758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17494) Remove client language specific wt formats

2024-10-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891655#comment-17891655 ] ASF subversion and git services commented on SOLR-17494: Commit 0

[jira] [Resolved] (SOLR-17494) Remove client language specific wt formats

2024-10-21 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17494. -- Fix Version/s: main (10.0) Assignee: Eric Pugh Resolution: Fixed > Remove client langua

Re: [PR] SOLR-17467: Update docs to reflect SolrCloud is now default mode. [solr]

2024-10-21 Thread via GitHub
epugh merged PR #2780: URL: https://github.com/apache/solr/pull/2780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17467: Fix Windows start script for default / cloud mode [solr]

2024-10-21 Thread via GitHub
epugh commented on PR #2784: URL: https://github.com/apache/solr/pull/2784#issuecomment-2427562336 @malliaridis if you want me to merge and backport, I can, but now that you are a committer -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] SOLR-17467: Fix Windows start script for default / cloud mode [solr]

2024-10-21 Thread via GitHub
epugh commented on PR #2784: URL: https://github.com/apache/solr/pull/2784#issuecomment-2427520573 i think, in a future ticket, we can probably prune some more of the logic in `.cmd`, however lets save that for another day. I think this is ready to be merged. Having said that, @rah

[jira] [Commented] (SOLR-17467) Start solr in Cloud mode, introduce --standalone switch for Standalone mode

2024-10-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891642#comment-17891642 ] ASF subversion and git services commented on SOLR-17467: Commit 3

Re: [PR] SOLR-17467: Finish migration to --user-managed mode [solr]

2024-10-21 Thread via GitHub
epugh merged PR #2781: URL: https://github.com/apache/solr/pull/2781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Updated] (SOLR-17503) Umbrella: Move to Jakarta J2EE packages

2024-10-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-17503: Security: (was: Public) > Umbrella: Move to Jakarta J2EE packages > ---

Re: [PR] SOLR-17467: Fix Windows start script for default / cloud mode [solr]

2024-10-21 Thread via GitHub
malliaridis commented on PR #2784: URL: https://github.com/apache/solr/pull/2784#issuecomment-2427296307 This is what I cannot understand. Apparently it is passed as another parameter, but I can't find the place where. It looks like there is some wildcard like `%2` in the script that passes

Re: [PR] SOLR-17504: CoreContainer calls UpdateHandler.commit. [solr]

2024-10-21 Thread via GitHub
dsmiley commented on code in PR #2786: URL: https://github.com/apache/solr/pull/2786#discussion_r1809193371 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2061,13 +2066,16 @@ public void reload(String name, UUID coreId) { RefCounted iwRef = cor

Re: [PR] SOLR-17504: CoreContainer calls UpdateHandler.commit. [solr]

2024-10-21 Thread via GitHub
dsmiley commented on code in PR #2786: URL: https://github.com/apache/solr/pull/2786#discussion_r1809171399 ## solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java: ## @@ -971,8 +971,10 @@ public void closeWriter(IndexWriter writer) throws IOException {

Re: [PR] SOLR-17504: CoreContainer calls UpdateHandler.commit. [solr]

2024-10-21 Thread via GitHub
dsmiley commented on code in PR #2786: URL: https://github.com/apache/solr/pull/2786#discussion_r1809192524 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2061,13 +2066,16 @@ public void reload(String name, UUID coreId) { RefCounted iwRef = cor

Re: [PR] SOLR-17467: Fix Windows start script for default / cloud mode [solr]

2024-10-21 Thread via GitHub
epugh commented on PR #2784: URL: https://github.com/apache/solr/pull/2784#issuecomment-2427221030 Can you confirm that if you call it with `--user-managed` you get non cloud mode to work? I don't quite see how that happens... (If it does great!). Does the --user-managed just get passe

Re: [PR] Replace CloudLegacySolrClient with CloudHttp2SolrClient in SolrClientCloudManager [solr]

2024-10-21 Thread via GitHub
dsmiley commented on code in PR #2751: URL: https://github.com/apache/solr/pull/2751#discussion_r1809154494 ## solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java: ## @@ -290,15 +290,15 @@ public SimpleSolrResponse invoke(String solrN

Re: [PR] SOLR-17450 StatusTool with pure Java code (backport 9x) [solr]

2024-10-21 Thread via GitHub
epugh commented on code in PR #2785: URL: https://github.com/apache/solr/pull/2785#discussion_r1809151984 ## solr/packaging/test/test_status.bats: ## @@ -33,9 +33,36 @@ teardown() { assert_output --partial "No Solr nodes are running." run solr start run solr status - a

Re: [PR] SOLR-16390: v2 Cluster Property APIs. [solr]

2024-10-21 Thread via GitHub
cugarte commented on PR #2788: URL: https://github.com/apache/solr/pull/2788#issuecomment-2427176509 1. Leaving this PR in Draft mode to get feedback on APIs/responses and so I can provide the missing unit tests and update documentation. 2. Each API consist of two separate classes in `sol

Re: [PR] Resolve AssertTool issues for hostContext "/" [solr]

2024-10-21 Thread via GitHub
malliaridis commented on PR #2787: URL: https://github.com/apache/solr/pull/2787#issuecomment-2427175185 @janhoy I had to override the system property for `hostContext` to run into test failures, but I am not sure if this just executed a different execution path. If you have the time to che

[jira] [Updated] (SOLR-16390) Cosmetic improvements and migration to JAX-RS (v2 cluster and clusterprop APIs)

2024-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-16390: -- Labels: newdev pull-request-available (was: newdev) > Cosmetic improvements and migration to J

Re: [PR] SOLR-16390: v2 Cluster Property APIs. [solr]

2024-10-21 Thread via GitHub
cugarte commented on PR #2788: URL: https://github.com/apache/solr/pull/2788#issuecomment-2427174454 List ClusterProps sample response: ``` { "responseHeader": { "status": 0, "QTime": 14 }, "clusterProperties": [ "urlScheme", "defaults" ]

[PR] SOLR-16390: v2 Cluster Property APIs. [solr]

2024-10-21 Thread via GitHub
cugarte opened a new pull request, #2788: URL: https://github.com/apache/solr/pull/2788 https://issues.apache.org/jira/browse/SOLR-16390 # Description v2 (JAX-RS) endpoints for Cluster Property operations. # Solution This commit adds the following v2 JA

Re: [PR] Fix assert tool url normalization [solr]

2024-10-21 Thread via GitHub
epugh commented on PR #2778: URL: https://github.com/apache/solr/pull/2778#issuecomment-2427166378 Of the two URI builders, I think we would want the jakarta since at some point Apache HTTP Client goes away. What about just looking for `//` and removing one of them? In the 9x line

[PR] Resolve AssertTool issues for hostContext "/" [solr]

2024-10-21 Thread via GitHub
malliaridis opened a new pull request, #2787: URL: https://github.com/apache/solr/pull/2787 # Description This is the continuation of #2778, as it seems there are some special cases that cause URL parsing issues. # Solution The changes leverage jakarta's `UriBuilder` to

Re: [PR] Replace CloudLegacySolrClient with CloudHttp2SolrClient in SolrClientCloudManager [solr]

2024-10-21 Thread via GitHub
epugh commented on code in PR #2751: URL: https://github.com/apache/solr/pull/2751#discussion_r1809127933 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -199,6 +200,9 @@ public String toString() { public final ZkStateReader zkStateReader; private Solr

Re: [PR] Transfer encryption metadata in the commit when DirectUpdateHandler2.closeWriter is called. [solr-sandbox]

2024-10-21 Thread via GitHub
bruno-roustant commented on PR #113: URL: https://github.com/apache/solr-sandbox/pull/113#issuecomment-2427053387 I created a [PR](https://github.com/apache/solr/pull/2786) upstream to fix this. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]

2024-10-21 Thread via GitHub
mkhludnev commented on code in PR #2742: URL: https://github.com/apache/solr/pull/2742#discussion_r1809062687 ## solr/core/src/java/org/apache/solr/search/facet/FacetParser.java: ## @@ -138,21 +139,30 @@ public Object parseFacetOrStat(String key, Object o) throws SyntaxError {

[jira] [Assigned] (SOLR-17504) CoreContainer calls UpdateHandler.commit

2024-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant reassigned SOLR-17504: - Assignee: Bruno Roustant > CoreContainer calls UpdateHandler.commit > --

[jira] [Updated] (SOLR-17504) CoreContainer calls UpdateHandler.commit

2024-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated SOLR-17504: -- Description: ... and DirectUpdateHandler2.closeWriter supports commit metadata. This proposal

[jira] [Updated] (SOLR-17504) CoreContainer calls UpdateHandler.commit

2024-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17504: -- Labels: pull-request-available (was: ) > CoreContainer calls UpdateHandler.commit > --

[jira] [Updated] (SOLR-17504) CoreContainer calls UpdateHandler.commit

2024-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated SOLR-17504: -- Summary: CoreContainer calls UpdateHandler.commit (was: DirectUpdateHandler2.closeWriter suppo

[jira] [Commented] (SOLR-16812) Support CBOR format for update/query

2024-10-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891553#comment-17891553 ] David Smiley commented on SOLR-16812: - This issue introduced partial support for CBOR

Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]

2024-10-21 Thread via GitHub
mkhludnev commented on code in PR #2742: URL: https://github.com/apache/solr/pull/2742#discussion_r1808839272 ## solr/core/src/java/org/apache/solr/search/facet/FacetParser.java: ## @@ -138,21 +139,30 @@ public Object parseFacetOrStat(String key, Object o) throws SyntaxError {

Re: [PR] Fix assert tool url normalization [solr]

2024-10-21 Thread via GitHub
malliaridis commented on PR #2778: URL: https://github.com/apache/solr/pull/2778#issuecomment-2426569848 @janhoy For some reason I am not surprised. I guess a `hostContext` that contains only `/` may be valid from the user's perspective, but we cannot handle it without additional workaround

Re: [PR] Fix assert tool url normalization [solr]

2024-10-21 Thread via GitHub
janhoy commented on PR #2778: URL: https://github.com/apache/solr/pull/2778#issuecomment-2426267830 @epugh, @malliaridis Turns out this still fails half the time, when `hostContext` is set to `/`. I can reproduce locally, about half the runs. See https://github.com/apache/solr/blob/b

[jira] [Created] (SOLR-17509) Collection Backup: Invalid status request

2024-10-21 Thread Jira
Hakan Özler created SOLR-17509: -- Summary: Collection Backup: Invalid status request Key: SOLR-17509 URL: https://issues.apache.org/jira/browse/SOLR-17509 Project: Solr Issue Type: Bug Secu

Re: [PR] SOLR-17444: Add Passage Sorting Option in UnifiedSolrHighlighter [solr]

2024-10-21 Thread via GitHub
Seunghan-Jung commented on PR #2697: URL: https://github.com/apache/solr/pull/2697#issuecomment-2426218449 @dsmiley I believe the PR I worked on to fix a bug (https://github.com/apache/lucene/pull/13832) is for Lucene version 10. I thought it would be merged before Solr version 10. --

Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]

2024-10-21 Thread via GitHub
timatbw commented on code in PR #2742: URL: https://github.com/apache/solr/pull/2742#discussion_r1808371247 ## solr/core/src/java/org/apache/solr/search/facet/FacetParser.java: ## @@ -138,21 +139,30 @@ public Object parseFacetOrStat(String key, Object o) throws SyntaxError {

Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]

2024-10-21 Thread via GitHub
timatbw commented on code in PR #2742: URL: https://github.com/apache/solr/pull/2742#discussion_r1808367008 ## solr/core/src/java/org/apache/solr/search/facet/FacetParser.java: ## @@ -138,21 +139,30 @@ public Object parseFacetOrStat(String key, Object o) throws SyntaxError {

Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]

2024-10-21 Thread via GitHub
timatbw commented on code in PR #2742: URL: https://github.com/apache/solr/pull/2742#discussion_r1808365601 ## solr/core/src/java/org/apache/solr/search/facet/FacetParser.java: ## @@ -138,21 +139,30 @@ public Object parseFacetOrStat(String key, Object o) throws SyntaxError {