cugarte commented on PR #2788:
URL: https://github.com/apache/solr/pull/2788#issuecomment-2427176509
1. Leaving this PR in Draft mode to get feedback on APIs/responses and so I
can provide the missing unit tests and update documentation.
2. Each API consist of two separate classes in `solr/api/.../endpoint` and
`solr/core/.../handler/admin/api` (with some supporting POJO classes in
`solr/api/.../model`). I wasn't sure if that would be preferred over grouping
them all together as was done with `AliasPropertyApis`/`AliasProperty`.
3. The new v2 JAX-RS Bulk Update ClusterProp API requires providing a body
that looks like `{"properties":{"actualPropertyToBeUpdated":...}}` because I
didn't know how to map an unknown top-level value to data in the model
(`SetNestedClusterPropertyRequestBody`).
4. The Bulk Update ClusterProp APIs (old and new) allows setting "invalid"
properties (i.e. ones that cannot be deleted by old APIs). Should this be
allowed? If so, perhaps delete should be changed to not check that these names
are on the allowed list.
Known TODOs:
1. Add test code for List and Fetch ClusterProps.
2. Update documentation and CHANGES.txt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
