Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-25 Thread via GitHub
janhoy commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1776447879 ## solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java: ## @@ -80,6 +94,39 @@ public HttpShardHandler(HttpShardHandlerFactory httpShardHandlerFactor

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-25 Thread via GitHub
janhoy commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1776427386 ## solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java: ## @@ -80,6 +94,39 @@ public HttpShardHandler(HttpShardHandlerFactory httpShardHandlerFactor

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-25 Thread via GitHub
dsmiley commented on PR #2689: URL: https://github.com/apache/solr/pull/2689#issuecomment-2375837529 I'm in favor of a CoreContainer.newHttpSolrClient(String url) method that the caller should close and that which uses a common underlying HttpClient instance / connection-pool underneath.

Re: [PR] Introduce support for Reciprocal Rank Fusion (combining queries) [solr]

2024-09-25 Thread via GitHub
github-actions[bot] commented on PR #2489: URL: https://github.com/apache/solr/pull/2489#issuecomment-2375471479 This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please t

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-25 Thread via GitHub
gus-asf commented on PR #2666: URL: https://github.com/apache/solr/pull/2666#issuecomment-2375174745 This is now feeling complete, I'll be looking to commit it tomorrow afternoon or perhaps Friday morning to main if nobody objects or requests more time to review. I've had to back of

Re: [PR] SOLR-17441 MetricUtils: Skip Unreadable Properties [solr]

2024-09-25 Thread via GitHub
dsmiley commented on code in PR #2694: URL: https://github.com/apache/solr/pull/2694#discussion_r1775906018 ## solr/core/src/java/org/apache/solr/util/stats/MetricUtils.java: ## @@ -787,10 +787,16 @@ public static void addMXBeanMetrics( } });

[jira] [Commented] (SOLR-17441) MetricUtils optimization: skip unreadable properties

2024-09-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884757#comment-17884757 ] David Smiley commented on SOLR-17441: - It's be useful to communicate in the descripti

[jira] [Updated] (SOLR-17441) MetricUtils optimization: skip unreadable properties

2024-09-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17441: Summary: MetricUtils optimization: skip unreadable properties (was: Skip Unreadable Properties Ear

[jira] [Commented] (SOLR-6122) API to cancel an already submitted/running Collections API call

2024-09-25 Thread Yuntong Qu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884755#comment-17884755 ] Yuntong Qu commented on SOLR-6122: -- I've looked into the flow for Collections API going t

[jira] [Closed] (SOLR-17168) Netty epoll implementation not included in 8.11.3

2024-09-25 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman closed SOLR-17168. - > Netty epoll implementation not included in 8.11.3 > ---

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-25 Thread via GitHub
gerlowskija commented on PR #2689: URL: https://github.com/apache/solr/pull/2689#issuecomment-2375060453 All the approaches have downsides for sure, but for me personally, object allocation and the 'Closeable'-burden seem like the lesser evils. > unnecessary object creation "Cl

[jira] [Updated] (SOLR-17462) Invalid Status Request Error During Restoration

2024-09-25 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hakan Özler updated SOLR-17462: --- Description: We're unable to restore a S3 backup taken from 9.6.1 to 9.7.0. There are no helpful log

[jira] [Updated] (SOLR-17462) Invalid Status Request Error During Restoration

2024-09-25 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hakan Özler updated SOLR-17462: --- Description: We're unable to restore a S3 backup taken from 9.6.1 to 9.7.0. There are no helpful log

[jira] [Updated] (SOLR-17462) Invalid Status Request Error During Restoration

2024-09-25 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hakan Özler updated SOLR-17462: --- Description: We're unable to restore a S3 backup taken from 9.6.1 to 9.7.0. There are no helpful log

[jira] [Updated] (SOLR-17462) Invalid Status Request Error During Restoration

2024-09-25 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hakan Özler updated SOLR-17462: --- Attachment: logs.png > Invalid Status Request Error During Restoration >

[jira] [Created] (SOLR-17462) Invalid Status Request Error During Restoration

2024-09-25 Thread Jira
Hakan Özler created SOLR-17462: -- Summary: Invalid Status Request Error During Restoration Key: SOLR-17462 URL: https://issues.apache.org/jira/browse/SOLR-17462 Project: Solr Issue Type: Bug

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-25 Thread via GitHub
iamsanjay commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1775604953 ## solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-25 Thread via GitHub
iamsanjay commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1775595008 ## solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-25 Thread via GitHub
iamsanjay commented on PR #2689: URL: https://github.com/apache/solr/pull/2689#issuecomment-2374579550 > Wdyt about saving `getDefaultHttpClient()` take in a baseUrl, so that the returned instance can take advantage of all SolrClient methods "out of the box"? > > (Also - am I missing

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-25 Thread via GitHub
gus-asf commented on PR #2666: URL: https://github.com/apache/solr/pull/2666#issuecomment-2374545882 Also, I've decided to presume that the failure to call transform in the ParallelHttpShardHandler was an oversight. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-25 Thread via GitHub
gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1775211297 ## solr/core/src/java/org/apache/solr/handler/component/ParallelHttpShardHandler.java: ## @@ -45,53 +48,84 @@ public class ParallelHttpShardHandler extends HttpShardHandl

[jira] [Commented] (SOLR-16503) Switch UpdateShardHandler.getDefaultHttpClient to Jetty HTTP2

2024-09-25 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884653#comment-17884653 ] Jason Gerlowski commented on SOLR-16503: Ah yikes - I missed the PR links in this

Re: [PR] SOLR-17150: Create MemAllowedLimit [solr]

2024-09-25 Thread via GitHub
gus-asf commented on code in PR #2708: URL: https://github.com/apache/solr/pull/2708#discussion_r1775480324 ## solr/core/src/java/org/apache/solr/search/MemAllowedLimit.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-25 Thread via GitHub
gerlowskija commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1775500138 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi return this.distributedCo

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-25 Thread via GitHub
gerlowskija commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1775285594 ## solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-09-25 Thread via GitHub
malliaridis commented on code in PR #2706: URL: https://github.com/apache/solr/pull/2706#discussion_r1775253658 ## help/dependencies.txt: ## @@ -29,60 +29,126 @@ testImplementation - makes a dependency only available for test classes. Adding a library dependency

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-09-25 Thread via GitHub
dweiss commented on code in PR #2706: URL: https://github.com/apache/solr/pull/2706#discussion_r1775243765 ## gradle/libs.versions.toml: ## @@ -0,0 +1,432 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-09-25 Thread via GitHub
malliaridis commented on code in PR #2706: URL: https://github.com/apache/solr/pull/2706#discussion_r1775243589 ## gradle/libs.versions.toml: ## @@ -0,0 +1,432 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NO

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-09-25 Thread via GitHub
malliaridis commented on code in PR #2706: URL: https://github.com/apache/solr/pull/2706#discussion_r1775234820 ## build.gradle: ## @@ -139,7 +143,7 @@ apply from: file('gradle/maven/defaults-maven.gradle') // IDE support, settings and specials. apply from: file('gradle/ide/

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-09-25 Thread via GitHub
janhoy commented on code in PR #2706: URL: https://github.com/apache/solr/pull/2706#discussion_r1775192261 ## gradle/libs.versions.toml: ## @@ -0,0 +1,432 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-09-25 Thread via GitHub
dweiss commented on code in PR #2706: URL: https://github.com/apache/solr/pull/2706#discussion_r1775139816 ## help/dependencies.txt: ## @@ -29,60 +29,126 @@ testImplementation - makes a dependency only available for test classes. Adding a library dependency -

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-09-25 Thread via GitHub
malliaridis commented on code in PR #2706: URL: https://github.com/apache/solr/pull/2706#discussion_r1775109063 ## build.gradle: ## @@ -139,7 +143,7 @@ apply from: file('gradle/maven/defaults-maven.gradle') // IDE support, settings and specials. apply from: file('gradle/ide/

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-09-25 Thread via GitHub
malliaridis commented on code in PR #2706: URL: https://github.com/apache/solr/pull/2706#discussion_r1775107083 ## help/dependencies.txt: ## @@ -29,60 +29,126 @@ testImplementation - makes a dependency only available for test classes. Adding a library dependency

Re: [PR] SOLR-17442: Resolve -v flag conflict (version, value, verbose) [solr]

2024-09-25 Thread via GitHub
malliaridis commented on code in PR #2721: URL: https://github.com/apache/solr/pull/2721#discussion_r1775057041 ## solr/bin/solr.cmd: ## @@ -362,23 +362,21 @@ goto done @echo. @echo --no-prompt Don't prompt for input; accept all defaults when running examples that accept

Re: [PR] SOLR-17442: Resolve -v flag conflict (version, value, verbose) [solr]

2024-09-25 Thread via GitHub
malliaridis commented on code in PR #2721: URL: https://github.com/apache/solr/pull/2721#discussion_r1772832218 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -308,7 +326,8 @@ protected static void checkSslStoreSysProp(String solrInstallDir, String key) { }

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-09-25 Thread via GitHub
dweiss commented on code in PR #2706: URL: https://github.com/apache/solr/pull/2706#discussion_r1775026121 ## gradle/libs.versions.toml: ## @@ -0,0 +1,432 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-25 Thread via GitHub
sigram commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1774987714 ## solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc: ## @@ -324,9 +324,20 @@ The default value of this parameter is blank, which causes no extra

Re: [I] Getting unauthorized requests for cluster/replicas/balance in v0.8.0 [solr-operator]

2024-09-25 Thread via GitHub
bcbrockway commented on issue #653: URL: https://github.com/apache/solr-operator/issues/653#issuecomment-2373708815 Is there a workaround for this? We're getting the same error after starting up a brand new cluster. -- This is an automated message from the Apache Git Service. To respond t