dsmiley commented on PR #2463:
URL: https://github.com/apache/solr/pull/2463#issuecomment-2113480275
Can you please update CHANGES.txt under 9.6.1 bug fix, maybe say:
> SOLR-17275: SolrJ ZkClientClusterStateProvider, revert SOLR-17153 for
regression when aliases are used. (your name)
-
[
https://issues.apache.org/jira/browse/SOLR-17275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846758#comment-17846758
]
David Smiley commented on SOLR-17275:
-
I'll merge the change tomorrow morning to ensu
mlbiscoc commented on PR #2405:
URL: https://github.com/apache/solr/pull/2405#issuecomment-2113445818
@dsmiley or anyone else interested in reviewing. Was curious for more
feedback on approach. Is this going in the correct direction or do some
disagree if this is correct implementation path
[
https://issues.apache.org/jira/browse/SOLR-17275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846729#comment-17846729
]
Aparna Suresh edited comment on SOLR-17275 at 5/15/24 6:53 PM:
dsmiley commented on PR #2463:
URL: https://github.com/apache/solr/pull/2463#issuecomment-2113240161
+1 for reverting this piece. I think we'll come back to it later when we
have more time to reconsider it. I strongly suspected the root cause was an
extra ZK interaction but your testing &
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1602087557
##
solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateRequestProcessor.java:
##
@@ -0,0 +1,257 @@
+/*
+ *
+ * * Licensed to the Apache Software Fo
[
https://issues.apache.org/jira/browse/SOLR-17275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846729#comment-17846729
]
Aparna Suresh commented on SOLR-17275:
--
I have reverted the change on the client sid
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1602065616
##
solr/modules/monitor/src/java/org/apache/lucene/monitor/MonitorFields.java:
##
@@ -0,0 +1,38 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF) under o
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1602065616
##
solr/modules/monitor/src/java/org/apache/lucene/monitor/MonitorFields.java:
##
@@ -0,0 +1,38 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF) under o
aparnasuresh85 opened a new pull request, #2463:
URL: https://github.com/apache/solr/pull/2463
https://issues.apache.org/jira/browse/SOLR-17275
# Description
A recent change, as part of SOLR-17153 to ZkClusterStateProvider caused
CloudSolrClient (zk based) to force
dsmiley commented on code in PR #2160:
URL: https://github.com/apache/solr/pull/2160#discussion_r1601881299
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java:
##
@@ -480,35 +488,70 @@ public RequestWriter getRequestWriter() {
return requestWriter;
[
https://issues.apache.org/jira/browse/SOLR-14673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846679#comment-17846679
]
Eric Pugh commented on SOLR-14673:
--
I am poking around at the patch file to see if I can
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1601740654
##
solr/modules/monitor/src/java/org/apache/lucene/monitor/MonitorFields.java:
##
@@ -0,0 +1,38 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF) under
epugh commented on code in PR #2160:
URL: https://github.com/apache/solr/pull/2160#discussion_r1601674762
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##
@@ -281,6 +298,37 @@ public LBHttp2SolrClient.Builder setAliveCheckInterval(int
aliveChe
[
https://issues.apache.org/jira/browse/SOLR-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846638#comment-17846638
]
David Smiley commented on SOLR-17263:
-
I'm a bit confused by all these PRs but I merg
dsmiley commented on PR #2160:
URL: https://github.com/apache/solr/pull/2160#issuecomment-2112567149
Aparna, are we just missing use of EnvUtils here? I know we've taken this
change as-is (in our fork) but even we don't have that, thus it's hard to
actually _use_ the changes configured her
[
https://issues.apache.org/jira/browse/SOLR-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846634#comment-17846634
]
ASF subversion and git services commented on SOLR-17263:
Commit a
epugh commented on PR #2172:
URL: https://github.com/apache/solr/pull/2172#issuecomment-2112502657
> I'm fine with merging this. @janhoy's comment is valid though, it would
cause issues if `solr.sharedLib` has more than one directory
do you want me to do it? Or I can leave it up to
iamsanjay opened a new pull request, #2462:
URL: https://github.com/apache/solr/pull/2462
https://issues.apache.org/jira/browse/SOLR-16505
As previously noticed that whenever we re-create Solr client using existing
`Http2SolrClient` then no listeners were passed to the new `Ht
tflobbe commented on PR #2172:
URL: https://github.com/apache/solr/pull/2172#issuecomment-2112460299
I'm fine with merging this. @janhoy's comment is valid though, it would
cause issues if `solr.sharedLib` has more than one directory
--
This is an automated message from the Apache Git Ser
[
https://issues.apache.org/jira/browse/SOLR-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846620#comment-17846620
]
ASF subversion and git services commented on SOLR-17263:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846619#comment-17846619
]
ASF subversion and git services commented on SOLR-17263:
Commit 4
dsmiley merged PR #2433:
URL: https://github.com/apache/solr/pull/2433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
epugh commented on PR #2172:
URL: https://github.com/apache/solr/pull/2172#issuecomment-2112425839
Also, @dsmiley looks like you approved this change, can we go ahead and get
it merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
epugh commented on PR #2172:
URL: https://github.com/apache/solr/pull/2172#issuecomment-2112421629
Can someone explain the future of security manager in Java to me? My
understanding is that it is going away (and no replacement??)... So, wouldn't
it be better just to deprecate the securi
[
https://issues.apache.org/jira/browse/SOLR-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reopened SOLR-16505:
-
Assignee: David Smiley
> Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2
> -
epugh commented on PR #2460:
URL: https://github.com/apache/solr/pull/2460#issuecomment-2112418592
Would love some thoughts on how we could handle the auth scenarios better
without having to write an explicit test for it on every piece of code, once
with auth and once with out ;-)
--
Thi
iamsanjay commented on PR #2460:
URL: https://github.com/apache/solr/pull/2460#issuecomment-2112288509
> +1; will merge tomorrow.
>
> > The solr client is being used for REQUESTRECOVERY and did not seem to
need the auth for that.
>
> Maybe you know something I don't here; what
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1601387931
##
solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateRequestProcessor.java:
##
@@ -0,0 +1,257 @@
+/*
+ *
+ * * Licensed to the Apache Software
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1601379272
##
solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateRequestProcessor.java:
##
@@ -0,0 +1,257 @@
+/*
+ *
+ * * Licensed to the Apache Software
perosb opened a new issue, #705:
URL: https://github.com/apache/solr-operator/issues/705
Solr 8.11 seem to be producing duplicate metrics which is flooding the logs
and triggering alerts.
This is only when using latest prometheus v2.52.0. Related
https://github.com/prometheus/prometh
31 matches
Mail list logo
