iamsanjay opened a new pull request, #2462: URL: https://github.com/apache/solr/pull/2462
https://issues.apache.org/jira/browse/SOLR-16505 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> As previously noticed that whenever we re-create Solr client using existing `Http2SolrClient` then no listeners were passed to the new `Http2SolrClient` object. To fix this, a new code(`withListenerFactory` method in `Http2SolrClient#Builder` class) is added to previous commit for SOLR_16505. However, It did not called this new method for client in RecoveryStrategy. Therefore all the calls that were made from RecoveryStrategy were failing in case if auth is enabled. # Tests A new test case is added to configure SolrCloud with a security.json file. A specific test condition is tested where after indexing good amount of document, a new replica is added which would trigger RecoveryStrategy for it and everything is happening when auth is enabled. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [x] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
