Re: [PR] SOLR-17220 - Make the SolrZkClient thread as a daemon thread [solr]

2024-03-31 Thread via GitHub
amanraj2520 commented on PR #2376: URL: https://github.com/apache/solr/pull/2376#issuecomment-2029135370 @murblanc @dsmiley So you mean that when the Spark driver JVM ends, Spark should actually call the SolrZkClient.close right? Should it be implemented using Shutdown Hooks? -- This is

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-03-31 Thread via GitHub
dsmiley commented on code in PR #2276: URL: https://github.com/apache/solr/pull/2276#discussion_r1545945449 ## solr/core/src/java/org/apache/solr/handler/IndexFetcher.java: ## @@ -261,22 +260,23 @@ public String getMessage() { } } - private static HttpClient createHtt

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached - Initial impl [solr]

2024-03-31 Thread via GitHub
gus-asf commented on code in PR #2379: URL: https://github.com/apache/solr/pull/2379#discussion_r1545939078 ## solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java: ## @@ -227,18 +243,27 @@ public ShardResponse takeCompletedOrError() { private ShardRes

Re: [PR] SOLR-17220 - Make the SolrZkClient thread as a daemon thread [solr]

2024-03-31 Thread via GitHub
amanraj2520 commented on PR #2376: URL: https://github.com/apache/solr/pull/2376#issuecomment-2029068292 Sure @murblanc @dsmiley Will check this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] Update org.apache.hadoop:* to v3.4.0 [solr]

2024-03-31 Thread via GitHub
solrbot opened a new pull request, #2380: URL: https://github.com/apache/solr/pull/2380 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | org.apache.hadoop:hadoop-minikdc | test | minor | `3.3.6` -> `3.4.0` | | org.apache.hadoop:h

Re: [PR] SOLR-17130: edismax-matchalldocs-optimization [solr]

2024-03-31 Thread via GitHub
epugh commented on PR #2218: URL: https://github.com/apache/solr/pull/2218#issuecomment-2028961401 Seems like this could be merged? I'm happy to do it if you'all would like me to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] SOLR-17130: edismax-matchalldocs-optimization [solr]

2024-03-31 Thread via GitHub
github-actions[bot] commented on PR #2218: URL: https://github.com/apache/solr/pull/2218#issuecomment-2028955074 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t