Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-02-22 Thread via GitHub
dsmiley commented on code in PR #2259: URL: https://github.com/apache/solr/pull/2259#discussion_r1500124827 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java: ## @@ -188,33 +210,52 @@ private HttpResponse doPutOrPost( } HttpRequest.BodyP

Re: [PR] SOLR-17017: Reset the collection as part of running the example when starting Solr... [solr]

2024-02-22 Thread via GitHub
epugh commented on PR #2261: URL: https://github.com/apache/solr/pull/2261#issuecomment-1960580515 Ugh. Not sure why bats isn't working, as this does work: ``` ./solr start -e films -c ./solr assert --started http://localhost:8983/solr --timeout 5000 ./solr delete -c films

Re: [PR] SOLR-15689: add PeerSyncTest.missedUpdatesFinderTests() [solr]

2024-02-22 Thread via GitHub
github-actions[bot] commented on PR #343: URL: https://github.com/apache/solr/pull/343#issuecomment-1960535245 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-15760: Improve the default distributed facet overrequest function/heuristic [solr]

2024-02-22 Thread via GitHub
github-actions[bot] commented on PR #385: URL: https://github.com/apache/solr/pull/385#issuecomment-1960535224 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-15561: Write escaped strings in JsonTextWriter to a StringBuilder before the writer. [solr]

2024-02-22 Thread via GitHub
github-actions[bot] commented on PR #387: URL: https://github.com/apache/solr/pull/387#issuecomment-1960535199 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-15625 Improve documentation for the benchmark module. [solr]

2024-02-22 Thread via GitHub
github-actions[bot] commented on PR #406: URL: https://github.com/apache/solr/pull/406#issuecomment-1960535169 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-14410: switch from SysV to systemd service [solr]

2024-02-22 Thread via GitHub
github-actions[bot] commented on PR #428: URL: https://github.com/apache/solr/pull/428#issuecomment-1960535145 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-15829: IllegalStateException when using Managed resources (e.g. ManagedSynonymGraphFilterFactory) [solr]

2024-02-22 Thread via GitHub
github-actions[bot] commented on PR #440: URL: https://github.com/apache/solr/pull/440#issuecomment-1960535117 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-15836: Address counterintuitive behavior of JSON "terms" subfacet refinement [solr]

2024-02-22 Thread via GitHub
github-actions[bot] commented on PR #448: URL: https://github.com/apache/solr/pull/448#issuecomment-1960535093 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-02-22 Thread via GitHub
jdyer1 commented on code in PR #2259: URL: https://github.com/apache/solr/pull/2259#discussion_r1500030227 ## solr/solrj/src/java/org/apache/solr/client/solrj/embedded/SSLConfigBase.java: ## @@ -40,35 +52,75 @@ public SSLConfigBase( this.trustStorePassword = trustStorePassw

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-02-22 Thread via GitHub
jdyer1 commented on code in PR #2259: URL: https://github.com/apache/solr/pull/2259#discussion_r149852 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientJdkImpl.java: ## @@ -0,0 +1,443 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-02-22 Thread via GitHub
jdyer1 commented on code in PR #2259: URL: https://github.com/apache/solr/pull/2259#discussion_r146419 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java: ## @@ -24,7 +24,8 @@ import org.apache.solr.client.solrj.ResponseParser; import o

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-02-22 Thread via GitHub
jdyer1 commented on code in PR #2259: URL: https://github.com/apache/solr/pull/2259#discussion_r146594 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientTest.java: ## @@ -335,7 +327,7 @@ public void testCollectionParameters() throws IOException, SolrSe

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-02-22 Thread via GitHub
jdyer1 commented on code in PR #2259: URL: https://github.com/apache/solr/pull/2259#discussion_r146243 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClientBase.java: ## @@ -0,0 +1,385 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Updated] (SOLR-17176) Log history V2 API doesn't serialize properly

2024-02-22 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney updated SOLR-17176: -- Security: (was: Public) > Log history V2 API doesn't serialize properly > -

[jira] [Assigned] (SOLR-17176) Log history V2 API doesn't serialize properly

2024-02-22 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney reassigned SOLR-17176: - Assignee: Michael Gibney > Log history V2 API doesn't serialize properly > -

[jira] [Created] (SOLR-17176) Log history V2 API doesn't serialize properly

2024-02-22 Thread Michael Gibney (Jira)
Michael Gibney created SOLR-17176: - Summary: Log history V2 API doesn't serialize properly Key: SOLR-17176 URL: https://issues.apache.org/jira/browse/SOLR-17176 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-16466) Admin UI - Make it optional to sort list of commandline args

2024-02-22 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819798#comment-17819798 ] Shawn Heisey commented on SOLR-16466: - I indicated approval on the PR.  I will give i

[jira] [Commented] (SOLR-17017) Running an example using Solr start -e should be repeatable

2024-02-22 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819787#comment-17819787 ] Eric Pugh commented on SOLR-17017: -- [~kandreas] I spent a bunch of time trying to inline

[jira] [Commented] (SOLR-16466) Admin UI - Make it optional to sort list of commandline args

2024-02-22 Thread Vincenzo D'Amore (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819784#comment-17819784 ] Vincenzo D'Amore commented on SOLR-16466: - [~cpoerschke] It is a pity. [~elyogra

[jira] [Created] (SOLR-17175) Eliminate create_collection as a command in ref guide...

2024-02-22 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-17175: Summary: Eliminate create_collection as a command in ref guide... Key: SOLR-17175 URL: https://issues.apache.org/jira/browse/SOLR-17175 Project: Solr Issue Type: Sub

[jira] [Updated] (SOLR-17174) commit to mixedCase cli options or dashed-case cli options

2024-02-22 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-17174: - Parent Issue: SOLR-16757 (was: SOLR-17017) > commit to mixedCase cli options or dashed-case cli options

[jira] [Created] (SOLR-17174) commit to mixedCase cli options or dashed-case cli options

2024-02-22 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-17174: Summary: commit to mixedCase cli options or dashed-case cli options Key: SOLR-17174 URL: https://issues.apache.org/jira/browse/SOLR-17174 Project: Solr Issue Type: S

[jira] [Comment Edited] (SOLR-16466) Admin UI - Make it optional to sort list of commandline args

2024-02-22 Thread Vincenzo D'Amore (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816097#comment-17816097 ] Vincenzo D'Amore edited comment on SOLR-16466 at 2/22/24 4:37 PM: -

[jira] [Created] (SOLR-17173) Be explicit if distrib.statsCache=true but there's no statsCache configured or not?

2024-02-22 Thread Mikhail Khludnev (Jira)
Mikhail Khludnev created SOLR-17173: --- Summary: Be explicit if distrib.statsCache=true but there's no statsCache configured or not? Key: SOLR-17173 URL: https://issues.apache.org/jira/browse/SOLR-17173

[jira] [Commented] (SOLR-17164) Add 2 arg variant of vectorSimilarity() function

2024-02-22 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819616#comment-17819616 ] Sanjay Dutt commented on SOLR-17164: [~hossman] I took a stab at it using your code.

[PR] SOLR-17164: Add 2 arg variant of vectorSimilarity() function [solr]

2024-02-22 Thread via GitHub
iamsanjay opened a new pull request, #2292: URL: https://github.com/apache/solr/pull/2292 https://issues.apache.org/jira/browse/SOLR-17164 Introducing 2 arg variant of vectorSimilarity function query. **vectorSimilarity(vector1, vector2)** This function accepts two vector