Re: [PR] SOLR-16163: Review unintended try-with-resources closing-order modifications [solr]

2024-02-19 Thread via GitHub
github-actions[bot] commented on PR #818: URL: https://github.com/apache/solr/pull/818#issuecomment-1953292511 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-16046: fix thread leaks from non-blocking ZooKeeper.close() [solr]

2024-02-19 Thread via GitHub
github-actions[bot] commented on PR #842: URL: https://github.com/apache/solr/pull/842#issuecomment-1953292457 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-15857: Add Secret Manager support for ZK ACL credentials [solr]

2024-02-19 Thread via GitHub
github-actions[bot] commented on PR #826: URL: https://github.com/apache/solr/pull/826#issuecomment-1953292491 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-14699: Update Solr request logs to JSON format [solr]

2024-02-19 Thread via GitHub
github-actions[bot] commented on PR #882: URL: https://github.com/apache/solr/pull/882#issuecomment-1953292445 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-16260: Add support for Instant, LocalDate and ZonedDateTime to JavaBinCodec [solr]

2024-02-19 Thread via GitHub
github-actions[bot] commented on PR #913: URL: https://github.com/apache/solr/pull/913#issuecomment-1953292408 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-12457: improve compatibility/support for sort by field-function [solr]

2024-02-19 Thread via GitHub
github-actions[bot] commented on PR #828: URL: https://github.com/apache/solr/pull/828#issuecomment-1953292474 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-16243: Compile SQL to a Streaming Expression while visiting the … [solr]

2024-02-19 Thread via GitHub
github-actions[bot] commented on PR #899: URL: https://github.com/apache/solr/pull/899#issuecomment-1953292430 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-02-19 Thread via GitHub
dsmiley commented on code in PR #2276: URL: https://github.com/apache/solr/pull/2276#discussion_r1495075326 ## solr/core/src/test/org/apache/solr/cloud/RecoveryStrategyStressTest.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[jira] [Commented] (SOLR-7074) Simple script to start external Zookeeper

2024-02-19 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818591#comment-17818591 ] Eric Pugh commented on SOLR-7074: - I'd like to advocate for closing this ticket as "We won

[jira] [Resolved] (SOLR-7233) rename zkcli.sh script it clashes with zkCli.sh from ZooKeeper on Mac when both are in $PATH

2024-02-19 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-7233. - Resolution: Won't Fix Going to fix this by eliminating zkcli.sh in favour of the various bin/solr zk comm

[jira] [Resolved] (SOLR-17167) Move CreateCoreTool and CreateCollectionTool logic into CreateTool

2024-02-19 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17167. -- Resolution: Invalid Turns out we did this on main, and just never backported to branch_9x > Move Creat

[jira] [Created] (SOLR-17167) Move CreateCoreTool and CreateCollectionTool logic into CreateTool

2024-02-19 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-17167: Summary: Move CreateCoreTool and CreateCollectionTool logic into CreateTool Key: SOLR-17167 URL: https://issues.apache.org/jira/browse/SOLR-17167 Project: Solr Issu

Re: [PR] Prevent odd error from occasionally showing up. [solr]

2024-02-19 Thread via GitHub
epugh merged PR #2286: URL: https://github.com/apache/solr/pull/2286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17150: Create MemQueryLimit implementation [solr]

2024-02-19 Thread via GitHub
rajanim commented on code in PR #2251: URL: https://github.com/apache/solr/pull/2251#discussion_r1495063914 ## solr/core/src/test-files/solr/configsets/query-limits/conf/solrconfig.xml: ## @@ -0,0 +1,84 @@ + + + + + + + + ${tests.luceneMatchVersion:LATEST} + + + +${

[PR] Prevent odd error from occasionally showing up. [solr]

2024-02-19 Thread via GitHub
epugh opened a new pull request, #2286: URL: https://github.com/apache/solr/pull/2286 # Description Occasionally get a "PKIX" error in the test runs. # Solution Suppress SSL, like we do in many other unit tests. For a while I thought bin/solr post didnt' suppo

Re: [PR] Update required JTS version [solr]

2024-02-19 Thread via GitHub
dsmiley commented on PR #2273: URL: https://github.com/apache/solr/pull/2273#issuecomment-1953209892 If we ponder bundling JTS, I'd prefer to do such with a new "spatial-extras" Solr module for it to be included along with the subset of spatial field types that would use JTS. LatLonPointFi

Re: [PR] ReqSupplier interface not actually needed, so simplify code [solr]

2024-02-19 Thread via GitHub
epugh merged PR #2285: URL: https://github.com/apache/solr/pull/2285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-16957: Test user managed cluster with a twist! [solr]

2024-02-19 Thread via GitHub
epugh commented on code in PR #1875: URL: https://github.com/apache/solr/pull/1875#discussion_r1495007319 ## solr/packaging/test/test_replication.bats: ## @@ -0,0 +1,197 @@ +#!/usr/bin/env bats + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributo

Re: [PR] SOLR-16957: Test user managed cluster with a twist! [solr]

2024-02-19 Thread via GitHub
epugh commented on PR #1875: URL: https://github.com/apache/solr/pull/1875#issuecomment-1953146543 change SOLR_PORT to LEADER_PORT, REPEATER_PORT, FOLLOWER_PORT Also, could look up indexversion on leader, and then wait for it on repeater instead of sleep... -- This is an automat

[jira] [Commented] (SOLR-16995) Refactor replica types to make it easier to add new ones

2024-02-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818561#comment-17818561 ] ASF subversion and git services commented on SOLR-16995: Commit 2

Re: [PR] SOLR-16995: Configure replication behaviour for each replica type [solr]

2024-02-19 Thread via GitHub
murblanc merged PR #2207: URL: https://github.com/apache/solr/pull/2207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o

Re: [PR] SOLR-16995: Configure follower behaviour for each replica type [solr]

2024-02-19 Thread via GitHub
murblanc commented on code in PR #2203: URL: https://github.com/apache/solr/pull/2203#discussion_r1494802432 ## solr/core/src/java/org/apache/solr/handler/component/CloudReplicaSource.java: ## @@ -288,8 +287,8 @@ public Builder params(SolrParams params) { return this;

[jira] [Resolved] (SOLR-16564) Use constants instead of "collection1" in tests

2024-02-19 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16564. -- Resolution: Won't Fix Just not feeling that it really makes a difference... > Use constants instead of

Re: [PR] SOLR-16564: Migrate to using DEFAULT_TEST_COLLECTION_NAME constant through out tests [solr]

2024-02-19 Thread via GitHub
epugh closed pull request #1206: SOLR-16564: Migrate to using DEFAULT_TEST_COLLECTION_NAME constant through out tests URL: https://github.com/apache/solr/pull/1206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] SOLR-16564: Migrate to using DEFAULT_TEST_COLLECTION_NAME constant through out tests [solr]

2024-02-19 Thread via GitHub
epugh commented on PR #1206: URL: https://github.com/apache/solr/pull/1206#issuecomment-1953041663 Just not feeling it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] SOLR-17066: Switch "LB" clients away from core URLs [solr]

2024-02-19 Thread via GitHub
gerlowskija commented on PR #2283: URL: https://github.com/apache/solr/pull/2283#issuecomment-1952942344 **Question** Is this change worth the added complexity? I'm excited to move away from core URLs, but want to make sure the net effect is still positive given some of the complexity this

[PR] SOLR-17066: Switch "LB" clients away from core URLs [solr]

2024-02-19 Thread via GitHub
gerlowskija opened a new pull request, #2283: URL: https://github.com/apache/solr/pull/2283 https://issues.apache.org/jira/browse/SOLR-17066 # Description Bootstrapping Solr clients with core URLs has several downsides: it prevents the created client from making core-agnostic r

[jira] [Comment Edited] (SOLR-17156) BJQParserTest failure

2024-02-19 Thread Mikhail Khludnev (Jira)

[jira] [Commented] (SOLR-17159) Remove bin/post and bin/postlogs scripts and keep only bin/solr equivalents

2024-02-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818537#comment-17818537 ] ASF subversion and git services commented on SOLR-17159: Commit 8

[jira] [Commented] (SOLR-17147) To commit or not to commit? That is the question on bin/solr post

2024-02-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818538#comment-17818538 ] ASF subversion and git services commented on SOLR-17147: Commit 8

Re: [PR] DRAFT: Evaluate use of AbstractEmbeddedSolrServerTestCase [solr]

2024-02-19 Thread via GitHub
epugh commented on PR #1079: URL: https://github.com/apache/solr/pull/1079#issuecomment-1952879369 I think this was going in the wrong direction! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] DRAFT: Evaluate use of AbstractEmbeddedSolrServerTestCase [solr]

2024-02-19 Thread via GitHub
epugh closed pull request #1079: DRAFT: Evaluate use of AbstractEmbeddedSolrServerTestCase URL: https://github.com/apache/solr/pull/1079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (SOLR-17147) To commit or not to commit? That is the question on bin/solr post

2024-02-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818534#comment-17818534 ] ASF subversion and git services commented on SOLR-17147: Commit b

Re: [PR] SOLR-17159: Untangle PostTool and SimplePostTool code [solr]

2024-02-19 Thread via GitHub
epugh merged PR #2275: URL: https://github.com/apache/solr/pull/2275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-02-19 Thread via GitHub
cpoerschke commented on code in PR #2248: URL: https://github.com/apache/solr/pull/2248#discussion_r1494828204 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -2254,7 +2541,7 @@ protected void sortDocSet(QueryResult qr, QueryCommand cmd) throws IOExce

[PR] remove unused local variable in SolrIndexSearcher.sortDocSet [solr]

2024-02-19 Thread via GitHub
cpoerschke opened a new pull request, #2281: URL: https://github.com/apache/solr/pull/2281 unusedness spotted by @chatman in #2248 -- splitting out removal here for clarity (though that's subjective of course). -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-02-19 Thread via GitHub
cpoerschke commented on code in PR #2248: URL: https://github.com/apache/solr/pull/2248#discussion_r1494820258 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -1731,6 +1738,19 @@ private void getDocListC(QueryResult qr, QueryCommand cmd) throws IOExce

[PR] factor out SolrIndexSearcher.populateScoresIfNeeded method [solr]

2024-02-19 Thread via GitHub
cpoerschke opened a new pull request, #2280: URL: https://github.com/apache/solr/pull/2280 Small refactoring, noticed whilst code reading on #2248 pull request. No JIRA or CHANGES.txt entry needed here IMHO. The refactoring also makes it easier to see that there is what appears to be

Re: [PR] SOLR-16995: Configure replication behaviour for each replica type [solr]

2024-02-19 Thread via GitHub
murblanc commented on code in PR #2207: URL: https://github.com/apache/solr/pull/2207#discussion_r1494768851 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -120,9 +120,22 @@ public enum Type { */ PULL(false, false, true, CollectionAdminParams.

Re: [PR] SOLR-16995: Configure replication behaviour for each replica type [solr]

2024-02-19 Thread via GitHub
murblanc commented on code in PR #2207: URL: https://github.com/apache/solr/pull/2207#discussion_r1494762307 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -120,9 +120,22 @@ public enum Type { */ PULL(false, false, true, CollectionAdminParams.

Re: [PR] SOLR-17166 cloud.sh can't put solr.xml in zk anymore [solr]

2024-02-19 Thread via GitHub
epugh commented on PR #2279: URL: https://github.com/apache/solr/pull/2279#issuecomment-1952742957 I wonder if some of what cloud.sh does could be delegated to other scripts that get more testing? To make it less brittle? -- This is an automated message from the Apache Git Service. To re

[jira] [Updated] (SOLR-17141) Create CpuAllowedLimit implementation

2024-02-19 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-17141: Fix Version/s: 9.6.0 > Create CpuAllowedLimit implementation >

[jira] [Created] (SOLR-17166) SOLR-16975 (no solr.xml in zk) broke cloud.sh, fix

2024-02-19 Thread Gus Heck (Jira)
Gus Heck created SOLR-17166: --- Summary: SOLR-16975 (no solr.xml in zk) broke cloud.sh, fix Key: SOLR-17166 URL: https://issues.apache.org/jira/browse/SOLR-17166 Project: Solr Issue Type: Improvemen

[jira] [Commented] (SOLR-17141) Create CpuAllowedLimit implementation

2024-02-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818494#comment-17818494 ] ASF subversion and git services commented on SOLR-17141: Commit 5

Re: [PR] SOLR-17141: Create CpuQueryLimit implementation [solr]

2024-02-19 Thread via GitHub
sigram merged PR #2244: URL: https://github.com/apache/solr/pull/2244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-16291 : Decay function queries gauss,linear,exponential [solr]

2024-02-19 Thread via GitHub
janhoy commented on PR #939: URL: https://github.com/apache/solr/pull/939#issuecomment-1952497545 @risdenk Why do you think it is doing too much? As I interpret this, it will only parse the values for date (d) and geo fields (km), which is very user friendly. But if you wish you could still

[PR] SOLR-17099: snitch does not return spurious tags [solr]

2024-02-19 Thread via GitHub
psalagnac opened a new pull request, #2278: URL: https://github.com/apache/solr/pull/2278 https://issues.apache.org/jira/browse/SOLR-17099 # Description When retrieving values for placement plugin (former implicit snitch) we return spurious empty values. This is because the

[jira] [Updated] (SOLR-17141) Create CpuAllowedLimit implementation

2024-02-19 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-17141: Summary: Create CpuAllowedLimit implementation (was: Create CpuQueryLimit implementation)

[jira] [Commented] (SOLR-17097) Upgrade to Lucene 9.9.2

2024-02-19 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818442#comment-17818442 ] Mikhail Khludnev commented on SOLR-17097: - Hi, I suppose SOLR-17156 is related t

[jira] [Commented] (SOLR-17156) BJQParserTest failure

2024-02-19 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818389#comment-17818389 ] Mikhail Khludnev commented on SOLR-17156: - The first thing I noticed is hitting