[jira] [Commented] (SOLR-17148) Config API lies about setting cache enabled=false

2024-02-12 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816828#comment-17816828 ] Chris M. Hostetter commented on SOLR-17148: --- I'm not really familiar enough wit

Re: [PR] Build: ge.gradle add tags & projectId=solr [solr]

2024-02-12 Thread via GitHub
dsmiley commented on PR #2256: URL: https://github.com/apache/solr/pull/2256#issuecomment-1939760071 @clayburn I'm trying to enhance the metadata in Develocity/GE for the Solr builds. However I see no scans since Feb 7th as of this writing, which is weird. Wouldn't I at least see the resu

[jira] [Created] (SOLR-17159) Remove bin/post and bin/postlogs scripts and keep only bin/solr equivalents

2024-02-12 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-17159: Summary: Remove bin/post and bin/postlogs scripts and keep only bin/solr equivalents Key: SOLR-17159 URL: https://issues.apache.org/jira/browse/SOLR-17159 Project: Solr

Re: [PR] Remove stale versions [solr-docker]

2024-02-12 Thread via GitHub
janhoy commented on PR #18: URL: https://github.com/apache/solr-docker/pull/18#issuecomment-1939611645 > Some automation or an explicit step would be good or this will get skipped in the future! Perhaps rel.wizard could simply have a step asking RM to reflect over which versions to k

Re: [PR] Remove stale versions [solr-docker]

2024-02-12 Thread via GitHub
janhoy commented on PR #18: URL: https://github.com/apache/solr-docker/pull/18#issuecomment-1939608313 > 9.5 was just released, so I'd say it would be good to give a little bit of time before removing security updates for 9.4 at least. Otherwise I'm good with this. I can agree to thi

[jira] [Resolved] (SOLR-17089) Extraction module causes Jersey code to throw NoClassDefFoundError

2024-02-12 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-17089. Assignee: Jason Gerlowski Resolution: Fixed > Extraction module causes Jersey code to

[jira] [Closed] (SOLR-17089) Extraction module causes Jersey code to throw NoClassDefFoundError

2024-02-12 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski closed SOLR-17089. -- > Extraction module causes Jersey code to throw NoClassDefFoundError >

[jira] [Commented] (SOLR-17147) To commit or not to commit? That is the question on bin/solr post

2024-02-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816712#comment-17816712 ] ASF subversion and git services commented on SOLR-17147: Commit a

[jira] [Resolved] (SOLR-17147) To commit or not to commit? That is the question on bin/solr post

2024-02-12 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17147. -- Fix Version/s: main (10.0) 9.6.0 Resolution: Fixed > To commit or not to comm

[jira] [Commented] (SOLR-17147) To commit or not to commit? That is the question on bin/solr post

2024-02-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816709#comment-17816709 ] ASF subversion and git services commented on SOLR-17147: Commit 6

Re: [PR] SOLR-17147: Make committing documents after posting them the default behavior for bin/solr post [solr]

2024-02-12 Thread via GitHub
epugh merged PR #2253: URL: https://github.com/apache/solr/pull/2253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Resolved] (SOLR-17124) Complete Major changes and Upgrade Notes in RefGuide for 9.5.0

2024-02-12 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-17124. Fix Version/s: 9.5.0 Assignee: Jason Gerlowski Resolution: Fixed > Complete

[jira] [Comment Edited] (SOLR-13350) Explore collector managers for multi-threaded search

2024-02-12 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815862#comment-17815862 ] Noble Paul edited comment on SOLR-13350 at 2/12/24 4:29 PM: I

Re: [PR] Remove stale versions [solr-docker]

2024-02-12 Thread via GitHub
HoustonPutman commented on PR #18: URL: https://github.com/apache/solr-docker/pull/18#issuecomment-1939025230 9.5 was just released, so I'd say it would be good to give a little bit of time before removing security updates for 9.4 at least. Otherwise I'm good with this. -- This is an aut

Re: [PR] Remove stale versions [solr-docker]

2024-02-12 Thread via GitHub
epugh commented on PR #18: URL: https://github.com/apache/solr-docker/pull/18#issuecomment-1938975484 Some automation or an explicit step would be good or this will get skipped in the future! -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Assigned] (SOLR-17151) Review current usage of QueryLimits to ensure complete coverage

2024-02-12 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck reassigned SOLR-17151: --- Assignee: Gus Heck > Review current usage of QueryLimits to ensure complete coverage > -

[jira] [Assigned] (SOLR-17158) Terminate distributed processing quickly when query limit is reached

2024-02-12 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck reassigned SOLR-17158: --- Assignee: Gus Heck (was: Andrzej Bialecki) > Terminate distributed processing quickly when query li

[jira] [Comment Edited] (SOLR-17141) Create CpuQueryLimit implementation

2024-02-12 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816644#comment-17816644 ] Andrzej Bialecki edited comment on SOLR-17141 at 2/12/24 3:29 PM: -

[jira] [Commented] (SOLR-17141) Create CpuQueryLimit implementation

2024-02-12 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816644#comment-17816644 ] Andrzej Bialecki commented on SOLR-17141: - [~gus] and I discussed this issue - th

[jira] [Commented] (SOLR-17140) Refactor SolrQueryTimeoutImpl to support other implementations

2024-02-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816633#comment-17816633 ] ASF subversion and git services commented on SOLR-17140: Commit 0

[jira] [Commented] (SOLR-17138) Support other QueryTimeout criteria

2024-02-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816634#comment-17816634 ] ASF subversion and git services commented on SOLR-17138: Commit 0

Re: [PR] SOLR-17140 - provide extensible query limit concept. [solr]

2024-02-12 Thread via GitHub
gus-asf merged PR #2237: URL: https://github.com/apache/solr/pull/2237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17140 - provide extensible query limit concept. [solr]

2024-02-12 Thread via GitHub
gus-asf commented on PR #2237: URL: https://github.com/apache/solr/pull/2237#issuecomment-1938851757 Feedback addressed, tests pass locally and crave runs in past that have failed on crave have been ZK or recovery related... This is holding up other work so I'm merging it. -- This is an

Re: [PR] Improving array list and map init [solr]

2024-02-12 Thread via GitHub
renatoh commented on code in PR #2197: URL: https://github.com/apache/solr/pull/2197#discussion_r1486309875 ## solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java: ## @@ -117,7 +117,7 @@ public class SearchHandler extends RequestHandlerBase private SolrCor

[jira] [Assigned] (SOLR-17148) Config API lies about setting cache enabled=false

2024-02-12 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-17148: Assignee: Eric Pugh > Config API lies about setting cache enabled=false >

[jira] [Commented] (SOLR-17148) Config API lies about setting cache enabled=false

2024-02-12 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816624#comment-17816624 ] Eric Pugh commented on SOLR-17148: -- Are we good with the patch then? I'm happy to go t

Re: [PR] SOLR-17148: Fixing Config API overlay property enabling or disabling cache [solr]

2024-02-12 Thread via GitHub
epugh commented on code in PR #2247: URL: https://github.com/apache/solr/pull/2247#discussion_r1486273840 ## solr/core/src/java/org/apache/solr/search/CacheConfig.java: ## @@ -177,8 +177,8 @@ public SolrCache newInstance() { @Override public Map toMap(Map argsMap) { -

Re: [PR] Improving array list and map init [solr]

2024-02-12 Thread via GitHub
epugh commented on code in PR #2197: URL: https://github.com/apache/solr/pull/2197#discussion_r1486251420 ## solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java: ## @@ -117,7 +117,7 @@ public class SearchHandler extends RequestHandlerBase private SolrCore

Re: [PR] SOLR-17140 - provide extensible query limit concept. [solr]

2024-02-12 Thread via GitHub
gus-asf commented on PR #2237: URL: https://github.com/apache/solr/pull/2237#issuecomment-1938767804 > At Salesforce, we've extended this concept to also apply to indexing and one could imagine maybe someone using it in other cases. The "Query" in the name is unfortunate... can we call

[jira] [Updated] (SOLR-17157) upgrade to Lucene 9.10.0

2024-02-12 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-17157: --- Description: Creating and leaving this Jira open for (new) devs to grab. optional st

Re: [PR] SOLR-17147: Make committing documents after posting them the default behavior for bin/solr post [solr]

2024-02-12 Thread via GitHub
epugh commented on code in PR #2253: URL: https://github.com/apache/solr/pull/2253#discussion_r1486238901 ## solr/solr-ref-guide/modules/indexing-guide/pages/post-tool.adoc: ## @@ -44,51 +44,59 @@ The basic usage of `bin/solr post` is: [source,plain] -$ bin/solr post -h

Re: [PR] SOLR-17140 - provide extensible query limit concept. [solr]

2024-02-12 Thread via GitHub
gus-asf commented on code in PR #2237: URL: https://github.com/apache/solr/pull/2237#discussion_r1486238725 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -972,7 +978,8 @@ private DocSet getAndCacheDocSet(Query query) throws IOException { }

[jira] [Commented] (SOLR-16466) Admin UI - Make it optional to sort list of commandline args

2024-02-12 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816614#comment-17816614 ] Christine Poerschke commented on SOLR-16466: Makes sense, thanks for trying o

Re: [PR] SOLR-17147: Make committing documents after posting them the default behavior for bin/solr post [solr]

2024-02-12 Thread via GitHub
epugh commented on code in PR #2253: URL: https://github.com/apache/solr/pull/2253#discussion_r1486238161 ## solr/solr-ref-guide/modules/indexing-guide/pages/post-tool.adoc: ## @@ -44,51 +44,59 @@ The basic usage of `bin/solr post` is: [source,plain] -$ bin/solr post -h

Re: [PR] SOLR-17140 - provide extensible query limit concept. [solr]

2024-02-12 Thread via GitHub
gus-asf commented on code in PR #2237: URL: https://github.com/apache/solr/pull/2237#discussion_r1486232591 ## solr/core/src/java/org/apache/solr/request/SolrRequestInfo.java: ## @@ -210,6 +216,32 @@ public void addCloseHook(Closeable hook) { } } + /** + * This call

Re: [PR] SOLR-17140 - provide extensible query limit concept. [solr]

2024-02-12 Thread via GitHub
gus-asf commented on code in PR #2237: URL: https://github.com/apache/solr/pull/2237#discussion_r1486229317 ## solr/core/src/java/org/apache/solr/search/QueryLimits.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

Re: [PR] SOLR-17140 - provide extensible query limit concept. [solr]

2024-02-12 Thread via GitHub
gus-asf commented on code in PR #2237: URL: https://github.com/apache/solr/pull/2237#discussion_r1486226946 ## solr/core/src/java/org/apache/solr/search/QueryLimits.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

Re: [PR] Update password hash documentation on basic authentication [solr]

2024-02-12 Thread via GitHub
epugh merged PR #2257: URL: https://github.com/apache/solr/pull/2257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update password hash documentation on basic authentication [solr]

2024-02-12 Thread via GitHub
epugh commented on PR #2257: URL: https://github.com/apache/solr/pull/2257#issuecomment-1938712258 Thanks @BitPatty and @janhoy for this improvement! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Update password hash documentation on basic authentication [solr]

2024-02-12 Thread via GitHub
janhoy commented on PR #2257: URL: https://github.com/apache/solr/pull/2257#issuecomment-1938651097 @epugh You may find https://github.com/clemente-biondo/clemente-biondo.github.io/blob/master/solr_pwd_encryption.js interesting, it is JS code which is perhaps easier to read to understand th

Re: [PR] Update password hash documentation on basic authentication [solr]

2024-02-12 Thread via GitHub
janhoy commented on code in PR #2257: URL: https://github.com/apache/solr/pull/2257#discussion_r1486153466 ## solr/solr-ref-guide/modules/deployment-guide/pages/basic-authentication-plugin.adoc: ## @@ -55,7 +55,7 @@ There are several options defined in this example: <1> The f

[jira] [Comment Edited] (SOLR-16466) Admin UI - Make it optional to sort list of commandline args

2024-02-12 Thread Vincenzo D'Amore (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816097#comment-17816097 ] Vincenzo D'Amore edited comment on SOLR-16466 at 2/12/24 12:20 PM:

[jira] [Commented] (SOLR-16466) Admin UI - Make it optional to sort list of commandline args

2024-02-12 Thread Vincenzo D'Amore (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816585#comment-17816585 ] Vincenzo D'Amore commented on SOLR-16466: - [~cpoerschke] in conclusion, if you do

[PR] Update password hash documentation on basic authentication [solr]

2024-02-12 Thread via GitHub
BitPatty opened a new pull request, #2257: URL: https://github.com/apache/solr/pull/2257 https://issues.apache.org/jira/browse/SOLR-X # Description The algorithm for the password hash in the basic auth plugin docs is incorrect: ```diff - sha256(passwor

Re: [PR] Improving array list and map init [solr]

2024-02-12 Thread via GitHub
renatoh commented on PR #2197: URL: https://github.com/apache/solr/pull/2197#issuecomment-1938269000 anybody? @epugh could you please have a look at it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to